CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-05-15 13:38:26 +02:00
Code Issues Packages Projects Releases Wiki Activity

Correct Osmose UI element spacing

Browse Source
This commit is contained in:
SilentSpike
2020-02-03 18:33:41 +00:00
parent ecadafb3e4
commit 1dd65cb93e
2 changed files with 26 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
css/80_app.css
+2 -2
View File
@@ -2753,9 +2753,9 @@ input.key-trap {
[dir='rtl'] .error-details-description-text::first-letter {
text-transform: none; /* #5877 */
}
.error-details-description
.error-details-subtitle {
.error-details-subsection h4 {
padding-top: 10px;
padding-bottom: 0px;
}
.error-details code {
padding: .2em .4em;
modules/ui/osmose_details.js
+24 -19
View File
@@ -53,31 +53,37 @@ export function uiOsmoseDetails(context) {
.html(d => issueString(d, 'detail'));
// Elements (populated later as data is requested)
const detailsDiv = descriptionEnter.append('div');
const detailsDiv = descriptionEnter
.append('div')
.attr('class', 'error-details-subsection');
const elemsDiv = descriptionEnter
.append('div')
.attr('class', 'error-details-subsection');
// Suggested Fix (musn't exist for every issue type)
if (issueString(_error, 'fix') !== unknown) {
descriptionEnter
.append('h4')
.attr('class', 'error-details-subtitle')
.text(() => t('QA.osmose.fix_title'));
let div = descriptionEnter
.append('div')
.attr('class', 'error-details-subsection')
descriptionEnter
.append('p')
.attr('class', 'error-details-fix-text')
div.append('h4')
.text(() => t('QA.osmose.fix_title'))
div.append('p')
.html(d => issueString(d, 'fix'));
}
// Common Pitfalls (musn't exist for every issue type)
if (issueString(_error, 'trap') !== unknown) {
descriptionEnter
.append('h4')
.attr('class', 'error-details-subtitle')
.text(() => t('QA.osmose.trap_title'));
let div = descriptionEnter
.append('div')
.attr('class', 'error-details-subsection')
descriptionEnter
.append('p')
.attr('class', 'error-details-trap-text')
div.append('h4')
.text(() => t('QA.osmose.trap_title'))
div.append('p')
.html(d => issueString(d, 'trap'));
}
@@ -90,21 +96,20 @@ export function uiOsmoseDetails(context) {
detailsDiv
.append('h4')
.attr('class', 'error-details-subtitle')
.text(() => t('QA.osmose.detail_title'));
.text(() => t('QA.osmose.detail_title'))
detailsDiv
.append('p')
.attr('class', 'error-details-detail')
.html(d => d.detail);
}
// Create list of linked issue elements
detailsDiv
elemsDiv
.append('h4')
.attr('class', 'error-details-subtitle')
.text(() => t('QA.osmose.elems_title'));
detailsDiv
elemsDiv
.append('ul')
.attr('class', 'error-details-elements')
.selectAll('.error_entity_link')