Fix negative number of trips in ImproveOSM issues

See https://github.com/openstreetmap/iD/pull/5739#issuecomment-460786055
This commit is contained in:
SilentSpike
2019-02-09 16:28:27 +00:00
parent 6ff381cb28
commit 24022416cb
4 changed files with 14 additions and 4 deletions

View File

@@ -684,6 +684,7 @@ en:
mr:
title: Missing Geometry
description: '{num_trips} recorded trips in this area suggest there may be unmapped {geometry_type} here.'
description_alt: 'Data from a 3rd party suggests there may be unmapped {geometry_type} here.'
tr:
title: Missing Turn Restriction
description: '{num_passed} of {num_trips} recorded trips (travelling {travel_direction}) make a turn from {from_way} to {to_way} at {junction}. There may be a missing "{turn_restriction}" restriction.'
@@ -1547,4 +1548,4 @@ en:
wikidata:
identifier: "Identifier"
label: "Label"
description: "Description"
description: "Description"

View File

@@ -828,7 +828,8 @@
},
"mr": {
"title": "Missing Geometry",
"description": "{num_trips} recorded trips in this area suggest there may be unmapped {geometry_type} here."
"description": "{num_trips} recorded trips in this area suggest there may be unmapped {geometry_type} here.",
"description_alt": "Data from a 3rd party suggests there may be unmapped {geometry_type} here."
},
"tr": {
"title": "Missing Turn Restriction",

View File

@@ -267,6 +267,11 @@ export default {
geometry_type: t('QA.improveOSM.geometry_types.' + geoType)
};
// -1 trips indicates data came from a 3rd party
if (feature.numberOfTrips === -1) {
d.desc = t('QA.improveOSM.error_types.mr.description_alt', d.replacements);
}
_erCache.data[d.id] = d;
_erCache.rtree.insert(encodeErrorRtree(d));
});
@@ -476,4 +481,4 @@ export default {
getClosedIDs: function() {
return Object.keys(_erCache.closed).sort();
}
};
};

View File

@@ -17,6 +17,9 @@ export function uiImproveOsmDetails(context) {
var unknown = t('inspector.unknown');
if (!d) return unknown;
if (d.desc) return d.desc;
var errorType = d.error_key;
var et = dataEn.QA.improveOSM.error_types[errorType];
@@ -124,4 +127,4 @@ export function uiImproveOsmDetails(context) {
return improveOsmDetails;
}
}