CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-05-17 14:23:38 +02:00
Code Issues Packages Projects Releases Wiki Activity

Don't reverse cardinal direction roles on relations anymore

Browse Source 
re: https://github.com/openstreetmap/iD/pull/2004#issuecomment-407995998

Per thread https://twitter.com/bhousel/status/1025805098063208448
JOSM has stopped doing this too
This commit is contained in:
Bryan Housel
2018-08-04 21:55:14 -04:00
parent 490d4d39f3
commit 2e6799ac60
2 changed files with 7 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/actions/reverse.js
+1 -5
View File
@@ -40,11 +40,7 @@ export function actionReverse(wayID, options) {
forward: 'backward',
backward: 'forward',
forwards: 'backward',
backwards: 'forward',
north: 'south',
south: 'north',
east: 'west',
west: 'east'
backwards: 'forward'
};
var onewayReplacements = {
yes: '-1',
test/spec/actions/reverse.js
+6 -6
View File
@@ -286,7 +286,7 @@ describe('iD.actionReverse', function () {
.entity('backwards').members[0].role).to.eql('forward', 'backwards');
});
it('transforms role=north ⟺ role=south in member relations', function () {
it('doesn\'t transform role=north ⟺ role=south in member relations', function () {
var graph = iD.coreGraph([
iD.osmNode({id: 'n1'}),
iD.osmNode({id: 'n2'}),
@@ -296,12 +296,12 @@ describe('iD.actionReverse', function () {
]);
expect(iD.actionReverse('w1')(graph)
.entity('north').members[0].role).to.eql('south', 'north');
.entity('north').members[0].role).to.eql('north', 'north');
expect(iD.actionReverse('w1')(graph)
.entity('south').members[0].role).to.eql('north', 'south');
.entity('south').members[0].role).to.eql('south', 'south');
});
it('transforms role=east ⟺ role=west in member relations', function () {
it('doesn\'t transform role=east ⟺ role=west in member relations', function () {
var graph = iD.coreGraph([
iD.osmNode({id: 'n1'}),
iD.osmNode({id: 'n2'}),
@@ -311,9 +311,9 @@ describe('iD.actionReverse', function () {
]);
expect(iD.actionReverse('w1')(graph)
.entity('east').members[0].role).to.eql('west', 'east');
.entity('east').members[0].role).to.eql('east', 'east');
expect(iD.actionReverse('w1')(graph)
.entity('west').members[0].role).to.eql('east', 'west');
.entity('west').members[0].role).to.eql('west', 'west');
});
it('ignores directionless roles in member relations', function () {