CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-05-20 23:44:47 +02:00
Code Issues Packages Projects Releases Wiki Activity

Credit user with a fix if they touched any involved entity

Browse Source 
This can occur if there are several ways disconnected from the graph and
the user fixes these, but then partially undoes their fixes.

The current diff might not contain the entity that fixed the issue
(reconnected the disconnected graph), but they did fix the issue elsewhere.
This commit is contained in:
Bryan Housel
2021-08-13 15:56:08 -04:00
parent 93b868d95f
commit 34c3ea472d
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/core/validator.js
+8 -3
View File
@@ -622,10 +622,11 @@ export function coreValidator(context) {
// `updateResolvedIssues()` (private)
// Determine if any issues were resolved for the given entities.
// This is called by `validate()` after validation of the head graph
//
// Give the user credit for fixing an issue if:
// - the issue is in the base cache
// - the issue is not in the head cache
// - the user did something to that entity
// - the user did something to one of the entities involved in the issue
//
// Arguments
// `entityIDs` - Array containing entity IDs.
@@ -635,9 +636,13 @@ export function coreValidator(context) {
const baseIssues = _baseCache.issuesByEntityID[entityID];
if (!baseIssues) return;
const userModified = _completeDiff.hasOwnProperty(entityID);
baseIssues.forEach(issueID => {
if (userModified && !_headCache.issuesByIssueID[issueID]) {
// Check if the user did something to one of the entities involved in this issue.
// (This issue could involve multiple entities, e.g. disconnected routable features)
const issue = _baseCache.issuesByIssueID[issueID];
const userModified = (issue.entityIds || []).some(id => _completeDiff.hasOwnProperty(id));
if (userModified && !_headCache.issuesByIssueID[issueID]) { // issue seems fixed
_resolvedIssueIDs.add(issueID);
} else { // issue still not resolved
_resolvedIssueIDs.delete(issueID); // (did undo, or possibly fixed and then re-caused the issue)