CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-02-13 01:02:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Support splitting areas at nodes connected to lines if the lines can't be split (close #6047)

Browse Source
This commit is contained in:
Quincy Morgan
2020-09-29 15:49:42 -04:00
parent 1348ed7c4f
commit 476e929eec
1 changed files with 23 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
modules/actions/split.js
View File

@@ -248,30 +248,36 @@ export function actionSplit(nodeIds, newWayIds) {
action.waysForNode = function(nodeId, graph) {
var node = graph.entity(nodeId);
var parents = graph.parentWays(node);
var hasLines = parents.some(function(parent) {
return parent.geometry(graph) === 'line';
});
var splittableParents = graph.parentWays(node).filter(isSplittable);
return parents.filter(function(parent) {
if (_wayIDs && _wayIDs.indexOf(parent.id) === -1)
return false;
if (!_wayIDs) {
// If the ways to split aren't specified, only split the lines.
// If there are no lines to split, split the areas.
if (!_wayIDs && hasLines && parent.geometry(graph) !== 'line')
return false;
if (parent.isClosed()) {
return true;
var hasLine = splittableParents.some(function(parent) {
return parent.geometry(graph) === 'line';
});
if (hasLine) {
return splittableParents.filter(function(parent) {
return parent.geometry(graph) === 'line';
});
}
}
return splittableParents;
function isSplittable(parent) {
// If the ways to split are specified, ignore everything else.
if (_wayIDs && _wayIDs.indexOf(parent.id) === -1) return false;
// We can fake splitting closed ways at their endpoints...
if (parent.isClosed()) return true;
// otherwise, we can't split nodes at their endpoints.
for (var i = 1; i < parent.nodes.length - 1; i++) {
if (parent.nodes[i] === nodeId) {
return true;
}
if (parent.nodes[i] === nodeId) return true;
}
return false;
});
}
};
action.ways = function(graph) {