CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-02-25 15:05:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix opening tag help in Firefox.

Browse Source 
Remove anchor tag, attach click event to tag help button.
This commit is contained in:
Brandon Liu
2013-01-19 13:04:23 -08:00
parent c27812b470
commit 5ab7cbb643
1 changed files with 43 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

89
js/id/ui/inspector.js
View File

@@ -141,53 +141,50 @@ iD.ui.inspector = function() {
var helpBtn = row.append('button')
.attr('tabindex', -1)
.attr('class', 'tag-help minor')
.append('a')
.attr('tabindex', -1)
.attr('target', '_blank')
.on('click', function(d) {
var params = _.extend({}, d, {
geometry: entity.geometry()
});
if (d.key && d.value) {
taginfo.docs(params, function(err, docs) {
var en = _.find(docs, function(d) {
return d.lang == 'en';
});
if (en) {
var types = [];
if (en.on_area) types.push('area');
if (en.on_node) types.push('point');
if (en.on_way) types.push('line');
en.types = types;
iD.ui.modal()
.select('.content')
.datum(en)
.call(iD.ui.tagReference);
} else {
iD.ui.flash()
.select('.content')
.text('This is no documentation available for this tag combination');
}
});
} else if (d.key) {
taginfo.values(params, function(err, values) {
if (values.data.length) {
iD.ui.modal()
.select('.content')
.datum({
data: values.data,
title: 'Key:' + params.key,
geometry: params.geometry
})
.call(iD.keyReference);
} else {
iD.ui.flash()
.select('.content')
.text('This is no documentation available for this key');
}
});
}
.on('click', function(d) {
var params = _.extend({}, d, {
geometry: entity.geometry()
});
if (d.key && d.value) {
taginfo.docs(params, function(err, docs) {
var en = _.find(docs, function(d) {
return d.lang == 'en';
});
if (en) {
var types = [];
if (en.on_area) types.push('area');
if (en.on_node) types.push('point');
if (en.on_way) types.push('line');
en.types = types;
iD.ui.modal()
.select('.content')
.datum(en)
.call(iD.ui.tagReference);
} else {
iD.ui.flash()
.select('.content')
.text('This is no documentation available for this tag combination');
}
});
} else if (d.key) {
taginfo.values(params, function(err, values) {
if (values.data.length) {
iD.ui.modal()
.select('.content')
.datum({
data: values.data,
title: 'Key:' + params.key,
geometry: params.geometry
})
.call(iD.keyReference);
} else {
iD.ui.flash()
.select('.content')
.text('This is no documentation available for this key');
}
});
}
});
helpBtn.append('span')
.attr('class', 'icon inspect');