CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-02-28 00:13:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

Need issue id to actually change for d3 to replace it

Browse Source 
(re: #6407)

What's happening here is that the validator is updating the issues, but the
entity_issues component leaves the original issue in the list because the `id`
has not changed.

Need to review all the validators to see if others have this problem too.
This commit is contained in:
Bryan Housel
2019-05-22 23:47:53 -04:00
parent 28db4df86b
commit 5b8db55b47
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
modules/validations/outdated_tags.js
View File

@@ -4,6 +4,7 @@ import { matcher, brands } from 'name-suggestion-index';
import { actionChangePreset } from '../actions/change_preset'; import { actionChangePreset } from '../actions/change_preset';
import { actionChangeTags } from '../actions/change_tags'; import { actionChangeTags } from '../actions/change_tags';
import { actionUpgradeTags } from '../actions/upgrade_tags'; import { actionUpgradeTags } from '../actions/upgrade_tags';
import { osmEntity } from '../osm/entity';
import { osmIsOldMultipolygonOuterMember, osmOldMultipolygonOuterMemberOfRelation } from '../osm/multipolygon'; import { osmIsOldMultipolygonOuterMember, osmOldMultipolygonOuterMemberOfRelation } from '../osm/multipolygon';
import { utilDisplayLabel, utilTagDiff } from '../util'; import { utilDisplayLabel, utilTagDiff } from '../util';
import { validationIssue, validationIssueFix } from '../core/validation'; import { validationIssue, validationIssueFix } from '../core/validation';
@@ -92,7 +93,7 @@ export function validationOutdatedTags() {
}, },
reference: showReference, reference: showReference,
entityIds: [entity.id], entityIds: [entity.id],
hash: JSON.stringify(tagDiff), hash: osmEntity.key(entity),
fixes: [ fixes: [
new validationIssueFix({ new validationIssueFix({
autoArgs: [doUpgrade, t('issues.fix.upgrade_tags.annotation')], autoArgs: [doUpgrade, t('issues.fix.upgrade_tags.annotation')],