Handle indoor features like buildings when checking for crossing ways

see https://github.com/openstreetmap/iD/issues/8944#issuecomment-1029213558
This commit is contained in:
Martin Raifer
2022-02-03 19:11:27 +01:00
parent fcd8a2b2e7
commit 6a9e0997c7
2 changed files with 5 additions and 1 deletions
+3
View File
@@ -43,6 +43,8 @@ _Breaking developer changes, which may affect downstream projects or sites that
#### :newspaper: News
* Drop legacy support for Internet Explorer 11 ([#8811])
#### :white_check_mark: Validation
* Handle indoor features like buildings when checking for crossing ways ([#8944])
#### :rocket: Presets
* Optimize order of values in dropdowns of `access` fields ([#8945])
#### :hammer: Development
@@ -50,6 +52,7 @@ _Breaking developer changes, which may affect downstream projects or sites that
[#8774]: https://github.com/openstreetmap/iD/pull/8774
[#8811]: https://github.com/openstreetmap/iD/issues/8811
[#8944]: https://github.com/openstreetmap/iD/issues/8944
[#8945]: https://github.com/openstreetmap/iD/issues/8945
+2 -1
View File
@@ -109,7 +109,8 @@ export function validationCrossingWays(context) {
if (featureType1 === 'waterway' && featureType2 === 'highway' && tags2.man_made === 'pier') return true;
if (featureType2 === 'waterway' && featureType1 === 'highway' && tags1.man_made === 'pier') return true;
if (featureType1 === 'building' || featureType2 === 'building') {
if (featureType1 === 'building' || featureType2 === 'building' ||
taggedAsIndoor(tags1) || taggedAsIndoor(tags2)) {
// for building crossings, different layers are enough
if (layer1 !== layer2) return true;
}