CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-02-14 01:33:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

Ignore uninteresting tags and type=multipolygon for missing tags validation

Browse Source
This commit is contained in:
Quincy Morgan
2019-01-25 13:27:49 -05:00
parent 3886ce2ba8
commit 6fff896169
1 changed files with 14 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
modules/validations/missing_tag.js
View File

@@ -1,4 +1,5 @@
import _without from 'lodash-es/without';
import { osmIsInterestingTag } from '../osm/tags';
import { t } from '../util/locale';
import {
utilDisplayLabel
@@ -13,10 +14,12 @@ import { operationDelete } from '../operations/index';
export function validationMissingTag(context) {
// Slightly stricter check than Entity#isUsed (#3091)
function hasTags(entity, graph) {
return _without(Object.keys(entity.tags), 'area', 'name').length > 0 ||
graph.parentRelations(entity).length > 0;
function hasDescriptiveTags(entity) {
var keys = _without(Object.keys(entity.tags), 'area', 'name').filter(osmIsInterestingTag);
if (entity.type === 'relation' && keys.length === 1) {
return entity.tags.type !== 'multipolygon';
}
return keys.length > 0;
}
var validation = function(entitiesToCheck, graph) {
@@ -24,17 +27,18 @@ export function validationMissingTag(context) {
var issues = [];
for (var i = 0; i < entitiesToCheck.length; i++) {
var change = entitiesToCheck[i];
var geometry = change.geometry(graph);
if (types.indexOf(geometry) !== -1 && !hasTags(change, graph)) {
var entityLabel = utilDisplayLabel(change, context);
var entity = entitiesToCheck[i];
var geometry = entity.geometry(graph);
// ignore vertex features
if (types.indexOf(geometry) !== -1 &&
!(hasDescriptiveTags(entity) || entity.hasParentRelations(graph))) {
var entityLabel = utilDisplayLabel(entity, context);
issues.push(new validationIssue({
type: ValidationIssueType.missing_tag,
severity: ValidationIssueSeverity.error,
message: t('issues.untagged_feature.message', {feature: entityLabel}),
tooltip: t('issues.untagged_feature.tip'),
entities: [change],
entities: [entity],
fixes: [
new validationIssueFix({
title: t('issues.fix.select_preset.title'),