CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-02-13 01:02:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

More minor corrections from code review

Browse Source
This commit is contained in:
Minh Nguyễn
2021-11-12 23:05:19 -08:00
parent 9817894752
commit 74fdf17477
3 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
modules/core/localizer.js
View File

@@ -432,6 +432,7 @@ export function coreLocalizer() {
return (number) => number.toLocaleString(locale);
}
};
localizer.floatParser = (locale) => {
// https://stackoverflow.com/a/55366435/4585461
const polyfill = (string) => parseFloat(string.trim());

6
modules/ui/fields/input.js
View File

@@ -137,7 +137,7 @@ export function uiFieldText(field, context) {
v = v.trim();
var num = parseLocaleFloat(v);
if (isDirectionField) {
const compassDir = cardinal[v.trim().toLowerCase()];
const compassDir = cardinal[v.toLowerCase()];
if (compassDir !== undefined) {
num = compassDir;
}
@@ -145,7 +145,7 @@ export function uiFieldText(field, context) {
// do nothing if the value is neither a number, nor a cardinal direction
if (!isFinite(num)) return v;
num = parseFloat(num, 10);
num = parseFloat(num);
if (!isFinite(num)) return v;
num += d;
@@ -401,7 +401,7 @@ export function uiFieldText(field, context) {
var vals = val.split(';');
vals = vals.map(function(v) {
var num = parseLocaleFloat(v);
return isFinite(num)) ? clamped(num) : v;
return isFinite(num) ? clamped(num) : v;
});
val = vals.join(';');
}

6
modules/ui/fields/roadheight.js
View File

@@ -165,16 +165,16 @@ export function uiFieldRoadheight(field, context) {
if (primaryValue && (primaryValue.indexOf('\'') >= 0 || primaryValue.indexOf('"') >= 0)) {
secondaryValue = primaryValue.match(/(-?[\d.]+)"/);
if (secondaryValue !== null) {
secondaryValue = formatFloat(parseFloat(secondaryValue[1], 10));
secondaryValue = formatFloat(parseFloat(secondaryValue[1]));
}
primaryValue = primaryValue.match(/(-?[\d.]+)'/);
if (primaryValue !== null) {
primaryValue = formatFloat(parseFloat(primaryValue[1], 10));
primaryValue = formatFloat(parseFloat(primaryValue[1]));
}
_isImperial = true;
} else if (primaryValue) {
var rawValue = primaryValue;
primaryValue = parseFloat(rawValue, 10);
primaryValue = parseFloat(rawValue);
if (isNaN(primaryValue)) primaryValue = rawValue;
primaryValue = formatFloat(primaryValue);
_isImperial = false;