CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-05-19 23:14:47 +02:00
Code Issues Packages Projects Releases Wiki Activity

Don't flag missing tags for nodes on unloaded tiles

Browse Source
This commit is contained in:
Quincy Morgan
2019-11-22 15:32:27 -05:00
parent 59f0c04e13
commit 7945f5d6ff
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/validations/missing_tag.js
+7 -4
View File
@@ -6,7 +6,7 @@ import { utilDisplayLabel } from '../util';
import { validationIssue, validationIssueFix } from '../core/validation';
export function validationMissingTag() {
export function validationMissingTag(context) {
var type = 'missing_tag';
function hasDescriptiveTags(entity, graph) {
@@ -43,8 +43,12 @@ export function validationMissingTag() {
var validation = function checkMissingTag(entity, graph) {
// ignore vertex features and relation members
if (entity.geometry(graph) === 'vertex' || entity.hasParentRelations(graph)) {
// we can't know if the node is a vertex if the tile is undownloaded
if ((entity.type === 'node' && !context.connection().isDataLoaded(entity.loc)) ||
// allow untagged nodes that are part of ways
entity.geometry(graph) === 'vertex' ||
// allow untagged entities that are part of relations
entity.hasParentRelations(graph)) {
return [];
}
@@ -123,7 +127,6 @@ export function validationMissingTag() {
}
})];
function showReference(selection) {
selection.selectAll('.issue-reference')
.data([0])