mirror of
https://github.com/FoggedLens/iD.git
synced 2026-05-15 05:30:35 +02:00
Don't click cycle through alternating or reversible oneway states
(closes #4970) They are still supported as translated strings, and user can still enter these values in the raw tag editor, but they should not toggle with clicks in the checkbox field. This is because novice users are confused by what they mean.
This commit is contained in:
@@ -126,10 +126,17 @@ export function uiFieldCheck(field, context) {
|
||||
|
||||
input
|
||||
.on('click', function() {
|
||||
d3_event.stopPropagation();
|
||||
var t = {};
|
||||
t[field.key] = values[(values.indexOf(_value) + 1) % values.length];
|
||||
|
||||
// Don't cycle through `alternating` or `reversible` states - #4970
|
||||
// (They are supported as translated strings, but should not toggle with clicks)
|
||||
if (t[field.key] === 'reversible' || t[field.key] === 'alternating') {
|
||||
t[field.key] = values[0];
|
||||
}
|
||||
|
||||
dispatch.call('change', this, t);
|
||||
d3_event.stopPropagation();
|
||||
});
|
||||
|
||||
if (field.type === 'onewayCheck') {
|
||||
|
||||
Reference in New Issue
Block a user