CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-02-13 01:02:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Exclude 'fixme'/'help_request' warnings from changeset tags.

Browse Source 
They still appear in the issue list and in the entity editor.
(closes #8603)
This commit is contained in:
Bryan Housel
2021-08-02 14:34:18 -04:00
parent 6b1180f116
commit 857b9c9adf
2 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
modules/ui/commit.js
View File

@@ -193,7 +193,10 @@ export function uiCommit(context) {
// add counts of warnings generated by the user's edits
var warnings = context.validator()
.getIssuesBySeverity({ what: 'edited', where: 'all', includeIgnored: true, includeDisabledRules: true }).warning;
.getIssuesBySeverity({ what: 'edited', where: 'all', includeIgnored: true, includeDisabledRules: true })
.warning
.filter(function(issue) { return issue.type !== 'help_request'; }); // exclude 'fixme' and similar - #8603
addIssueCounts(warnings, 'warnings');
// add counts of issues resolved by the user's edits

5
modules/ui/commit_warnings.js
View File

@@ -12,6 +12,11 @@ export function uiCommitWarnings(context) {
for (var severity in issuesBySeverity) {
var issues = issuesBySeverity[severity];
if (severity !== 'error') { // exclude 'fixme' and similar - #8603
issues = issues.filter(function(issue) { return issue.type !== 'help_request'; });
}
var section = severity + '-section';
var issueItem = severity + '-item';