CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-03-31 01:09:22 +02:00
Code Issues Packages Projects Releases Wiki Activity

Revert 55715a482 - caused raw_tag_editor combos to not blur in Safari

Browse Source
This commit is contained in:
Bryan Housel
2019-01-28 11:20:32 -05:00
parent 4ef46a4b1d
commit 87ddfa68dc
1 changed files with 1 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
modules/ui/combobox.js
View File

@@ -120,9 +120,6 @@ export function uiCombobox(context, klass) {
function blur() {
// Try to dispatch accept here, but no guarantee - see note in `accept`
accept(null, true); // null = datum, true = onBlur
_comboHideTimerID = window.setTimeout(hide, 75);
}
@@ -399,7 +396,7 @@ export function uiCombobox(context, klass) {
// Dispatches an 'accept' event
// Then hides the combobox.
function accept(d, onBlur) {
function accept(d) {
_cancelFetch = true;
var thiz = input.node();
@@ -413,17 +410,6 @@ export function uiCombobox(context, klass) {
thiz.setSelectionRange(val.length, val.length);
d = _fetched[val];
// Try to dispatch `accept` onBlur, but only if we matched field to fetched datum.
// Surprisingly, this might happen:
// - user accepts a value in raw tag editor by pressing 'tab'
// - we dispatch `accept`
// - value change kicks off an event cascade *which replaces the combo*
// - 'tab' takes the user to the next field, blurring the current one
// - we get here, but the combo is new and has no datum yet
// - so just return because there's no reason to fire another `accept` with no datum
if (onBlur && !d) return;
dispatch.call('accept', thiz, d, val);
hide();
}