Rename fix function from action to onClick

This commit is contained in:
Quincy Morgan
2019-01-29 12:18:02 -05:00
parent 80c7aedb39
commit 907c4d9616
9 changed files with 11 additions and 11 deletions
+1 -1
View File
@@ -130,7 +130,7 @@ export function uiEntityIssues(context) {
return d.title;
})
.on('click', function(d) {
d.action();
d.onClick();
});
}
});
+1 -1
View File
@@ -257,7 +257,7 @@ export function validationHighwayCrossingOtherWays(context) {
fixes: [
new validationIssueFix({
title: t('issues.fix.add_connection_vertex.title'),
action: function() {
onClick: function() {
var loc = this.issue.coordinates;
var ways = this.issue.info.ways;
+1 -1
View File
@@ -41,7 +41,7 @@ export function validationDeprecatedTag(context) {
fixes: [
new validationIssueFix({
title: t('issues.fix.upgrade_tags.title'),
action: function() {
onClick: function() {
var entity = this.issue.entities[0];
var tags = _clone(entity.tags);
var replaceTags = this.issue.info.replaceTags;
+1 -1
View File
@@ -61,7 +61,7 @@ export function validationGenericName(context) {
fixes: [
new validationIssueFix({
title: t('issues.fix.remove_generic_name.title'),
action: function() {
onClick: function() {
var entity = this.issue.entities[0];
var tags = _clone(entity.tags);
delete tags.name;
@@ -121,7 +121,7 @@ export function validationHighwayAlmostJunction(context) {
var fixes = [
new validationIssueFix({
title: t('issues.fix.connect_almost_junction.title'),
action: function() {
onClick: function() {
var endNode = this.issue.entities[1],
targetEdge = this.issue.info.edge,
crossLoc = this.issue.info.cross_loc;
@@ -136,7 +136,7 @@ export function validationHighwayAlmostJunction(context) {
// node has no tags, suggest noexit fix
fixes.push(new validationIssueFix({
title: t('issues.fix.tag_as_disconnected.title'),
action: function() {
onClick: function() {
var nodeID = this.issue.entities[1].id;
context.perform(
actionChangeTags(nodeID, {noexit: 'yes'}),
+2 -2
View File
@@ -42,13 +42,13 @@ export function validationMissingTag(context) {
fixes: [
new validationIssueFix({
title: t('issues.fix.select_preset.title'),
action: function() {
onClick: function() {
context.ui().sidebar.showPresetList();
}
}),
new validationIssueFix({
title: t('issues.fix.delete_feature.title'),
action: function() {
onClick: function() {
var id = this.issue.entities[0].id;
operationDelete([id], context)();
}
+1 -1
View File
@@ -29,7 +29,7 @@ export function validationOldMultipolygon(context) {
fixes: [
new validationIssueFix({
title: t('issues.fix.move_tags.title'),
action: function() {
onClick: function() {
var outerWay = this.issue.entities[0];
var multipolygon = this.issue.entities[1];
context.perform(
+1 -1
View File
@@ -58,7 +58,7 @@ export function validationTagSuggestsArea(context) {
fixes: [
new validationIssueFix({
title: t('issues.fix.remove_tags.title'),
action: function() {
onClick: function() {
var entity = this.issue.entities[0];
var tags = _clone(entity.tags);
for (var key in suggestingTags) {
+1 -1
View File
@@ -94,7 +94,7 @@ export function validationIssue(attrs) {
export function validationIssueFix(attrs) {
this.title = attrs.title;
this.action = attrs.action;
this.onClick = attrs.onClick;
// the issue this fix is for
this.issue = null;