Present errors, namespace events.

This commit is contained in:
Tom MacWright
2012-12-05 11:25:01 -05:00
parent debd8b393b
commit 9799276472
4 changed files with 19 additions and 13 deletions
+4 -5
View File
@@ -107,18 +107,17 @@ iD.Connection = function() {
path: '/api/0.6/changeset/create',
options: { header: { 'Content-Type': 'text/xml' } },
content: iD.format.XML.changeset(comment)
},
function (changeset_id) {
}, function (err, changeset_id) {
oauth.xhr({
method: 'POST',
path: '/api/0.6/changeset/' + changeset_id + '/upload',
options: { header: { 'Content-Type': 'text/xml' } },
content: iD.format.XML.osmChange(user.id, changeset_id, changes)
}, function () {
}, function (err) {
oauth.xhr({
method: 'PUT',
path: '/api/0.6/changeset/' + changeset_id + '/close'
}, function () {
}, function (err) {
callback(changeset_id);
});
});
@@ -126,7 +125,7 @@ iD.Connection = function() {
}
function userDetails(callback) {
oauth.xhr({ method: 'GET', path: '/api/0.6/user/details' }, function(user_details) {
oauth.xhr({ method: 'GET', path: '/api/0.6/user/details' }, function(err, user_details) {
var u = user_details.getElementsByTagName('user')[0];
callback(connection.user({
display_name: u.attributes.display_name.nodeValue,
+3 -3
View File
@@ -49,9 +49,9 @@ iD.OAuth = function() {
var oauth_token_secret = token('oauth_token_secret');
o.oauth_signature = ohauth.signature(oauth_secret, oauth_token_secret,
ohauth.baseString(options.method, url, o));
ohauth.xhr(options.method, url, o, options.content, options.options, function(xhr) {
if (xhr.responseXML) callback(xhr.responseXML);
else callback(xhr.response);
ohauth.xhr(options.method, url, o, options.content, options.options, function(err, xhr) {
if (xhr.responseXML) callback(err, xhr.responseXML);
else callback(err, xhr.response);
});
};
+3 -3
View File
@@ -13,7 +13,7 @@ d3.typeahead = function() {
top: rect.bottom + 'px'
});
selection
.on('keyup.update', update);
.on('keyup.typeahead', update);
hidden = false;
}
@@ -26,8 +26,8 @@ d3.typeahead = function() {
}
selection
.on('focus', setup)
.on('blur', hide);
.on('focus.typeahead', setup)
.on('blur.typeahead', hide);
var idx = 0;
function update() {
+9 -2
View File
@@ -19,9 +19,16 @@ ohauth.stringQs = function(str) {
};
ohauth.xhr = function(method, url, auth, data, options, callback) {
var xhr = new XMLHttpRequest();
var xhr = new XMLHttpRequest(),
twoHundred = /^20\d$/;
xhr.onreadystatechange = function() {
if (4 == xhr.readyState && 0 !== xhr.status) callback(xhr);
if (4 == xhr.readyState && 0 !== xhr.status) {
if (twoHundred.test(xhr.status)) {
callback(null, xhr);
} else {
callback(xhr, null);
}
}
};
var headers = (options && options.header) || { 'Content-Type': 'application/x-www-form-urlencoded' };
xhr.open(method, url, true);