CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-05-15 13:38:26 +02:00
Code Issues Packages Projects Releases Wiki Activity

Don't cache point-as-vertex extraction fix

Browse Source
This commit is contained in:
Quincy Morgan
2019-11-25 10:49:16 -05:00
parent 6f09c3f4cc
commit 9f8e88a2ff
1 changed files with 21 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/validations/mismatched_geometry.js
+21 -19
View File
@@ -174,22 +174,6 @@ export function validationMismatchedGeometry(context) {
} else if (geometry === 'vertex' && !allowedGeometries.vertex && allowedGeometries.point) {
var extractOnClick = null;
if (!context.hasHiddenConnections(entity.id) &&
!actionExtract(entity.id, context.projection).disabled(context.graph())) {
extractOnClick = function(context) {
var entityId = this.issue.entityIds[0];
var action = actionExtract(entityId, context.projection);
context.perform(
action,
t('operations.extract.annotation.single')
);
// re-enter mode to trigger updates
context.enter(modeSelect(context, [action.getExtractedNodeID()]));
};
}
return new validationIssue({
type: type,
subtype: 'point_as_vertex',
@@ -209,7 +193,26 @@ export function validationMismatchedGeometry(context) {
.text(t('issues.point_as_vertex.reference'));
},
entityIds: [entity.id],
dynamicFixes: function() {
dynamicFixes: function(context) {
var entityId = this.entityIds[0];
var extractOnClick = null;
if (!context.hasHiddenConnections(entityId) &&
!actionExtract(entityId, context.projection).disabled(context.graph())) {
extractOnClick = function(context) {
var entityId = this.issue.entityIds[0];
var action = actionExtract(entityId, context.projection);
context.perform(
action,
t('operations.extract.annotation.single')
);
// re-enter mode to trigger updates
context.enter(modeSelect(context, [action.getExtractedNodeID()]));
};
}
return [
new validationIssueFix({
icon: 'iD-operation-extract',
@@ -217,8 +220,7 @@ export function validationMismatchedGeometry(context) {
onClick: extractOnClick
})
];
},
hash: typeof extractOnClick, // avoid stale extraction fix
}
});
}