CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-02-12 16:52:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

restore highlighting of empty changeset comment field

Browse Source 
restores behaviour from #4624/#4624, but switch to a neutral emphasis instead of the red color (which might be misinterpreted that the user already made a mistake)
This commit is contained in:
Martin Raifer
2025-02-25 17:51:23 +01:00
parent 211412bbdf
commit ab007dbbb8
3 changed files with 6 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
css/80_app.css
View File

@@ -2342,15 +2342,15 @@ input.date-selector {
/* Field - Changeset Comment
------------------------------------------------------- */
.form-field-comment:not(.present) #preset-input-comment {
border-color: rgb(230, 100, 100);
.form-field-comment:not(.present) textarea {
border-color: rgb(160, 160, 160);
}
.form-field-comment:not(.present) .field-label {
border-color: rgb(230, 100, 100);
background: rgba(230, 100, 100, 0.2);
border-color: rgb(160, 160, 160);
background-color: rgba(160, 160, 160, 0.2);
}
.form-field-comment:not(.present) button {
border-color: rgb(230, 100, 100);
border-color: rgb(160, 160, 160);
}

2
modules/ui/changeset_editor.js
View File

@@ -99,7 +99,7 @@ export function uiChangesetEditor(context) {
// Show warning(s) if comment mentions Google or comment length exceeds 255 chars
const warnings = [];
if (_tags.comment.match(/google/i)) {
if (_tags.comment?.match(/google/i)) {
warnings.push({
id: 'contains "google"',
msg: t.append('commit.google_warning'),

3
modules/ui/commit.js
View File

@@ -463,9 +463,6 @@ export function uiCommit(context) {
function changeTags(_, changed, onInput) {
if (changed.hasOwnProperty('comment')) {
if (changed.comment === undefined) {
changed.comment = '';
}
if (!onInput) {
prefs('comment', changed.comment);
prefs('commentDate', Date.now());