CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-02-27 16:03:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve general performance when lots of OSM data is downloaded (re: #7656)

Browse Source
This commit is contained in:
Quincy Morgan
2020-06-25 10:08:07 -04:00
parent c834ef192c
commit aec734100a
1 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
modules/core/difference.js
View File

@@ -1,7 +1,7 @@
import deepEqual from 'fast-deep-equal';
import { geoVecEqual } from '../geo';
import { utilArrayDifference, utilArrayUnion } from '../util';
import { utilArrayDifference, utilArrayUnion, utilArrayUniq } from '../util/array';
/*
@@ -57,8 +57,16 @@ export function coreDifference(base, head) {
}
}
for (var headId in head.entities) checkEntityID(headId);
for (var baseId in base.entities) checkEntityID(baseId);
function load() {
// HOT CODE: there can be many thousands of downloaded entities, so looping
// through them all can become a performance bottleneck. Optimize by
// resolving duplicates and using a basic `for` loop
var ids = utilArrayUniq(Object.keys(head.entities).concat(Object.keys(base.entities)));
for (var i = 0; i < ids.length; i++) {
checkEntityID(ids[i]);
}
}
load();
_diff.length = function length() {