CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-04-28 22:56:31 +02:00
Code Issues Packages Projects Releases Wiki Activity

Improved warning visibility

Browse Source 
for #1973
This commit is contained in:
Aaron Lidman
2013-11-19 12:04:12 -08:00
parent 3b3b57e146
commit bf0da89925
1 changed files with 30 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files
js/id/ui/commit.js
+30 -28
View File
@@ -48,6 +48,36 @@ iD.ui.Commit = function(context) {
commentField.node().select();
// Warnings
var warnings = body.selectAll('div.warning-section')
.data([iD.validate(changes, context.graph())])
.enter()
.append('div')
.attr('class', 'modal-section warning-section fillL2')
.style('display', function(d) { return _.isEmpty(d) ? 'none' : null; })
.style('background', '#ffb');
warnings.append('h3')
.text(t('commit.warnings'));
var warningLi = warnings.append('ul')
.attr('class', 'changeset-list')
.selectAll('li')
.data(function(d) { return d; })
.enter()
.append('li')
.style()
.on('mouseover', mouseover)
.on('mouseout', mouseout)
.on('click', warningClick);
warningLi.append('span')
.attr('class', 'alert icon icon-pre-text');
warningLi.append('strong').text(function(d) {
return d.message;
});
// Save Section
var saveSection = body.append('div')
.attr('class','modal-section fillL cf');
@@ -90,34 +120,6 @@ iD.ui.Commit = function(context) {
.attr('class', 'label')
.text(t('commit.save'));
// Warnings
var warnings = body.selectAll('div.warning-section')
.data([iD.validate(changes, context.graph())])
.enter()
.append('div')
.attr('class', 'modal-section warning-section fillL2')
.style('display', function(d) { return _.isEmpty(d) ? 'none' : null; });
warnings.append('h3')
.text(t('commit.warnings'));
var warningLi = warnings.append('ul')
.attr('class', 'changeset-list')
.selectAll('li')
.data(function(d) { return d; })
.enter()
.append('li')
.on('mouseover', mouseover)
.on('mouseout', mouseout)
.on('click', warningClick);
warningLi.append('span')
.attr('class', 'alert icon icon-pre-text');
warningLi.append('strong').text(function(d) {
return d.message;
});
var changeSection = body.selectAll('div.commit-section')
.data([0])
.enter()