remove addr:housename from presets

The [values](http://taginfo.openstreetmap.org/keys/addr%3Ahousename#values) of this rarely needed tag, which is prominent in the address presets, now have a lot of numbers and descriptive words in many different languages. Removing the preset means that new editors won’t fill this key with information useless to the key but can still add it through All tags if needed.  A similar thing happened when Potlatch put the designation tag into presets. Goes towards #1427 and #2124.
This commit is contained in:
AndrewHain
2014-02-16 11:36:41 +00:00
committed by John Firebaugh
parent 2ab9239a9f
commit c9709e9207
2 changed files with 1 additions and 13 deletions
-2
View File
@@ -1,7 +1,6 @@
{
"type": "address",
"keys": [
"addr:housename",
"addr:housenumber",
"addr:street",
"addr:city",
@@ -12,7 +11,6 @@
"label": "Address",
"strings": {
"placeholders": {
"housename": "Housename",
"number": "123",
"street": "Street",
"city": "City",
+1 -11
View File
@@ -1,6 +1,5 @@
iD.ui.preset.address = function(field, context) {
var event = d3.dispatch('change'),
housename,
housenumber,
street,
city,
@@ -98,12 +97,6 @@ iD.ui.preset.address = function(field, context) {
var enter = wrap.enter().append('div')
.attr('class', 'preset-input-wrap');
enter.append('input')
.property('type', 'text')
.attr('placeholder', field.t('placeholders.housename'))
.attr('class', 'addr-housename')
.attr('id', 'preset-input-' + field.id);
enter.append('input')
.property('type', 'text')
.attr('placeholder', field.t('placeholders.number'))
@@ -126,7 +119,6 @@ iD.ui.preset.address = function(field, context) {
// Update
housename = wrap.select('.addr-housename');
housenumber = wrap.select('.addr-number');
street = wrap.select('.addr-street');
city = wrap.select('.addr-city');
@@ -157,7 +149,6 @@ iD.ui.preset.address = function(field, context) {
function change() {
event.change({
'addr:housename': housename.value() || undefined,
'addr:housenumber': housenumber.value() || undefined,
'addr:street': street.value() || undefined,
'addr:city': city.value() || undefined,
@@ -172,7 +163,6 @@ iD.ui.preset.address = function(field, context) {
};
address.tags = function(tags) {
housename.value(tags['addr:housename'] || '');
housenumber.value(tags['addr:housenumber'] || '');
street.value(tags['addr:street'] || '');
city.value(tags['addr:city'] || '');
@@ -180,7 +170,7 @@ iD.ui.preset.address = function(field, context) {
};
address.focus = function() {
housename.node().focus();
housenumber.node().focus();
};
return d3.rebind(address, event, 'on');