CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-02-13 09:12:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix broken member role dropdown for members that are not downloaded

Browse Source 
(closes #5592)
This commit is contained in:
Bryan Housel
2018-12-12 16:53:20 -05:00
parent f45e97d727
commit cd74e4e063
1 changed files with 17 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
modules/ui/raw_member_editor.js
View File

@@ -192,7 +192,7 @@ export function uiRawMemberEditor(context) {
labelText
.append('span')
.attr('class', 'member-entity-type')
.text(t('inspector.'+d.type, { id: d.id }));
.text(t('inspector.' + d.type, { id: d.id }));
labelText
.append('span')
@@ -257,11 +257,26 @@ export function uiRawMemberEditor(context) {
role.call(uiCombobox(context, 'member-role')
.fetcher(function(role, callback) {
// The `geometry` param is used in the `taginfo.js` interface for
// filtering results, as a key into the `tag_members_fractions`
// object. If we don't know the geometry because the member is
// not yet downloaded, it's ok to guess based on type.
var geometry;
if (d.member) {
geometry = context.geometry(d.member.id);
} else if (d.type === 'relation') {
geometry = 'relation';
} else if (d.type === 'way') {
geometry = 'line';
} else {
geometry = 'point';
}
var rtype = entity.tags.type;
taginfo.roles({
debounce: true,
rtype: rtype || '',
geometry: context.geometry(d.member.id),
geometry: geometry,
query: role
}, function(err, data) {
if (!err) callback(sort(role, data));