CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-05-15 21:48:20 +02:00
Code Issues Packages Projects Releases Wiki Activity

Always display the wikidata label and description in the user's language, if available

Browse Source
This commit is contained in:
Quincy Morgan
2019-04-01 13:04:33 -04:00
parent d5d4323c02
commit cf6e6c7970
1 changed files with 18 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/ui/fields/wikidata.js
+18 -8
View File
@@ -233,9 +233,7 @@ export function uiFieldWikidata(field, context) {
function setLabelForEntity() {
var label = '';
if (_wikidataEntity) {
if (_wikidataEntity.labels && Object.keys(_wikidataEntity.labels).length > 0) {
label = _wikidataEntity.labels[Object.keys(_wikidataEntity.labels)[0]].value;
}
label = entityPropertyForDisplay(_wikidataEntity, 'labels');
if (label.length === 0) {
label = _wikidataEntity.id.toString();
}
@@ -263,11 +261,7 @@ export function uiFieldWikidata(field, context) {
setLabelForEntity();
var description = '';
if (entity.descriptions && Object.keys(entity.descriptions).length > 0) {
description = entity.descriptions[Object.keys(entity.descriptions)[0]].value;
}
var description = entityPropertyForDisplay(entity, 'descriptions');
d3_select('.form-field-wikidata button.wiki-link')
.classed('disabled', false);
@@ -309,6 +303,22 @@ export function uiFieldWikidata(field, context) {
}
};
function entityPropertyForDisplay(wikidataEntity, propKey) {
if (!wikidataEntity[propKey]) return '';
var propObj = wikidataEntity[propKey];
var langKeys = Object.keys(propObj);
if (langKeys.length === 0) return '';
// sorted by priority, since we want to show the user's language first if possible
var langs = wikidata.languagesToQuery();
for (var i in langs) {
var lang = langs[i];
var valueObj = propObj[lang];
if (valueObj && valueObj.value && valueObj.value.length > 0) return valueObj.value;
}
// default to any available value
return propObj[langKeys[0]].value;
}
wiki.entity = function(val) {
if (!arguments.length) return _entity;