CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-04-22 11:46:11 +02:00
Code Issues Packages Projects Releases Wiki Activity

Don't add ignore fix more than once

Browse Source 
Tweak hidden issues text
This commit is contained in:
Quincy Morgan
2019-05-01 20:21:47 -07:00
parent a180c794cb
commit d061ec6b61
3 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
data/core.yaml
+2 -2
View File
@@ -1290,9 +1290,9 @@ en:
none: Detected issues will appear here
elsewhere: "Issues elsewhere: {count}"
other_features: "Issues with other features: {count}"
other_features_elsewhere: "Issues with other features elsewhere: {count}"
other_features_elsewhere: "Issues elsewhere with other features: {count}"
disabled_rules: "Issues with disabled rules: {count}"
disabled_rules_elsewhere: "Issues with disabled rules elsewhere: {count}"
disabled_rules_elsewhere: "Issues elsewhere with disabled rules: {count}"
ignored_issues: "Ignored issues: {count}"
ignored_issues_elsewhere: "Ignored issues elsewhere: {count}"
options:
dist/locales/en.json
Vendored
+2 -2
View File
@@ -1581,9 +1581,9 @@
"none": "Detected issues will appear here",
"elsewhere": "Issues elsewhere: {count}",
"other_features": "Issues with other features: {count}",
"other_features_elsewhere": "Issues with other features elsewhere: {count}",
"other_features_elsewhere": "Issues elsewhere with other features: {count}",
"disabled_rules": "Issues with disabled rules: {count}",
"disabled_rules_elsewhere": "Issues with disabled rules elsewhere: {count}",
"disabled_rules_elsewhere": "Issues elsewhere with disabled rules: {count}",
"ignored_issues": "Ignored issues: {count}",
"ignored_issues_elsewhere": "Ignored issues elsewhere: {count}"
}
modules/core/validator.js
+3 -1
View File
@@ -221,7 +221,8 @@ export function coreValidator(context) {
var detected = fn(entity, context);
detected.forEach(function(issue) {
if (issue.severity === 'warning') {
var hasIgnoreFix = issue.fixes && issue.fixes.length && issue.fixes[issue.fixes.length - 1].type === 'ignore';
if (issue.severity === 'warning' && !hasIgnoreFix) {
var ignoreFix = new validationIssueFix({
title: t('issues.fix.ignore_issue.title'),
icon: 'iD-icon-close',
@@ -229,6 +230,7 @@ export function coreValidator(context) {
ignoreIssue(this.issue.id);
}
});
ignoreFix.type = 'ignore';
ignoreFix.issue = issue;
issue.fixes.push(ignoreFix);
}