Fix leftover errors and unused definitions

modules/services/osmose.js

@@ -3,9 +3,8 @@ import RBush from 'rbush';
 import { dispatch as d3_dispatch } from 'd3-dispatch';
 import { json as d3_json } from 'd3-fetch';
 
-import { geoExtent, geoVecAdd, geoVecScale } from '../geo';
+import { geoExtent, geoVecAdd } from '../geo';
 import { qaError } from '../osm';
-import { t } from '../util/locale';
 import { utilRebind, utilTiler, utilQsString } from '../util';
 import { services } from '../../data/qa_errors.json';
 
@@ -50,10 +49,6 @@ function updateRtree(item, replace) {
     }
 }
 
-function linkErrorObject(d) {
-    return '<a class="error_object_link">' + d + '</a>';
-}
-
 function linkEntity(d) {
     return '<a class="error_entity_link">' + d + '</a>';
 }
@@ -131,7 +126,7 @@ export default {
                         data.issues.forEach(function(issue) {
                             // Elements provided as string, separated by _ character
                             var elems = issue.elems.split('_').map(function(i) {
-                                    return i.substring(0,1) + i.replace(/node|way|relation/, '')
+                                    return i.substring(0,1) + i.replace(/node|way|relation/, '');
                                 });
                             var loc = [issue.lon, issue.lat];
                             // Item is the type of error, w/ class tells us the sub-type
@@ -155,7 +150,7 @@ export default {
 
                                 // Variables used in the description
                                 d.replacements = elems.map(function(i) {
-                                    return linkEntity(i)
+                                    return linkEntity(i);
                                 });
 
                                 _erCache.data[d.id] = d;
@@ -192,7 +187,7 @@ export default {
                 if (d.newStatus === '/done') {
                     // No pretty identifier, so we just use coordinates
                     var closedID = d.loc[1].toFixed(5) + '/' + d.loc[0].toFixed(5);
-                    _erCache.closed[key + ':' + closedID] = true;
+                    _erCache.closed[d.error_type + ':' + closedID] = true;
                 }
                 if (callback) callback(null, d);
             })

modules/ui/osmose_details.js

@@ -6,7 +6,7 @@ import {
 import { dataEn } from '../../data';
 import { modeSelect } from '../modes/select';
 import { t } from '../util/locale';
-import { utilDisplayName, utilEntityOrMemberSelector, utilEntityRoot } from '../util';
+import { utilDisplayName, utilEntityOrMemberSelector } from '../util';
 
 
 export function uiOsmoseDetails(context) {

modules/ui/osmose_editor.js

@@ -129,7 +129,7 @@ export function uiOsmoseEditor(context) {
             .merge(buttonEnter);
 
         buttonSection.select('.close-button')
-            .text(function(d) {
+            .text(function() {
                 return t('QA.keepRight.close');
             })
             .on('click.close', function(d) {
@@ -144,7 +144,7 @@ export function uiOsmoseEditor(context) {
             });
 
         buttonSection.select('.ignore-button')
-            .text(function(d) {
+            .text(function() {
                 return t('QA.keepRight.ignore');
             })
             .on('click.ignore', function(d) {