CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-05-15 21:48:20 +02:00
Code Issues Packages Projects Releases Wiki Activity

Use loops instead of functions in actionDisconnect.connections, for performance (re: #7706)

Browse Source
This commit is contained in:
Quincy Morgan
2020-06-16 13:18:59 -04:00
parent 5f93da5a59
commit e476321818
1 changed files with 15 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/actions/disconnect.js
+15 -9
View File
@@ -48,25 +48,31 @@ export function actionDisconnect(nodeId, newNodeId) {
var candidates = [];
var keeping = false;
var parentWays = graph.parentWays(graph.entity(nodeId));
parentWays.forEach(function(way) {
var way, waynode;
for (var i = 0; i < parentWays.length; i++) {
way = parentWays[i];
if (wayIds && wayIds.indexOf(way.id) === -1) {
keeping = true;
return;
continue;
}
if (way.isArea() && (way.nodes[0] === nodeId)) {
candidates.push({ wayID: way.id, index: 0 });
} else {
way.nodes.forEach(function(waynode, index) {
for (var j = 0; j < way.nodes.length; j++) {
waynode = way.nodes[j];
if (waynode === nodeId) {
if (way.isClosed() && parentWays.length > 1 && wayIds && wayIds.indexOf(way.id) !== -1 && index === way.nodes.length-1) {
return;
if (way.isClosed() &&
parentWays.length > 1 &&
wayIds &&
wayIds.indexOf(way.id) !== -1 &&
j === way.nodes.length - 1) {
continue;
}
candidates.push({ wayID: way.id, index: index });
candidates.push({ wayID: way.id, index: j });
}
});
}
}
});
}
return keeping ? candidates : candidates.slice(1);
};