CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-03-06 19:31:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Prevent accidental loading of many tiles at low zoom

Browse Source 
This could happen because `editable` was checked before the call was scheduled
not before the `loadTiles`.  The user can zoom out more while the call is deferred.
This commit is contained in:
Bryan Housel
2019-05-16 16:44:19 -04:00
parent aa7820b699
commit ec0145de3a
2 changed files with 11 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
modules/core/context.js
View File

@@ -135,21 +135,21 @@ export function coreContext() {
context.loadTiles = function(projection, callback) {
if (connection && context.editable()) {
var cid = connection.getConnectionId();
utilCallWhenIdle(function() {
utilCallWhenIdle(function() {
if (connection && context.editable()) {
var cid = connection.getConnectionId();
connection.loadTiles(projection, afterLoad(cid, callback));
})();
}
}
})();
};
context.loadTileAtLoc = function(loc, callback) {
if (connection && context.editable()) {
var cid = connection.getConnectionId();
utilCallWhenIdle(function() {
utilCallWhenIdle(function() {
if (connection && context.editable()) {
var cid = connection.getConnectionId();
connection.loadTileAtLoc(loc, afterLoad(cid, callback));
})();
}
}
})();
};
context.loadEntity = function(entityID, callback) {

3
modules/util/idle.js
View File

@@ -25,8 +25,7 @@ export function utilIdleWorker(tasks, processor, callback) {
callback(results);
})();
// alternatively, each task deferred in its own callback
// seems to not work because it
// alternatively, each task deferred in its own callback seems to not work
// var processed = [];
// var currentPos = 0;