Quincy Morgan
0e7a63f5c5
Add quick fix to unsquare way validation to tag a way as having unsquare corners ( close #6332 )
2019-05-09 12:04:18 -04:00
Bryan Housel
a72865e4d8
Treat anything with a from/via/to like a restriction
...
(closes #6221 )
Applies to actions like splitting, connecting, extracting a via node, etc
2019-04-29 21:58:10 -04:00
Bryan Housel
bd2490a965
Reverse internal left/right/forward/backward keyparts
...
(closes #6235 )
Previously only trailing keyparts would reverse:
`cycleway:left` ⟺ `cycleway:right`
Now it can do internal keyparts too:
`cycleway:left:surface` ⟺ `cycleway:right:surface`
2019-04-29 21:13:18 -04:00
Quincy Morgan
59bd6194e0
Add "autofix" for the unsquare building validation
2019-04-26 14:56:39 -07:00
Quincy Morgan
d01bb78707
Reduce circular dependencies caused by importing from indexes, the location of the validation models, and the location of areaKeys ( close #6237 )
2019-04-24 13:45:59 -07:00
Bryan Housel
05949608aa
Support straightening of points
...
(closes #6217 )
- Split `actionStraighten` into `actionStraightenWay` and `actionStraightenNodes`
- Now `operationStraighten` chooses the correct action depending on selected entities
- Also move `getSmallestSurroundingRectangle` from `actionReflect` to `geo.js`
2019-04-24 01:55:43 -04:00
Quincy Morgan
34fcd01f98
Add validation warning for unsquare buildings
2019-04-23 15:50:52 -07:00
Bryan Housel
bd2a33d845
Merge branch 'validation_and_change_perf'
2019-04-23 01:30:26 -04:00
Quincy Morgan
e04d860f62
Convert "Detach" operation into "Extract" operation that also works on areas ( close #6203 )
2019-04-22 14:46:01 -07:00
Bryan Housel
3557e3c711
Don't allow disconnecting a way if parts extend to undownloaded tiles
...
(re: #2248 , #4245 )
2019-04-20 00:02:46 -04:00
Bryan Housel
7c85cc997e
Merge branch 'master' into validation_and_change_perf
2019-04-19 22:44:04 -04:00
Quincy Morgan
a892114351
Fix disconnection code test ( close #4245 )
2019-04-19 13:26:16 -07:00
Bryan Housel
51c1088c1b
Merge branch 'master' into validation_and_change_perf
2019-04-19 15:18:23 -04:00
Quincy Morgan
130e9909f6
Allow disconnecting an entire way from other ways at once ( close #4245 )
2019-04-19 11:54:13 -07:00
Bryan Housel
0a77a494aa
Merge branch 'master' into validation_and_change_perf
2019-04-10 14:22:20 -04:00
Bryan Housel
df1a2ea361
Prevent some actions on features that extend beyond the loaded map
...
(closes #2248 )
2019-04-08 21:26:58 -04:00
Quincy Morgan
50a0982d79
Merge pull request #6161 from jguthrie100/fix_closed_way_disconnect
...
Leave way as closed when disconnecting
2019-04-08 11:08:33 -07:00
J Guthrie
00c7eaddc2
Fix to work with PhatomJS
2019-04-08 17:07:12 +01:00
Jamie Guthrie
d3d0a560eb
Remove excess whitespace
2019-04-08 16:01:08 +01:00
J Guthrie
d7865ac4aa
don't unclose way if it is part of a larger disconnect operation
2019-04-08 12:42:16 +01:00
Quincy Morgan
9d029a37a8
Delete newly-created untagged relations when deselecting them ( close #3812 )
2019-04-07 13:39:51 -07:00
Quincy Morgan
8815b878c5
Fix issue where selected way could not be disconnected if the connection point occurred more than once in the way ( close #6149 )
2019-04-07 12:47:20 -07:00
Quincy Morgan
34792d7fbf
Don't add field defaults when upgrading tags to a specific replacement
2019-04-03 10:57:42 -07:00
Bryan Housel
cda8f657ac
Swap fast-deep-equal for lodash isEqual
...
(re: #6087 )
2019-03-29 22:17:29 -04:00
Bryan Housel
3673a7c7e7
Remove lodash cloneDeep
...
(re #6087 )
- some were able to do a different approach
(validations/almost_junction, and settings/*)
- some were replaced with custom speedy cloners
(in orthogonalize clonePoints and osm.js cloneNoteCache)
- some just replaced with JSON.parse(JSON.stringify()))
2019-03-29 17:18:40 -04:00
Bryan Housel
d5abe468b9
Remove rest of the lodash iterators: map, reduce, forEach
...
(re: #6087 )
2019-03-29 15:14:21 -04:00
Bryan Housel
3896b2282f
Remove lodash isNaN, isNumber, isString, bind, uniqBy
...
(re: 6087)
2019-03-27 23:11:45 -04:00
Bryan Housel
3d80e6505f
Remove lodash chunk, groupBy
...
(re: #6087 )
2019-03-27 16:18:41 -04:00
Bryan Housel
8d210e8adb
Remove lodash indexOf
...
(re: 6087)
2019-03-27 09:45:53 -04:00
Bryan Housel
5b4aa529de
Replace lodash uniq
...
(re: 6087)
2019-03-27 02:43:25 -04:00
Bryan Housel
5e1ff74199
Replace lodash difference, intersects, union
...
(re: 6087)
2019-03-27 01:22:11 -04:00
Bryan Housel
4821bf0a68
Remove lodash omit
...
(re: #6087 )
2019-03-26 14:12:45 -04:00
Bryan Housel
1ce4f0ad6a
Remove lodash without
...
(re: #6087 )
2019-03-25 21:56:54 -04:00
Bryan Housel
5280d07bad
Remove lodash reject (re: #6087 )
2019-03-23 12:51:13 -04:00
Bryan Housel
76e0d13729
Remove lodash every and filter
...
(re: #6087 )
2019-03-23 01:22:56 -04:00
Bryan Housel
7a6c63fcc5
Remove lodash extend (re: #6087 )
2019-03-23 00:38:39 -04:00
Bryan Housel
7e6f68a1b2
Remove lodash some
...
(re: #6087 )
2019-03-23 00:07:52 -04:00
Bryan Housel
0e90167513
Remove lodash clone
...
(re: #6087 )
2019-03-22 23:18:25 -04:00
Bryan Housel
f6c284a3be
Minor code cleanups, swap some math for existing functions
2019-03-22 15:29:48 -04:00
J Guthrie
97dc659b0f
Fixed linting - moved function out of loop
2019-03-22 15:29:48 -04:00
J Guthrie
470d6c257d
Update to work on ways going in opposite directions
2019-03-22 15:29:48 -04:00
J Guthrie
e786bd54b1
Minor syntax improvement
2019-03-22 15:29:48 -04:00
J Guthrie
a3930c35a3
Fixed sort to sort by integer
2019-03-22 15:29:48 -04:00
J Guthrie
d07418c654
Enforce either 0 or 2 selected vertices
2019-03-22 15:29:47 -04:00
J Guthrie
04da13dae3
Added 2-vertex straighten to actionStraighten
...
- Split selectedIDs between nodes and ways
- Slice the length of nodes to be straighten to between the 2 selected nodes
2019-03-22 15:29:47 -04:00
J Guthrie
c28f0a77fe
Implement new functionality
2019-03-22 15:29:47 -04:00
Bryan Housel
c7e375cbd7
Preserve directionality of sided way when joining to non-sided ways
...
(closes #6033 )
2019-03-21 22:19:05 -04:00
Quincy Morgan
0781b70f38
Add drag-and-drop reordering of relation members ( close #2283 )
2019-03-15 12:22:24 -04:00
Quincy Morgan
93df5d42d9
Flag and upgrade deprecated tags in a semicolon-delimited tag value ( close #6038 )
2019-03-11 10:22:28 -04:00
Bryan Housel
3f8911c149
Merge pull request #5999 from openstreetmap/squarish
...
Improve orthogonalization action
2019-03-01 23:28:23 -05:00