170 Commits

Author SHA1 Message Date
J Guthrie
97dc659b0f Fixed linting - moved function out of loop 2019-03-22 15:29:48 -04:00
J Guthrie
9d452c9ffe Fix lint issue 2019-03-22 15:29:48 -04:00
J Guthrie
c3295cc174 Remove left over logging statements 2019-03-22 15:29:48 -04:00
J Guthrie
470d6c257d Update to work on ways going in opposite directions 2019-03-22 15:29:48 -04:00
J Guthrie
df4f25a02c Use lodash _includes instead of standard javascript version 2019-03-22 15:29:48 -04:00
J Guthrie
d07418c654 Enforce either 0 or 2 selected vertices 2019-03-22 15:29:47 -04:00
J Guthrie
24f83ba1ae Attempt to fix travis fail 2019-03-22 15:29:47 -04:00
J Guthrie
16513b1194 Update operationStraighten.available() function
- operationStraighten now allows for two vertices to be selected and straightened between
 - Added test cases
2019-03-22 15:29:47 -04:00
J Guthrie
c28f0a77fe Implement new functionality 2019-03-22 15:29:47 -04:00
Bryan Housel
3f8911c149 Merge pull request #5999 from openstreetmap/squarish
Improve orthogonalization action
2019-03-01 23:28:23 -05:00
Bryan Housel
fab6bd1d33 Support orthogonalizing a single vertex, add tests
(closes #2205)
2019-03-01 23:20:50 -05:00
Bryan Housel
bf02ead5cc Allow orthogonalize to work on unclosed lines
(re: 5093, but see comment
https://github.com/openstreetmap/iD/pull/5999#issuecomment-468535581)
2019-02-28 23:12:04 -05:00
Brian Hatchl
1faa6ad839 Favorite preset 2019-02-20 15:23:58 -05:00
Quincy Morgan
708c5e8155 Fix crash when undoing an added line past the first node 2019-02-19 12:10:05 -05:00
Quincy Morgan
1066f8f788 Fix issue where preset browser would show after continuing a line (close #5770) 2019-01-28 08:52:20 -05:00
Bryan Housel
119792fd22 Cleanups to Detach Node feature
This commit includes a bunch of minor things:
- change keyboard shortcut to 'E' to not conflict with anything
- move `disabled` check from operation into action and simplify
- use `actionMoveNode` to place the detached node at the mouse cursor
- disable the operation if the node is connected to hidden features
- lots of code simplification
- make the icon more centered
2018-07-23 13:36:34 -04:00
Jon D
90bc0b8537 Update to prevent detachment of node when either a via or
location_hint role in a turn restriction.
Update to move any other relation to new node.
2018-07-22 19:35:29 +01:00
Jon D
3bad09d497 Merge Work-In-Progress 4320 to 4320 2018-07-06 22:20:19 +01:00
Bryan Housel
9f623836cd Handle tooltip disabled reasons 2018-04-25 23:32:57 -04:00
Bryan Housel
2909162158 Rename merge_way_nodes to merge_nodes, update tests 2018-04-25 20:57:40 -04:00
Bryan Housel
9bf4799b56 Merge branch 'merge-way-nodes-feature' of https://github.com/ferdibiflator/iD into ferdibiflator-merge-way-nodes-feature 2018-04-25 16:19:32 -04:00
Bryan Housel
9b200cf514 Code cleanups, changes to replaceMovedVertex in moveAction
Trying to eliminate the minimum 10m distance for replacing the original
junction vertex - this is a small threshold.  When _not_ replacing this
vertex, the unzorro code will wreck havok on a traffic circle.
(If there is no suitable vertex to use, it will snap to a point between
the nearest vertices, see #4146)
2018-01-28 23:56:03 -05:00
Nikita Mashukov
92451e7b4b Merge branch 'master' into merge-way-nodes-feature 2018-01-01 22:09:54 +07:00
Bryan Housel
710a075a90 When deleting final nodes from a way, pan to final node's location
(closes #4541)
2017-11-20 16:16:33 -05:00
Nikita Mashukov
da0b42e727 merge way nodes action is added 2017-10-28 21:05:50 +07:00
Bryan Housel
3def4db09f Convert lodah-es and d3 to named imports for operations 2017-09-25 13:58:53 -04:00
Bryan Housel
5ffa8f535e Relax the availability rules for rotation and reflection operations
(closes #4237)

New rules:
- Rotation available if at least 2 unique nodes in selectedIDs
- Reflection available if at least 3 unique nodes in selectedIDs
2017-08-17 14:32:32 -04:00
Bryan Housel
9882cf1d7b Don't rm old preset tags post merge, but do rm area=yes when setting preset
(closes #4114)
2017-06-22 17:49:45 -04:00
Bryan Housel
894bd615c9 Preserve the undo annotation when doing point-area merge
(closes #4113)
2017-06-21 18:56:45 -04:00
Bryan Housel
6f4d490c6f Prevent delete of objects when not 80% visible
(closes #3700)
2017-03-10 22:45:42 -05:00
Bryan Housel
775b4eaafa After merge, rematch preset and update tags if necessary
(closes #3851)
2017-03-02 11:03:45 -05:00
Bryan Housel
e756520bd8 suppressMenu(true) is now the default 2017-02-21 15:47:22 -05:00
Bryan Housel
2ce78d6c43 Call annotation as a function instead of a property
This is because, like tooltip(), it doesn't always make sense to call it,
and it should never get called if the operation is not available.
2017-02-15 23:02:13 -05:00
Bryan Housel
028ef3de3f Expose annotations for each operation 2017-02-15 22:01:30 -05:00
Bryan Housel
33227c2b53 Adjust text for Reflect operation messages 2017-02-15 16:37:37 -05:00
Bryan Housel
cb35873e29 Don't allow continue from the connecting vertex of a closed way
Now that addNode tries to preserve circularity, this
could cause the continued segment to loop back.

And anyway it's confusing why one vertex allows it and none others do.
2017-01-12 20:08:42 +05:30
Bryan Housel
c2713c3a3f For node-way merge, preserve original node if possible
(closes #3683)
2016-12-31 02:01:13 -05:00
Bryan Housel
9a922c0731 Make Reflect/Rotate unavailable for strictly linear features 2016-12-22 15:18:01 -05:00
Bryan Housel
37534aed0e More cleanup of operations and post-paste behavior
* Support move, rotate, reflect, delete post paste on multiselection
* Improve text and error msgs for singular vs multi selections
* Move `disabled` checks from actions to operations
* Reproject center of rotation (closes #3667)
* Cleanup tests
2016-12-21 23:58:13 -05:00
Bryan Housel
38e4900355 Allow rotate of multiple selected objects
(closes #1719)
2016-12-21 16:44:40 -05:00
Bryan Housel
57696ab5eb Rename rotate-way mode to just rotate 2016-12-20 13:44:39 -05:00
Bryan Housel
087a8c62d1 Behaviors for all Operations 2016-12-20 00:28:24 -05:00
Bryan Housel
35aae816b0 Expose Reflect operation behavior 2016-12-19 16:55:49 -05:00
Bryan Housel
2267035dfb Support both reflect long axis and reflect short axis operations 2016-12-16 13:59:33 -05:00
Bryan Housel
dca1c8fb41 Add reflect icons 2016-12-16 11:24:29 -05:00
Bryan Housel
e88f53ac07 Reflect around long axis by default, provide method to choose long/short 2016-12-15 18:13:28 -05:00
Bryan Housel
72c51bc283 Add getSmallestSurroundingRectangle 2016-12-14 17:21:32 -05:00
Bryan Housel
5a6045fd3d Merge branch 'master' into Psigio-3375 2016-12-14 11:30:53 -05:00
Bryan Housel
dc5da7b480 Follow next vertex when deleting, add suppressMenu when vertex following 2016-12-09 12:11:24 -05:00
Bryan Housel
3abf1b5be8 Allow reselection of next vertex even if vertex has multiple parents 2016-12-09 11:57:26 -05:00