Kyle Hensel
50309005a1
fix erroneous mismatched_geometry warning for preset-less tags
2024-11-23 04:48:28 +14:00
Kyle Hensel
c3c0e23ba8
fix unsolvable validator error for presets with locationSet
2024-09-09 20:57:26 +10:00
Kyle Hensel
90c4241723
fix dependency cycle caused by utilDisplayLabel importing presetManager
2024-08-24 11:34:46 +10:00
Martin Raifer
bb5e9e063d
don't trigger line-is-area warning for tags implemented as 2 geometry-dedicated presets
...
e.g. `highway=elevator` in the "Elevator" and "Inclined Lift" presets
2023-07-15 19:44:32 +02:00
Martin Raifer
5f1360ed0f
don't suggest to "connect the ends" if a feature with area tags matches a line preset
...
For example, when a feature tagged as `highway=primary` (line preset) and `man_made=bridge` (area preset) is mapped as an unclosed way, converting it to an area (by closing the way by connecting the endpoints) does not improve the situation, as then the other tag doesn't fit to the geometry anymore.
closes #7037
2022-11-04 12:23:15 +01:00
Martin Raifer
8bb1d39431
refactor validation modules to not inject html
2022-06-24 13:25:56 +02:00
Martin Raifer
9f3f8e1366
rename method
2021-11-29 19:26:18 +01:00
Martin Raifer
d78c357588
replace raw html injection of localized texts
...
by using d3 to insert the localized text spans directly into the DOM
2021-11-26 18:51:45 +01:00
Milos Brzakovic (E-Search)
599d2df19b
matchTags - don't calculcate valid locations unless needed
...
mismatched_geometry - small optimization
2021-10-20 09:49:00 +02:00
Bryan Housel
9f30ebf551
Adjust verbose utilDisplayLabel call, use for more validation messages
...
(re: https://github.com/osmlab/name-suggestion-index/issues/4543#issuecomment-794527259 )
2021-03-10 10:30:57 -05:00
Quincy Morgan
0a0e2dcf75
Fix issue where extracting points could results in off placements ( close #8246 )
2020-12-11 12:50:32 -05:00
Quincy Morgan
32dcfcc08e
Fix spelling
2020-12-07 10:55:43 -05:00
Quincy Morgan
2dd6bce851
Add quick fix to convert areas to lines for mismatched geometry validation
2020-12-07 09:47:18 -05:00
Quincy Morgan
c43fac8d64
Ignore nodes on address lines for the mismatched geometry validation
2020-12-07 09:46:37 -05:00
Quincy Morgan
a7b3985237
Flag points as areas or lines, areas or lines as points, and lines as areas ( close #8231 )
2020-12-04 16:22:36 -05:00
Quincy Morgan
9effdf9724
Display the expected preset name for the mismatched geometry issue messages ( close #8018 )
2020-09-24 08:58:45 -04:00
Quincy Morgan
7b5df1bc40
Add lang attribute to issue fix labels (re: #7963 )
2020-09-22 17:48:35 -04:00
Quincy Morgan
aa9b44a0bf
Add the lang attribute to issue messages (re: #7963 )
2020-09-22 17:25:18 -04:00
Quincy Morgan
5435082d9c
Revert t function to returning the plain string by default
...
Add `t.html` function for getting the string with the `lang` attribute
2020-09-22 12:03:29 -04:00
Quincy Morgan
a3549f9a76
Merge branch 'develop' into lang-attributes
...
# Conflicts:
# modules/ui/commit_warnings.js
# modules/ui/field.js
# modules/ui/fields/wikidata.js
# modules/ui/fields/wikipedia.js
# modules/ui/full_screen.js
# modules/ui/panels/history.js
# modules/ui/sections/entity_issues.js
# modules/ui/sections/map_features.js
# modules/ui/sections/raw_member_editor.js
# modules/ui/sections/validation_rules.js
# modules/ui/tag_reference.js
2020-09-22 10:55:07 -04:00
Quincy Morgan
b1a2e11a6b
Fix extract fix annotation
2020-09-22 09:42:03 -04:00
Quincy Morgan
32f8274929
Make t function return a span element with a lang attribute unless html: false is specified in the options (re: #7963 )
...
Update `text` functions to `html` to support inserting the `span` elements
Specify `html: false` for various instances where a `span` is not desired, e.g. `placeholder` and `title` attributes
2020-09-15 21:56:22 -04:00
Quincy Morgan
6128c6514f
Enable the Extract operation for multiple selected extractable features ( close #7600 )
...
Allow extracting vertices that are `via` or `location_hint` relation members
2020-06-04 16:35:25 -04:00
Quincy Morgan
04bdc4da1c
Make the extract operation a single step instead of immediately entering modeMove ( close #6674 )
2020-05-13 10:58:53 -04:00
Quincy Morgan
0120b009fa
Take a graph parameter in utilDisplayLabel instead of the context
2020-04-01 13:29:17 -07:00
Quincy Morgan
60f7dc7c0b
Replace presets property of context with singleton
...
Remove utilPreset
2020-04-01 13:08:45 -07:00
Quincy Morgan
a1af118f0e
Ensure locales and presets are loaded before the UI loads ( close #7406 )
...
Consolidate localization behavior and init to a coreLocalizer function and singleton
Explicitly support `en-US` locale
Rename coreData to coreFileFetcher and export a singleton rather than using a property of coreContext
Add `apiConnections` property of coreContext to simplify adding a source switcher
Replace some init functions with re-callable, promise-supporting `ensureLoaded` functions
Make coreContext itself load the UI if a container has been specified at init time
Fix code tests
2020-03-31 12:23:31 -07:00
Bryan Housel
0fe766d9a4
WIP on external presets
...
- preset data is no longer bundled into iD.js
- some code pathways commented out re: external presets
- many changes so that tests can run without presets at start, or async
- still need to make sure fallbacks are always there (point, line, area, etc)
2020-02-05 09:38:26 -05:00
Quincy Morgan
9f8e88a2ff
Don't cache point-as-vertex extraction fix
2019-11-25 10:49:16 -05:00
Quincy Morgan
59f0c04e13
Don't flag unclosed parts of multipolygons with undownloaded members (re: #2223 )
2019-11-22 15:00:43 -05:00
Quincy Morgan
45ac186a68
Flag unclosed multipolygon parts ( close #2223 )
2019-11-22 14:55:51 -05:00
Quincy Morgan
24c72b64d1
Load issue fixes dynamically instead of cacheing them ( close #7037 )
2019-11-13 14:35:01 -05:00
Quincy Morgan
6a515576f1
Add an "Extract this point" quick fix for points-as-vertices validation warnings (re: #6319 )
2019-10-01 18:21:03 +02:00
Quincy Morgan
525916da74
Recategorize tags_suggests_area validation rule into mismatched_geometry rule
...
Warn about points tagged as vertices and vertices tagged as points (close #6319 )
2019-09-26 10:56:30 +02:00
