5051 Commits

Author SHA1 Message Date
Max Grossman e3407d4168 do not use mouseover, use mousedown!
ref #5596
2018-12-20 09:05:23 -05:00
Max Grossman 2dab19e9ae default to value() if neither d and choice are null in the accept function
ref #5618
2018-12-20 08:52:16 -05:00
Max Grossman 5a1dfeec72 open combobox if anywhere on box clicked...
ref #5596
2018-12-20 08:47:37 -05:00
Xiaoming Gao a4e1012c91 add crossing_way validation
Tests are also added and passed.

One thing to note: I had to add the tree() function to history so that I can
use the tree in the test; hope that's fine.
2018-12-19 19:23:35 -05:00
Quincy Morgan 2207a6c3a4 Added severity tooltip to issue icon 2018-12-19 18:35:17 -05:00
Quincy Morgan ac539dddaa Merge branch 'master' into validation 2018-12-19 18:13:44 -05:00
Quincy Morgan cfbb86f88c Change the initial view of the sidebar on selection 2018-12-19 17:44:41 -05:00
Andrew Wong 6e749c70ef listening to user generated history changes for validation 2018-12-19 17:28:34 -05:00
Bryan Housel 2deadd5d6c Fix merge issues 2018-12-19 17:12:06 -05:00
Quincy Morgan 490143d1a8 Added Issues section to the entity sidebar
Fixed bug where stale issues would stick around in the issues pane
2018-12-19 16:12:33 -05:00
Thomas Hervey f4e71812ca added: help documentation 2018-12-19 13:45:35 -05:00
Thomas Hervey cedf6955b5 added: notes and todos for keepRight 2018-12-19 13:45:34 -05:00
Thomas Hervey ee00635cc4 updated: some error colors; fixed: error 320, 220 2018-12-19 13:45:15 -05:00
SilentSpike 1f7455fdad Add missing error types 73, 74 and 75 2018-12-19 13:45:15 -05:00
SilentSpike 9bd772748a Convert warnings to regex
These aren't shown in the layer currently, but for future use this
should work
2018-12-19 13:45:15 -05:00
SilentSpike da23bf79a8 Fix parsing of error type 294 2018-12-19 13:45:15 -05:00
SilentSpike 005927dae3 Fix parsing of error type 211 2018-12-19 13:45:15 -05:00
SilentSpike 2b1e37ab78 Handle simple error descriptions explicitly
This adds a flag to the error schema to explicitly say whether to parse
the description with regex or not. Prevents us from having to escape
special characters in fixed strings and is a minor optimisation.
2018-12-19 13:45:15 -05:00
SilentSpike e77d779173 Adhere to style guide for variables 2018-12-19 13:45:15 -05:00
SilentSpike e0e48b7505 Fix parsing of error type 231 2018-12-19 13:45:15 -05:00
SilentSpike a2fe431637 Add support for arbitrary number of details 2018-12-19 13:45:15 -05:00
SilentSpike d054e9cf6b Convert all error message schema to regex 2018-12-19 13:45:15 -05:00
SilentSpike 1527bbb043 Fix missing and unnecessary semicolons 2018-12-19 13:45:15 -05:00
SilentSpike 424bebf099 Convert preliminary amount of errors to regex
This focuses on converting error types I found on the map for testing
(can confirm the code is working!) as well as the more problematic cases
from the old code to show that this approach can handle them easily.
2018-12-19 13:45:15 -05:00
SilentSpike bb89827ee7 Use regex group capture to extract error details 2018-12-19 13:45:15 -05:00
Thomas Hervey fbe3c94b01 updated: punctuation, some specialized QA error parsing 2018-12-19 13:45:14 -05:00
Thomas Hervey 84895834f7 updated: punctuation and missing descriptions 2018-12-19 13:45:14 -05:00
Thomas Hervey d125c62c78 updated: variable and function names, html regex 2018-12-19 13:43:48 -05:00
Thomas Hervey ed34d522ff updated: check entity type from second word as well 2018-12-19 13:43:48 -05:00
Thomas Hervey e0d5391f1b added: entity links within descriptions 2018-12-19 13:43:48 -05:00
Thomas Hervey d095de08fe updated comment UI, added stub for POST; TODO: finish links & POST 2018-12-19 13:43:48 -05:00
Thomas Hervey b5a316df48 fixed: svg icon placement 2018-12-19 13:43:08 -05:00
Thomas Hervey 1335549ad3 cleaned map data UI; commented sub-layer filtering 2018-12-19 13:43:08 -05:00
Thomas Hervey 805dd394c9 added link for object in header 2018-12-19 13:40:56 -05:00
Thomas Hervey cbcdfc075c small UI change to header 2018-12-19 13:40:56 -05:00
Thomas Hervey 6dbea57721 added back supported 2018-12-19 13:40:56 -05:00
Thomas Hervey 3e7146c63f WIP: menu with sub-layer buttons; TODO: bug fixes, ui updates, wiring buttons 2018-12-19 13:40:56 -05:00
Thomas Hervey 18278371aa WIP: identifying variables in errors 2018-12-19 13:38:40 -05:00
Thomas Hervey 31f35b0389 added basics to sidebar 2018-12-19 13:35:26 -05:00
Andrew Wong 6ae25eada7 fixing tests around issues 2018-12-19 13:34:16 -05:00
Quincy Morgan 14f62ec3b9 Merge branch 'master' into validation 2018-12-19 13:23:54 -05:00
Quincy Morgan 59b0252b0e Fixed several linting errors 2018-12-19 13:22:48 -05:00
Thomas Hervey 75cff00a2a displaying keep right (currently as notes) 2018-12-19 13:18:37 -05:00
Thomas Hervey b96965568f WIP: added schemas for errors and warnings 2018-12-19 13:13:30 -05:00
Thomas Hervey b3cffd7833 added simple keepRight button under photoItems 2018-12-19 13:12:49 -05:00
Quincy Morgan fb182dca37 Removed unneeded code in the issues pane 2018-12-19 13:10:03 -05:00
Quincy Morgan 6a931f9be6 Added colors to issue list icons
Corrected icon for warnings
Made disconnected_highway issue a warning instead of an error
2018-12-19 13:07:47 -05:00
Quincy Morgan a95af00b1d Added icons to issues list 2018-12-19 12:40:42 -05:00
Bryan Housel 81b5fc788e Merge pull request #5629 from openstreetmap/5587
5587 - make geolocation show geolocation
2018-12-19 12:14:36 -05:00
Quincy Morgan c4fb38603e Merge branch 'master' into validation 2018-12-19 12:14:32 -05:00