5051 Commits

Author SHA1 Message Date
Martin Raifer
e07dcddfee only render addr point markers when there are addr tags
closes #11092

and also skip rendering of "placement ellipse" for address points
2025-06-05 14:36:07 +02:00
Martin Raifer
42ea10d30a properly update number fields with non-numeric values
fixes a bug where the field was not properly filled in when the tag contained a non-numeric value (e.g. `direction=S`), which could eventually cause the tag be deleted inadvertently after focussing/blurring the field.

closes #11076

this regressed in 2b64d70352
2025-06-03 21:11:41 +02:00
Martin Raifer
bd71ccba17 fix false positive "unreachable oneway" validation cased by oneway=-1
fixes #11068
2025-05-27 14:44:51 +02:00
Martin Raifer
2dc64f0fef cache panoramax sequence data (prev/next links)
to allow more snappy scrolling through the photos of a sequence using the prev/next buttons
the cache is primed with information for "most of" the selected sequence, see also https://gitlab.com/panoramax/server/api/-/issues/268
2025-05-21 16:56:57 +02:00
Martin Raifer
3c9d232d41 make sure pannellum viewer is ready to load new photo, fixes #11054
while loading a "scene", pannellum cannot load a new panorama scene. This means we have to wait while the viewer is busy loading an existing panorama until we can load a new one.
2025-05-21 16:38:31 +02:00
Martin Raifer
5fb540b551 cache userid to username data for panoramax service 2025-05-21 14:18:14 +02:00
Keiffer
9b46ed167d hide Mapilio photo markers on low zoom (#11014) 2025-05-19 11:40:45 +02:00
Martin Raifer
7b702bed16 drop unused import 2025-05-15 17:03:48 +02:00
Martin Raifer
e25af7c05e enable keybindings for unavailable operations -> show info message
this should make it easier to discover what a given keypress was supposed to do (e.g. which operation it triggered)

closes #9896
2025-05-15 17:03:31 +02:00
Martin Raifer
c11b661ef3 fix oneway field showing "Assumed to be Yes" if cycled through
…back to the default state. This was a slight regression from the refactoring in #10730: In an intermeditate step, the entity has `oneway=yes`, which should actually be ignored when determining if an entity has an implicit oneway state.
2025-05-15 11:26:40 +02:00
Martin Raifer
ac59197632 simplify raw tag editor ui and logic (#10889)
* always show empty line at bottom of the tag list to allow adding more tags (replaces `+` button and tab logic)
* disable delete and info buttons on empty tag
* replace deferring of tag change events and re-rendering with a simpler logic (to fix issues like #10871):
  only set input field values if the rendering event was triggered by an external event, or by a change of the respective field in the raw tag editor itself
* skip delete and tag info buttons while navigating using tab: makes it more quick to get to where one typically needs to, deleting a key using the keyboard only is possible by emptying the tag's key, and advanced users are not typically using the `i` button anyway
2025-05-12 18:21:55 +02:00
Martin Raifer
7f8e676af3 refresh numeric fields on blur (#11027) 2025-05-12 18:09:39 +02:00
Martin Raifer
9b7a98862d Merge remote-tracking branch 'origin/housenumber-labels' into develop 2025-05-12 18:02:47 +02:00
Martin Raifer
5c721808c6 change variables for better readability, closes #11022 2025-05-06 11:25:32 +02:00
Martin Raifer
39d2201e6e fix hover-highlight of changed features in upload dialog
fixes #10030
2025-05-06 11:17:53 +02:00
McLaynV
61670beb1d remove empty line from drag_note.js (#11015) 2025-05-06 09:19:00 +02:00
Martin Raifer
6bfcc17e2d simplify/streamline rendering of set photo id button
using d3 patterns instead of complicated manual add/remove
2025-04-29 17:21:51 +02:00
Martin Raifer
d5118b0fd6 make sure photos is properly highlighted when switching providers
previously, when the photo was already loaded in the mapillary viewer, then another photo from a different provider was displayed and the previous mapillary photo selected again, the "highlighted photo" marker was not drawn correctly, and the "set mapillary id from photo" button not properly updated
2025-04-29 17:19:55 +02:00
Martin Raifer
b78a1ac27e clean up onclick logic 2025-04-29 16:53:19 +02:00
Martin Raifer
4a9c0b4be9 properly clean up / remove "set photo id" button for unsupported providers
closes #10992
2025-04-29 16:48:37 +02:00
Martin Raifer
68c3babb9a remove old workaround of a Chrome/V8 bug
see
* https://github.com/openstreetmap/iD/issues/3973#issuecomment-309637397
* https://bugs.chromium.org/p/chromium/issues/detail?id=731193&can=1&q=prototype%20inheritance&colspec=ID%20Pri%20M%20Stars%20ReleaseBlock%20Component%20Status%20Owner%20Summary%20OS%20Modified
2025-04-29 15:04:23 +02:00
Martin Raifer
96746c2f7d fix crash when feature is deleted while map-panning and photoviewer is open
closes #10994
2025-04-29 15:03:14 +02:00
Martin Raifer
6798f33598 link label of address field to housenumber input element
this makes the most sense, as it should be almost always present in the address field and be the most "unique/important" value to edit for an address

closes #11004
2025-04-29 14:40:35 +02:00
Martin Raifer
7385654df1 change walkthrough imagery to Bing
the old esri layer does not seem to be available anymore
2025-04-29 14:26:00 +02:00
Martin Raifer
d4e56259fb render points over vertices, fixes #11006 2025-04-29 14:13:25 +02:00
Martin Raifer
ab7df6e040 disable keyboard controls for pannellum viewer, fixes #11001
this makes it similar to how the non 360° viewer and mapillary's 360° viewer work, allowing regular iD keyboard shortcuts to be used even when the focus is on the photo viewer
2025-04-29 13:52:59 +02:00
Martin Raifer
ef1068c257 more robuse detection of active photo service
fixes a glitch where sometimes the _pick photo id_ button would be overlapping the zoom buttons on panoramax
2025-04-29 13:43:50 +02:00
Martin Raifer
0e6ca91727 fix initial loading of pannellum viewer for vegbilder photos 2025-04-29 12:54:59 +02:00
Martin Raifer
81d94a138b fix mapillary's panorama viewer from loading properly
this was a regression from the previous commit (19957d0e3)

also, harmonize code slightly between different services
2025-04-29 11:50:37 +02:00
Martin Raifer
19957d0e39 keep photo viewer state on reset, properly clean up active marker
when switching between photos from different providers

fixes #10987
2025-04-29 09:38:18 +02:00
Martin Raifer
4dc4e7dbdc fix split operation from creating 1-node ways when 2+ nodes selected
fixes #10997

Also change the split operation to only split the ways which contain all selected nodes (when thare are more than one node selected). This is more likely what the person performing the splitting intends to do
2025-04-28 12:20:04 +02:00
Martin Raifer
19adc5cd54 consistently round non-integer initial zoom when zooming in/out
…when using the zoom buttons or +/- keyboard shortcuts (i.e. does not affect the mouse-wheel/pinch zooming)

Also: make zoom in/out transition slightly faster.

In sum, this allows to zoom in/out multiple levels in quick succession, and using the zoom buttons should be more intuive: they don't snap to very-close zoom levels anymore (e.g. hitting `+` when the current zoom was 15.97 would previously result in a final zoom of 16.00, which is not really what a user would need. Now the zooming in results in a final zoom level of 17.00, which is "actually properly zoomed in".

initial zoom | operation | final zoom (new) | final zoom (old code)
----- | --- | ----- | -----
16.00 | `+` | 17.00 | 17.00
16.00 | `-` | 15.00 | 15.00
16.10 | `+` | 17.00 | 17.00
16.10 | `-` | 15.00 | 15.00
15.90 | `+` | 17.00 | 16.00
15.90 | `-` | 15.00 | 14.00
2025-04-26 21:10:16 +02:00
Martin Raifer
fa91fe7c0d fix zoom resetting wrongly when switching background mid-transition
see https://github.com/openstreetmap/iD/issues/10700#issuecomment-2832010049
2025-04-26 21:10:16 +02:00
Martin Raifer
009daf7ef6 fix crash on low zoom address rendering 2025-04-26 19:44:49 +02:00
Martin Raifer
b05be80e53 only show outdated tags warning if there are tags to upgrade, fixes #10980 2025-04-23 12:36:57 +02:00
Martin Raifer
2fccd798dc fix size of touch targets for address shields 2025-04-23 12:29:35 +02:00
Martin Raifer
1a5bc72327 be a bit more lenient when determining if a node is an address node
consider some additional tags as "not interesting"/non-POI-like:
* check_date/fixme/note/note:*/survey:* — mapping related tags
* layer/level/level:ref — can be considered attributes of the address
* ref:* – often used to indicate a source ID on imported data
2025-04-23 12:02:05 +02:00
Martin Raifer
112c9264b2 fix crash when collision boxes are drawn in debug mode 2025-04-23 11:56:56 +02:00
Martin Raifer
bcdf6b9e71 add some additional tag keys to list of not-interesting tags 2025-04-23 11:55:13 +02:00
Martin Raifer
e2cb7663b0 fix move mode
as the current graph has now the most recent version of the modified entities, each individual change only needs to take into account the delta of the mouse movement between the current position and the previous one (instead of the original mouse position when the operation was started)
2025-04-21 15:56:26 +02:00
Martin Raifer
5afe43c700 show ellipsis for long housenumbers/housenames 2025-04-21 15:29:56 +02:00
Martin Raifer
aa96a67c65 use lodash-es everywhere, replace custom clamp methods with lodash 2025-04-21 14:43:35 +02:00
Martin Raifer
4254e67ca7 render addresses (housenumber/housename)
* points with a dedicated marker
* text inside of areas
2025-04-17 17:47:08 +02:00
Chaitanya Kadu
552c6b6148 preserve step_count/… while joining ways (#10926)
* preserve the sum of certain tags (`step_count`, `parking:*:capacity`) during _join_ operation
* preserve total value of `parking:*:capacity` tags during _split_ operation by distributing it proportionally to the resulting ways
* the abstract osm entity now accepts a list of tags to override during the merging, but otherwise is agnostic about how tags can be merged: the concrete merging resolution might depend on the concrete action that was performed
2025-04-17 14:13:53 +02:00
Martin Raifer
666583d516 add hover text for relation labels in membership editor (#10942)
* append relation id as hovertext in membership editor as last-resort disambiguation in case multiple relations have otherwise the exact same label (and type)
* show regular relation label also as hover text, which is useful to see the full name in case it is cut off with an ellipisis (…) for long-ish labels
2025-04-17 12:52:32 +02:00
Martin Raifer
afce723b74 only consider proper lifecycle tagging in "past/futures" layer (#10943)
fixes #10186, where features with e.g. `intermittent=yes` were incorrectly sorted into the past/futures layer

now only features with correct tagging are included in the "past/futures" layer:
* either the "legacy" lifecycle tagging (e.g. `highway=construction`)
* or proper lifecycle prefix tags (e.g. `disused:shop=convenience`)
2025-04-17 12:47:10 +02:00
Martin Raifer
95143219a2 suggest housenumber/housename values from surrounding features (#10949)
housenumber/housename are taken from surrounding areas, as well as address points that are inside (or on the perimeter of) the same building as the selected feature
2025-04-17 12:40:30 +02:00
Martin Raifer
f5eb4d2a51 don't de-select map feature when clicking on a street level photo 2025-04-15 18:14:59 +02:00
Martin Raifer
654c13ce08 keep photo viewer open when disabling Panoramax overlay, fixes #10966 2025-04-15 17:05:09 +02:00
Martin Raifer
10030bb4ae display explicit "context" tags of deprecation rules, closes #10104 2025-04-15 11:52:45 +02:00