5051 Commits

Author SHA1 Message Date
Martin Raifer
6a88fe3d40 fix removed tooltops from re-appearing on keyboard focus, closes #9873 2025-04-13 18:40:52 +02:00
Martin Raifer
03a5aa5058 sync dropdown keys with address tags from id-tagging-schema 2025-04-09 21:46:28 +02:00
Martin Raifer
ade83ba6e0 extend kartaview's domain hotpatching, use full resolution images, fixes #10927 2025-04-04 13:57:20 +02:00
Kyℓe Hensel
fd49a10f1c consider language scripts when determining the locale to use (#10910) 2025-03-24 14:27:18 +01:00
Martin Raifer
e4d34c2203 improve sorting search results categories:
1. direct OSM id results (e.g. `node/123`)
2. local osm data matches
3. lat/lon coordinate
4. geocoded results
5. other results (currently: only guessed OSM ids if the search looks like a number)
2025-03-21 17:58:23 +01:00
Martin Raifer
c6ad3e9a33 drop unneeded duplicate test; lint code 2025-03-21 17:58:22 +01:00
dragoon
a9832c88c3 CTRL+SHIFT+I should not trigger CTRL+I (#10818) 2025-03-20 15:07:18 +01:00
Martin Raifer
8e8c5a8621 Render oneway markers inline in dashed lines (#10849) 2025-03-20 14:01:26 +01:00
Martin Raifer
7d933f3875 add default implied access values for ways with "motorroad=yes"
see https://wiki.openstreetmap.org/wiki/OSM_tags_for_routing/Access_restrictions
addresses https://github.com/openstreetmap/id-tagging-schema/issues/609
2025-03-20 13:54:51 +01:00
Martin Raifer
771ad4dbd9 fix calculation of access field placeholder on multiselections 2025-03-20 13:54:47 +01:00
MOHAMED ALI FAWZI
9590c88646 Panoramax: Adopt "copy id" feature from mapillary (#10856) 2025-03-19 20:13:46 +01:00
Mattia Pezzotti
d1e5c2910c add date slider for street level photos, and more (#10394)
full list of enhancements:

* year slider to filter photos by freshness
* toggle active streetlevel layers with shortcut `shift+P`
* hfov, pitch and direction is now held between sequences and images as asked in #10392
* fix for #10361 (only panoramax)
* added tests and jsdoc
* add ticks for existing photos on slider
* general bug fixes
* rudimentary support for toDate in date slider (only when iD is started with a "to" date in the hash parameter: show a second slider to visualize and set the "to" date)

---------

Co-authored-by: Martin Raifer <martin@raifer.tech>
2025-03-18 21:09:37 +01:00
Martin Raifer
6bae24fa94 hotpath URL for kartaview photos ¯_(ツ)_/¯ 2025-03-18 20:47:00 +01:00
Martin Raifer
f4230785e1 fix squaring operation on vertices, closes #10401
* only calculate `motion` for the selected vertex
* don't treat vertex as "closed way" when checking disabled/enabled state of operation
2025-03-18 12:00:35 +01:00
Martin Raifer
79362ea7a8 filter empty strings from preset aliases 2025-03-17 14:01:11 +01:00
Martin Raifer
6ec6917dbc add ignore-list for presets which should not be checked for suspicious names
closes #10884
2025-03-17 13:51:20 +01:00
Martin Raifer
58cb5a0b80 also check preset aliases in suspicious names validation
see #9522
2025-03-17 13:31:26 +01:00
Martin Raifer
74dc459a4a drop unused import 2025-03-17 12:12:26 +01:00
Martin Raifer
b2e4d81767 fix infoboxes for NSI presets, fixes #10885
(which had regressed in c1ca888)
2025-03-17 12:11:51 +01:00
Martin Raifer
8b1c37bdaf take location into account for default values from regional fields 2025-03-17 11:33:42 +01:00
Martin Raifer
78f94632d7 don't inherit fields for tags that the preset already has a field for
this is useful if a preset wants to inherit some fields from another preset, but wants to replace some of the fields with special versions of the field (e.g. a `…_yes` field for an added default value), or to change the `fields`/`moreFields` classification of a field
2025-03-17 11:33:42 +01:00
dragoon
e6c379053e fix coordinate search with / symbol (#10879) 2025-03-14 19:31:04 +01:00
Atul Patil
c7cc7008b8 Feature: add prev/next button to viewer for georeferenced photos (#10865) 2025-03-11 21:20:38 +01:00
Martin Raifer
607f953465 add alternative formats for coordinate search: (#10805)
* zoom/x/y – copy/paste from an osm.org URL or web map with map-hash param (this also sets map zoom to the respective value)
* x/y – like the above, but does not set zoom level
* x y – where x and y are numbers in the user's locale's number format
2025-03-11 21:20:21 +01:00
Martin Raifer
49e895e2ed log failed API requests in console
to more easily debug API issues in the future
2025-03-11 15:49:56 +01:00
Martin Raifer
91aa85a1c0 better handling of rate limited API map calls and other API errors
* retry all unsuccessful map calls after waiting 8 seconds (spinner continues to indicate loading state)
* also logged-in users can be rate limited: add dedicated error message
* don't log users out when requests return 401/403 (except on the _get own user data_ request, which would indicate that the oauth token was revoked): it's better to show the error message if a legitimate api call was actually unauthorized

closes #10299
2025-03-11 15:40:05 +01:00
Martin Raifer
68eb90f665 allow setting background adjustment sliders in 1% increments
closes #10289
2025-03-11 11:29:21 +01:00
Martin Raifer
bb012d6a67 only show "privacy policy updated" if user had already seen one before
see #10290
2025-03-11 11:23:59 +01:00
Martin Raifer
4282acab09 don't repeat addTags suggestion if key is also in NSI suggestion 2025-03-10 11:52:20 +01:00
Martin Raifer
28d1a4c66d osm entities always have an id property 2025-03-10 11:17:56 +01:00
Kyℓe Hensel
9d16588f19 move deprecatedTags logic out of osmEntity and into a helper function (#10842) 2025-03-07 18:29:25 +01:00
Kyℓe Hensel
16f1187c04 fix some direction cones not appearing on railway tracks (#10843)
also refactored the logic for readability
2025-03-07 18:22:51 +01:00
Chaitanya Kadu
3fa84a2abc deduplicate postcode suggestions (#10847) 2025-03-07 13:04:21 +01:00
Martin Raifer
89af80057b link to release notes on github release, closes #10837 2025-03-06 15:20:45 +01:00
Kyℓe Hensel
a41e8c48d2 separate tag-upgrade warnings from NSI suggestions (#10801) 2025-03-05 12:42:40 +01:00
Kyℓe Hensel
7beace6698 add a changeset tag if a merge conflict occurred (#9636) 2025-03-05 12:38:32 +01:00
Kyℓe Hensel
38d2ccd866 isHighwayIntersection only applies to nodes, so remove from osmEntity (#10831) 2025-03-04 11:29:29 +01:00
Martin Raifer
4d78e80ea1 fix scrolling glitch in Firefox on Windows and Linux/Xorg
For some elements, Firefox reports wheel deltas measured in lines (see https://developer.mozilla.org/en-US/docs/Web/API/WheelEvent/deltaMode), which we need to convert to pixels. The previous routine hugely overestimated the conversion factor if the deltaY as slightly bigger (not sure where the exp function came from originally, it does not make much sense IMO).
The lines-to-pixels factor does not seem to be quite consistent between different Firefox builds, but this compromise factor should be good enough, I hope.

PS: Firefox on Mac OS does not report deltas as lines anymore it seems.

closes #10825
2025-03-03 21:06:24 +01:00
Marwin Hochfelsner
a5b9479429 Change zoomToNote to moveToNote (#10819) 2025-02-28 09:57:13 +01:00
Martin Raifer
671e9f0069 use aqueduct as default value for tunnel tag in waterway structure field
(prerequisite for https://github.com/openstreetmap/id-tagging-schema/pull/1273)
2025-02-26 11:50:44 +01:00
Martin Raifer
813f9ef8cd hide carret when options exhausted also for comboboxes w/ static values 2025-02-25 18:30:49 +01:00
Martin Raifer
ab007dbbb8 restore highlighting of empty changeset comment field
restores behaviour from #4624/#4624, but switch to a neutral emphasis instead of the red color (which might be misinterpreted that the user already made a mistake)
2025-02-25 17:55:21 +01:00
Martin Raifer
ca7ae603c9 make sure combobox dropdown is removed when input field is removed
fixes #10319: when a relation membership role is edited, the change will trigger a redraw of the combobox (via D3 exit/enter). In this case, the `blur` event is never called, because the input element is immediately removed from the DOM. This is solved by cleaning up the dropdown when the combobox is about to be removed from the page.
2025-02-25 13:07:58 +01:00
Martin Raifer
f4d4a9e3b0 treat indoormark=* as indoor features, closes #10808
and don't classify `indoor=no` as indoor features
2025-02-24 18:21:39 +01:00
Martin Raifer
fa501696e5 fix false-positive missing translation, for street+place subfield
closes #10812
2025-02-24 15:33:43 +01:00
Martin Raifer
2b8ea8fc6a de-duplicate mapilio sequence linestrings
fixes poor performance
closes #10532
2025-02-22 10:53:36 +01:00
Kyℓe Hensel
147c785594 fix the turn restriction editor not supporting bidirectional roads (#10800) 2025-02-22 10:01:26 +01:00
Kyℓe Hensel
8659416af2 Fix duplicate values in the source field on the changeset page (#10799) 2025-02-22 09:57:18 +01:00
Martin Raifer
f2615f8a70 replace https workaround with uriScheme API param
See https://learn.microsoft.com/en-us/bingmaps/rest-services/imagery/get-imagery-metadata#template-parameters

Addendum to #10798
2025-02-22 09:51:16 +01:00
Kyℓe Hensel
fb1bce5a8a Always use HTTPS to load Bing Streetside images (#10798) 2025-02-22 09:42:04 +01:00