1560 Commits

Author SHA1 Message Date
Wouter van der Plas 83ff3c4f5e first setup 2021-10-23 17:50:18 +02:00
Milos Brzakovic (E-Search) b577d9dcde disabled addNote test 2021-10-21 15:00:18 +02:00
Milos Brzakovic (E-Search) 68b5445689 testing infra improvement - disable silent errors
actions/join test fixed
2021-10-21 14:44:04 +02:00
Milos Brzakovic (E-Search) b78a8d5d2a fix addNote test 2021-10-21 14:43:05 +02:00
Kyle Hensel 3f12dd5107 keep the oldest Way when merging 2021-10-01 10:31:21 +13:00
Milos Brzakovic 021107cb81 Merge pull request #8642 from openstreetmap/testing_data
Test improvements
2021-09-28 11:08:31 +02:00
John Firebaugh 1457759994 Add support for connectivity relations 2021-09-08 20:30:38 -07:00
John Firebaugh a14cf49710 Disable merge operation when it would damage relations
The operation is disabled when attempting to join ways which don't belong to identical sets of relations. Restriction relations are excluded, because they are already handled with slightly different logic.

Fixes #8674
Fixes #8645
Fixes #3825
Fixes #1512
2021-09-04 15:42:07 -07:00
Bryan Housel 08c765236f Force tests to use mouse events instead of pointer events
The pointer events use a different mechanism for counting clicks that doesn't
work when the tests are run in a real browser like Chrome. This change forces
iD to always use mouse events during testing, even in a real browser.
2021-08-18 18:58:30 -04:00
Bryan Housel b2d18d1ebe Fix hash tests in Chrome, avoid loading imagery tiles 2021-08-18 12:51:13 -04:00
Bryan Housel 003628d6b0 Try not to load imagery when running tests
By default, the `rendererBackground` code will choose an initial imagery based on what
sources are available at the given map location. It looks like this code will fallback
to "custom" _before_ "none", and I noticed that in some cases it was trying to fetch
whatever source happened to be stored in the "custom" template in localStorage.

This commit adds an explicit window.location.hash in a few places to encourage the
background layer to be "none". Some tests do change the hash, so this isn't perfect.
2021-08-16 22:51:39 -04:00
Bryan Housel 33fab5580b Before calling init() make sure the assetPath is set
init kicks off building the ui, which can fetch spritesheets for the <defs>
The assetPath needs to be set otherwise these files will not be found
2021-08-16 22:06:42 -04:00
Bryan Housel 4f1d5f0851 Similar to e7ad3845f, avoid using finally(done) as it swallows errors 2021-08-16 15:34:26 -04:00
Bryan Housel e7ad3845f9 Fix file fetcher tests that touch the intro_graph
- Before it wasn't actually loading the intro graph because assetPath not set
- The test for Three Rivers City Hall was using the wrong nodeid
- All these test errors were being ignored because of the use of .finally(done)
- To actually make an error happen, we can call `done(err)` with the Error
2021-08-16 15:23:31 -04:00
Bryan Housel 746417e1f4 Fix coreLocations tests access of locationSetID property 2021-08-16 14:11:36 -04:00
Bryan Housel 5aee120a86 Prefill the locale_tagging_en with fake string data
This avoids the numerous "missing translation" errors filling up the console
2021-08-16 14:02:25 -04:00
Milos Brzakovic 21b0fc4f36 semi 2021-08-11 19:57:40 +02:00
Milos Brzakovic ee072772c2 addNote test fix 2021-08-11 19:27:37 +02:00
Milos Brzakovic (E-Search) d2036996e3 Merge conflicts resolved 2021-07-05 10:26:44 +02:00
Nikola Pleša 7a0d8adb7b Switch to Mapillary API v4 2021-06-15 10:13:07 +02:00
Bryan Housel f95e7db8c9 Create the categories like the presets
The lack of locationSet was causing them to not show up, which indirectly
broke the tutorial at the step where user needs to pick the road category.
2021-03-12 12:04:52 -05:00
Bryan Housel a656106373 Include nsi_dissolved in test setup 2021-03-05 11:59:36 -05:00
Bryan Housel 1f6a2121c4 Move all of NSI into a service, rewrite matcher code 2021-03-03 12:04:37 -05:00
Nikola Pleša 6cd17713fa Use Mapillary vector tiles for images, sequences and map features 2021-03-01 10:19:41 +01:00
Quincy Morgan 13ddeecfa7 Fix code tests for #8276 for real this time
Add utilFetchJson to get around some quirks of d3.json and use it for coreFileFetcher
Load real general English locale strings at the beginning of code tests
2021-02-23 11:50:00 -05:00
Quincy Morgan 997b453b98 Fix code tests for #8276 2021-02-15 12:56:46 -05:00
Bryan Housel 3665f80d46 Also include operator:wikidata as a wikidata tag
osmEntity#hasWikipedia was only used by the suspicious_name validator
2021-01-29 11:11:59 -05:00
Bryan Housel 11201eb822 Rewrite the validator in ES6/Promises, several improvements here:
- implements a validation work queue, jobs are run during browser idle callbacks
- when merging base entities, don't run validations 2x on both base and head graphs (this was wasteful)
- keep track of resolved issues in a separate set (it's not a simple compare of base/head anymore)
  this happens after validation queue is empty and avoids race conditions and inaccurate resolved counts
2021-01-25 12:50:11 -05:00
Bryan Housel 74d28257c4 Fix teh misspellings 2021-01-18 19:48:35 -05:00
Bryan Housel d3fb8c60f9 Upgrade validations outdated_tags, suspicious_names to NSI v5 2021-01-13 13:46:00 -05:00
Bryan Housel 2d8c90786f coreLocation tests, documentation 2021-01-11 13:01:30 -05:00
Minh Nguyễn 6e30e61ade Label route relations with directions and waypoints 2020-12-31 16:50:47 -08:00
Quincy Morgan 0a0e2dcf75 Fix issue where extracting points could results in off placements (close #8246) 2020-12-11 12:50:32 -05:00
Quincy Morgan 1da280c79d Enable func-call-spacing eslint rule 2020-11-10 14:33:35 -05:00
Quincy Morgan 04b3a788f9 Add lint:fix script
Enable no-trailing-space eslint rule
2020-10-23 13:24:44 -04:00
Quincy Morgan 3f9ac9105b Enable no-undef-init eslint rule 2020-10-23 11:33:47 -04:00
Quincy Morgan a48c69331f Merge branch 'develop' into photo-filter-temp 2020-10-15 13:38:15 -04:00
Quincy Morgan 474b345988 Send keydown events when testing uiCombobox 2020-10-13 16:03:00 -04:00
Quincy Morgan a33ab44e81 Merge branch 'develop' into photo-filter-temp
# Conflicts:
#	css/80_app.css
#	modules/services/mapillary.js
2020-10-12 16:16:32 -04:00
Quincy Morgan e134cd7ffd Fix and simplify hover test 2020-10-08 14:58:33 -04:00
Quincy Morgan 21a49bbec8 Initial support for D3 v6.2.0 2020-10-06 15:08:39 -04:00
Quincy Morgan 80eb197212 Merge pull request #7752 from peternewman/patch-6
Fix a lot of typos and initial codespell action run
2020-10-05 14:02:19 -04:00
Quincy Morgan ad54a6e140 Support opening iD with a Streetside or OpenStreetCam photo specified as a URL parameter (close #6398)
Bring the APIs for the three street level services closer in sync
2020-10-02 13:30:36 -04:00
Quincy Morgan 4ddd4a358b Deprecate vending=parcel_mail_in;parcel_pickup -> vending=parcel_pickup;parcel_mail_in (close #7988)
Enable upgrading of entire semicolon-delimited values
2020-09-28 16:07:11 -04:00
Quincy Morgan 73a826cefc Fix code tests for bbbf401232 2020-09-24 08:30:19 -04:00
Quincy Morgan 5ddcfb0ced Add parameter to specify which way should keep the history when splitting ways (re: #7795)
Fix code tests
2020-09-14 11:27:20 -04:00
Quincy Morgan 9510578107 Merge branch 'mapillary-update' into develop
# Conflicts:
#	modules/services/mapillary.js
#	modules/svg/mapillary_map_features.js
#	modules/svg/mapillary_signs.js
2020-09-13 16:34:25 -04:00
Quincy Morgan 03ca12741f Make imageryBlocklists return regex objects instead of strings
Fix performance bug due to checking background source blocks too often
2020-09-04 10:09:47 -04:00
Quincy Morgan a72a2bb860 Hide background sources from the list if they're blocked (close #7905) 2020-09-03 12:30:59 -04:00
Peter Newman cafb8cdbd5 Revert some more complicated typo fixes 2020-08-10 17:41:39 +01:00