16273 Commits

Author SHA1 Message Date
Quincy Morgan 891de117f4 Deprecate waterway=lock 2019-04-10 16:54:40 -07:00
Quincy Morgan 33f4ec2b35 Add Canal Lock and Lock Gate presets 2019-04-10 16:52:19 -07:00
Quincy Morgan c9a579bea6 Add Beehive and Street Cabinet presets 2019-04-10 15:20:37 -07:00
Bryan Housel 0a77a494aa Merge branch 'master' into validation_and_change_perf 2019-04-10 14:22:20 -04:00
Bryan Housel 9100ce3ee4 Don't validate vertices which extend beyond the downloaded map
(closes #5938)
2019-04-10 13:40:06 -04:00
Bryan Housel f309e925d8 Memoize disabled for all the other operations too
see 81127d71f
2019-04-10 11:28:41 -04:00
Bryan Housel 81127d71f3 Cache disabled() results in straighten action for consistent response
What could happen was:
- user could right click on a line
- this would trigger `disabled()` checks for each operation buttons
- the line was not fully downloaded, so would return `disabled()` 'not_downloaded'
  (and also start download of the missing tiles)
- then the tooltip would pop into existence, calling `tooltip()`
- which calls `disabled()` again
- but this time it's fine and the `disabled()` is false
- so you'd see a greyed out button but the tooltip said everyting is ok and
  you can click the button anyway

I fixed this by just caching the disabled test.  This is probably ok anyway
because these tests can be expensive, and then the user will see a consistent
message like "The line is not yet fully downloaded".

If the user clicks off the line and back onto it, iD will reenter select mode,
rebuild the menu, redo the disabled test, and they will see the button enabled.
2019-04-10 10:19:23 -04:00
Bryan Housel e30090996b Add loadTileAtLoc to fetch data tile for a specific location
(closes #4890)

This lets iD request needed tiles outside of the viewport, for example to
properly straighten lines or validate features that may have unloaded
connections.
2019-04-09 23:49:31 -04:00
Quincy Morgan df7a2f978e Use highway tags for golf paths and cart paths (close #6165)
Offer to upgrade golf paths missing highway tags
2019-04-09 19:07:00 -07:00
Quincy Morgan 89d8f887be Allow disconnecting multiple selected vertices at once (close #6164) 2019-04-09 14:04:52 -07:00
Quincy Morgan 60ce58694c Add Screens field to Cinema preset 2019-04-09 09:53:31 -07:00
Quincy Morgan ae80c88f37 Render relation route icon lines dynamically (close #5926) 2019-04-08 19:58:50 -07:00
Bryan Housel 95a1bbaf97 Add downloaded debug flag and visualization for tiles downloaded 2019-04-08 22:06:47 -04:00
Bryan Housel df1a2ea361 Prevent some actions on features that extend beyond the loaded map
(closes #2248)
2019-04-08 21:26:58 -04:00
Quincy Morgan b01f57f9c6 Add Convention Center and Events Venue presets
Update icon for Party Store preset
2019-04-08 17:11:03 -07:00
Quincy Morgan 9c6974c8f4 Add more preset icons 2019-04-08 14:11:55 -07:00
Quincy Morgan 5445f468b8 Add more preset icons 2019-04-08 13:15:36 -07:00
Bryan Housel 2660a8554b Add isDataLoaded and tilecache rtree for testing
(re: #2248, #5938, maybe others)
2019-04-08 15:59:42 -04:00
Quincy Morgan 5f60efacd5 Add Data Center preset 2019-04-08 11:39:43 -07:00
Quincy Morgan 50a0982d79 Merge pull request #6161 from jguthrie100/fix_closed_way_disconnect
Leave way as closed when disconnecting
2019-04-08 11:08:33 -07:00
Quincy Morgan 8d313677fd Add leisure=swimming_area preset 2019-04-08 09:53:01 -07:00
Quincy Morgan 4833f96dbb Merge branch 'master' of https://github.com/openstreetmap/iD 2019-04-08 09:47:32 -07:00
Quincy Morgan e1d4528a95 Add or update various preset icons
Deprecate shop=luggage and shop=bag
2019-04-08 09:46:28 -07:00
Bryan Housel 207cbd30dc Pacify eslint 2019-04-08 12:33:19 -04:00
Bryan Housel 7556df7265 Make sure to return the current version of entity from tree.intersects
Since d5e427289, the tree head graph will not update if only tags have
changed - it requires an addition, deletion, or geometry change.

This makes the tree a little more efficient, but we do need to make
sure to return the current entities to the caller.
2019-04-08 12:28:02 -04:00
J Guthrie 00c7eaddc2 Fix to work with PhatomJS 2019-04-08 17:07:12 +01:00
J Guthrie bd44cec2e8 Fix broken testcase! 2019-04-08 16:48:27 +01:00
J Guthrie ac29803b6f Fix eslint error 2019-04-08 16:38:10 +01:00
J Guthrie 4d24db597e Small refactor to improve efficiency 2019-04-08 16:28:01 +01:00
Jamie Guthrie a29da38230 Remove operationDisconnect test 2019-04-08 16:02:31 +01:00
Jamie Guthrie d3d0a560eb Remove excess whitespace 2019-04-08 16:01:08 +01:00
J Guthrie 57a0358061 Add test cases 2019-04-08 15:19:21 +01:00
Bryan Housel dcd2b4dfbe Update name-suggestion-index to v2.0.1 2019-04-08 09:43:00 -04:00
J Guthrie d7865ac4aa don't unclose way if it is part of a larger disconnect operation 2019-04-08 12:42:16 +01:00
J Guthrie 7edebb897f Only allow disconnect when selected ways relate to selected node 2019-04-08 12:41:05 +01:00
Bryan Housel 8d66289cba Run validation when switching fields, or when applying an issue fix 2019-04-07 23:10:20 -04:00
Quincy Morgan 3c515dcaaf Add or update icons for various presets 2019-04-07 16:42:25 -07:00
Quincy Morgan 8051ed5d82 Add Trailhead preset 2019-04-07 15:24:00 -07:00
Quincy Morgan c3653616e6 Make modals work better at small screen sizes
Flexbox the modal action buttons
Replace "col8" CSS class
2019-04-07 14:49:33 -07:00
Quincy Morgan 5e4e2ff7ee Fix an issue where stale warning counts would still appear in changeset tags if they had all been resolved (re: #6123) 2019-04-07 14:29:05 -07:00
Quincy Morgan eafd2cec3e Add a tooltip to the plus button in the "All relations" section (re: #3812) 2019-04-07 14:05:31 -07:00
Quincy Morgan 9d029a37a8 Delete newly-created untagged relations when deselecting them (close #3812) 2019-04-07 13:39:51 -07:00
Quincy Morgan 8815b878c5 Fix issue where selected way could not be disconnected if the connection point occurred more than once in the way (close #6149) 2019-04-07 12:47:20 -07:00
Quincy Morgan b0ba87c8fa Add terms to the Rail preset 2019-04-07 11:45:04 -07:00
Quincy Morgan 4ca7646896 Renamed Rail Under Construction to Railway Under Construction (since Rail has a more specific meaning) 2019-04-07 11:42:31 -07:00
Quincy Morgan 380a925c26 Add more terms for Underwear Store 2019-04-07 11:29:31 -07:00
Quincy Morgan 177b2df8d2 Add Underwear Store preset and deprecate shop=underwear and shop=lingerie (close #6152) 2019-04-07 11:26:58 -07:00
Quincy Morgan 11952c8f68 Don't flag traffic_calming=choker or chicane on line features (close #6153) 2019-04-07 10:28:17 -07:00
Quincy Morgan 9e91b606b9 Add Rail Under Construction preset (close #6151) 2019-04-07 10:20:34 -07:00
Bryan Housel e377270372 WIP: introduce validatedGraph, try on mode change not history change 2019-04-06 13:39:19 -04:00