16273 Commits

Author SHA1 Message Date
Quincy Morgan b7b1ce3d7f Fix footway icon colors on Chrome 2019-04-06 08:36:08 -07:00
Quincy Morgan 2e693d2c03 Add derived taginfo data 2019-04-06 08:32:04 -07:00
Bryan Housel 1bcc0f613c WIP: fix caches, replace id() function with plain id property 2019-04-05 17:41:04 -04:00
Quincy Morgan 6dd9e9ce48 Add code tests for incompatible_source validation 2019-04-05 13:53:57 -07:00
Quincy Morgan d1399fd99b Merge pull request #6146 from jguthrie100/make_list_of_invalid_sources
Allow for multiple invalid sources
2019-04-05 13:40:13 -07:00
Quincy Morgan ebc14dd0df Deprecate craft=glass, shop=baby, and shop=baby_care 2019-04-05 12:30:30 -07:00
Quincy Morgan 251d27b5f0 Add various tag deprecations 2019-04-05 12:09:28 -07:00
J Guthrie 6e6ed7fad5 eslint fixes 2019-04-05 19:01:12 +01:00
J Guthrie 1328054b08 Allow for multiple invalid sources 2019-04-05 18:49:14 +01:00
Bryan Housel 78acd999c8 WIP: switch from validating everything to validating differences 2019-04-05 13:29:57 -04:00
Quincy Morgan 195c1376d6 Remove oneway tag from some aerialway presets where it would be highly uncommon 2019-04-05 09:59:49 -07:00
Quincy Morgan 3d9cd5b5bf Fix highway=unsurfaced replacement tags 2019-04-05 09:55:14 -07:00
Quincy Morgan 8e7b3e304a Deprecate aerialway=canopy 2019-04-05 09:47:53 -07:00
Quincy Morgan f735c8e511 Add One Way field to aerialway presets 2019-04-05 09:44:59 -07:00
Quincy Morgan 17f2c5c0f4 Add Zip Line preset 2019-04-05 09:40:35 -07:00
Bryan Housel af45dbce10 Trying to avoid one-off validations when history changes will trigger it 2019-04-05 11:37:02 -04:00
Quincy Morgan ae8f2c2ad3 Add Diplomatic Office, Embassy, Consulate, and Liaison Office presets (close #6144)
Deprecate amenity=embassy
2019-04-05 08:24:30 -07:00
Bryan Housel f17ebee402 Use Set, simplify util functions to collect entities with children 2019-04-05 11:05:04 -04:00
Bryan Housel 6508edf820 Avoid anonymous functions as validators
Givnig them names makes it easier to understand in the profiler
2019-04-05 09:50:22 -04:00
Bryan Housel 82a9375e0f Move coreValidator test to test/spec/core/validator.js 2019-04-05 09:34:53 -04:00
Bryan Housel 8b1c0551cc WIP: understand state held by the validator, avoid translations
- Make sure all state variables prefixed with `_`
- Add explicit `init`/`reset` methods
  (graph/entity refs should never persist through a save to OSM)
- Thinking of how best cache validation results
2019-04-05 09:28:36 -04:00
Quincy Morgan 550a4df435 Prevent stale results when first searching presets 2019-04-04 18:24:05 -07:00
Quincy Morgan a054db6472 Fix issue where hover-highlighting wouldn't disappear upon removing a relation from a member or a member from a relation (close #5612) 2019-04-04 17:56:01 -07:00
Quincy Morgan 35c7cbd92b Ensure that undo/redo buttons look disabled when the map is not editable (close #6105) 2019-04-04 17:34:20 -07:00
Quincy Morgan 65e04acb2f Flag features that mention Google in the "source" tag (close #6135) 2019-04-04 08:32:03 -07:00
Bryan Housel d5e427289f Avoid delete/reinsert on the coreTree when not needed
(re: #6140)
2019-04-04 10:02:15 -04:00
Bryan Housel 68ed6da159 Merge branch 'master' into validation_and_change_perf 2019-04-04 09:30:30 -04:00
Bryan Housel 87e3b928d0 Reduce drawing during history changes
(closes #6086)
2019-04-03 23:26:26 -04:00
Quincy Morgan b52d8c1790 Add documentation for the geometry, tags, addTags, removeTags, and matchScore preset properties 2019-04-03 18:06:13 -07:00
Quincy Morgan e71b139171 Simplify almost junction validation 2019-04-03 16:41:26 -07:00
Quincy Morgan 6641f62685 Reduce duplicate code in almost junction validation 2019-04-03 15:44:45 -07:00
Bryan Housel 86de378de5 Add didChange object to track what kind of things changed in the diff 2019-04-03 17:43:04 -04:00
Bryan Housel 765d765477 Pick a fake loc value where equality tests actually work 2019-04-03 17:25:10 -04:00
Quincy Morgan cbae090f08 Fix crash in almost junction validation 2019-04-03 14:23:21 -07:00
Bryan Housel 167824a530 Make sure all nodes have an actual loc property
- This is to make difference comparisons easier
- The only nodes that didn't have a `loc` were fake nodes we made for testing
- So this commit also fixes the `osmIntersection` code and tests.
2019-04-03 16:20:45 -04:00
Quincy Morgan 34792d7fbf Don't add field defaults when upgrading tags to a specific replacement 2019-04-03 10:57:42 -07:00
Quincy Morgan d65298f383 Fix issue where generic vertex icon wouldn't show (close #6138) 2019-04-03 09:29:14 -07:00
Bryan Housel 561ffc402a Remove annotatedChange events (we'll replace with something else) 2019-04-03 11:56:56 -04:00
greenkeeper[bot] d40378d27d chore(package): update rollup to version 1.8.0 2019-04-03 09:53:16 -04:00
greenkeeper[bot] 8f15ea761b chore(package): update sinon to version 7.3.1 2019-04-03 09:53:03 -04:00
Quincy Morgan bf391c997a Fix issue where Points walkthrough could not be completed in some cases due to downgrade operation (re: #6103) 2019-04-02 20:23:27 -07:00
Quincy Morgan 8779e1a6dc Add Downgrade operation to remove most tags from features but retain address and building tags instead of immediate deletion 2019-04-02 11:09:08 -04:00
Quincy Morgan d5a2ca131d Fix issue with loading brand documentation (close #6134) 2019-04-02 07:21:30 -04:00
Quincy Morgan 103c533701 Add "Cycle & Foot Path" preset (re: #6070)
Offer to add "bicycle=designated" to features with "highway=cycleway" + "foot=designated" but no "bicycle" tag
2019-04-01 15:33:50 -04:00
Quincy Morgan 04e4cfc031 Flag paths with "no" access value for their implied designation (re: #6070) 2019-04-01 15:00:32 -04:00
Quincy Morgan cf6e6c7970 Always display the wikidata label and description in the user's language, if available 2019-04-01 13:04:33 -04:00
Quincy Morgan d5d4323c02 Replace "Use different layers" non-actionable quick fix with actionable quick fixes for setting a higher or lower layer (close #5943) 2019-04-01 11:52:04 -04:00
Quincy Morgan 2e7a47d0f2 Update the wikipedia tag when setting the wikidata tag via the field (close #5543) 2019-03-31 15:49:35 -04:00
Bryan Housel 1eeaca90a4 Add rollup-plugin-visualizer, but leave commented out
(this requires node 8+)
2019-03-30 10:11:00 -04:00
Bryan Housel b2831ffbd9 Don't export coreValidator here, as it's already exported by core * 2019-03-30 09:58:42 -04:00