16273 Commits

Author SHA1 Message Date
Bryan Housel ec51ebb026 Fix flexbox of raw membership editor new row
(closes #5589)
2018-12-11 21:54:25 -05:00
Bryan Housel 3de03439e2 Use user's locale for fetching wikidata label/description
(closes #5563)
2018-12-11 19:02:29 -05:00
Bryan Housel 9aceb8f725 Fix lazy instantiation of the fields
They are shown either if `_show=true` or `isPresent()`
2018-12-11 19:01:23 -05:00
Bryan Housel 13b1a9a629 If imagery becomes invalid, remove it from imagery_used
(closes #4827)
2018-12-11 17:49:15 -05:00
Bryan Housel 577e0c6503 Don't add "None" to imagery_used tag when other imagery was used
(closes #5565)
2018-12-11 16:37:52 -05:00
Bryan Housel 0d958f04c1 Don't try to render a field that's not yet shown 2018-12-11 16:37:36 -05:00
Bryan Housel ddf10d00aa Merge branch 'combobox-perf' 2018-12-11 16:12:00 -05:00
Bryan Housel 39b3f1df68 Avoid creating comboboxes
(closes #5568)

Several strategies in here:
- Move uiCombobox() from inside the render function to class variable
- Don't render stuff like the raw tag editor when it's collapsed
- Don't show as many fields/combos on hover
- Don't instantiate fields (like universal/more) until they're actually shown
- Bind the combo on enter selection not on update selection
2018-12-11 16:07:00 -05:00
Bryan Housel 222b3f1b04 Don't render contents of collapsed sections
(speeds things up if raw tag editor is hidden)
2018-12-11 15:19:29 -05:00
greenkeeper[bot] 5eaa3d0d44 chore(package): update mapillary-js to version 2.14.1 2018-12-11 09:19:51 -05:00
Bryan Housel a868284aba Merge pull request #5584 from RudyTheDev/traffic_calming_area_grass
Grass surface rendering for traffic calming areas
2018-12-11 01:22:44 -05:00
Bryan Housel 6732ca6eda Comboboxes no longer show on focus.. update tests 2018-12-11 01:19:51 -05:00
Bryan Housel ff646fa2c8 Dispatch a 'cancel' event if the user hits escape 2018-12-11 00:09:55 -05:00
Bryan Housel 6cf1d63b48 Make sure dropdown doesn't remain visible
(closes #5575)

Also improves keyboard navigation, and adds some scrollintoview
workarounds to make sure that the selected option is visible
while also not causing the whole page to move.
2018-12-10 23:54:06 -05:00
Bryan Housel 15a54cab17 Use context.container instead of passing it in 2018-12-10 14:14:27 -05:00
Bryan Housel e5dedeff8b Move lib/d3.combobox.js -> ui/combobox.js
As with other things from this lib/ folder, little original code remains
and turning these things into reusable d3 plugins is not a priority.
2018-12-10 12:38:21 -05:00
Bryan Housel 54a4546306 WIP to avoid _wrapper state variable, move towards combobox singleton 2018-12-10 12:15:50 -05:00
RudyTheDev 34cdb129c6 Add grass surface rendering for traffic calming areas 2018-12-10 17:41:53 +02:00
Bryan Housel 3aa7dcfc0c Allow some kinds of traffic calmings to be mapped as areas
(closes #5562)
2018-12-10 10:23:29 -05:00
Bryan Housel de59dd5d86 No padding needed for save count if it is being wrapped or narrow 2018-12-09 23:42:18 -05:00
Bryan Housel 5c9f9ac012 Always show save count 0.. makes responsivness easier
(closes #5576)
2018-12-09 23:31:52 -05:00
Quincy Morgan 5d35951f0f Corrects the name of the Internet Access Fee field in the presets README 2018-12-09 20:25:08 -08:00
Bryan Housel 4b3ce2c07c Add basin=* Type and intermittent fields to Basin preset
(closes #5497)
2018-12-09 23:13:15 -05:00
Quincy Morgan 5471b909e2 Added mechanism for displaying fields conditionally based on tags 2018-12-09 20:11:31 -08:00
Bryan Housel 2c0e975955 Add basin=* Type and intermittent fields to Basin preset
(closes #5497)
2018-12-09 23:11:14 -05:00
Bryan Housel 905f362317 Upgrade to maki v6.0.0
(closes #5559)
2018-12-09 22:43:42 -05:00
Bryan Housel 5774226ebf Update all fontawesome dependencies
(closes #5571, closes #5572)
2018-12-09 22:05:02 -05:00
greenkeeper[bot] c14ec72f5b chore(package): update rollup-plugin-node-resolve to version 4.0.0 2018-12-09 22:02:31 -05:00
Bryan Housel 05c24c95df Add an icon for grit bin 2018-12-09 21:32:01 -05:00
Bryan Housel 86085151e1 Fix misspelling - accidentally 2018-12-09 21:16:26 -05:00
Quincy Morgan f9552e6eea Merge pull request #5582 from quincylvania/more-fields
Define additional preset-specific fields for the "Add field" dropdown
2018-12-09 14:19:37 -08:00
Quincy Morgan 4285f2f5c0 Added "moreFields" property to the field schema
The "Add field" dropdown can now be used to add preset-specific fields in addition to universal fields
2018-12-09 13:51:57 -08:00
hikemaniac dd47acd64d Added more presets for shops 2018-12-09 14:43:48 +01:00
Bryan Housel cbcafaee15 Make sure sidebar is expanded before entering walkthrough or saving
(closes #5574)
2018-12-08 10:03:43 -05:00
Bryan Housel 49c53088c0 Merge branch 'field-updates' 2018-12-07 17:59:52 -05:00
Bryan Housel 7fd06f69b8 Use .select instead of .selectAll to propagate the bound data
(closes #5573)
2018-12-07 17:46:14 -05:00
Bryan Housel d574bfcd77 Disable autocomplete on the localized field
(closes #5558)
2018-12-07 17:19:02 -05:00
Bryan Housel 247900f727 Change several of the event things, remove numeric index
re: https://github.com/openstreetmap/iD/issues/5558#issuecomment-445307568
2018-12-07 16:54:32 -05:00
Quincy Morgan f8f5b690b7 Merge pull request #5561 from quincylvania/wi-fi-hotspot-preset-matchscore
Lowers the match score for the Wi-Fi Hotspot preset
2018-12-05 19:36:09 -08:00
Quincy Morgan 73d7f35afe Lowered the match score for the Wi-Fi Hotspot preset 2018-12-05 19:34:18 -08:00
Bryan Housel 77a9dde6f7 Make sure combobox can always receive arrow and esc events 2018-12-05 15:59:06 -05:00
Bryan Housel b494684e4f v2.12.1 2018-12-05 01:58:18 -05:00
Bryan Housel fe4a903df2 npm run translations 2018-12-05 01:53:51 -05:00
Bryan Housel bee01d8497 Destroy all old background layer tooltips before making new ones
(closes #5551)
2018-12-05 00:35:45 -05:00
Quincy Morgan 4bfc78c69b Merge pull request #5555 from quincylvania/walkthrough-crash-fix
Fixes an issue where the walkthrough would not display and cause an error
2018-12-04 17:33:52 -08:00
Quincy Morgan b366ace770 Switches from == to === in prior commit 2018-12-04 17:33:39 -08:00
Quincy Morgan 3cb2b8c901 Fixes an issue where the walkthrough would not display and cause an error 2018-12-04 17:29:19 -08:00
Bryan Housel 99e5fa7eaa Add missed link 2018-12-04 09:57:08 -05:00
Bryan Housel 344d0502e0 Missed some words 2018-12-04 00:02:28 -05:00
Bryan Housel 5451d0f3fe v2.12.0 2018-12-03 22:14:05 -05:00