CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-02-13 17:23:02 +00:00
Code Issues Packages Projects Releases Wiki Activity
9,828 Commits 2 Branches 0 Tags
07a53fe6ea785c62ee2cedbf9fa8454ec7861fa4
Commit Graph

1886 Commits

Author SHA1 Message Date
Xiaoming Gao
07a53fe6ea Extend data model for validation issues 
Add the Issues pane

1. Add a class to represent the validation issue
2. Extend the data model for an validation issue to
  (1) add a severity level field (useful for identify save-blocking issues later)
  (2) replace single entity with an array of entities (useful for issues involving multiple entities)
  (3) add a coordinates field for highlighting the location of the issue on the map
  (4) add a fixes field for possible automatic fixes

3. Update existing validation modules to use the new data model
 2018-12-19 10:37:32 -05:00
Quincy Morgan
0d0521c936 Moved feature applicability into the issue manager class 2018-12-19 10:32:14 -05:00
Quincy Morgan
161311faa5 Merge pull request #5626 from wonga00/wonga_issue_manager 
added IssueManager
 2018-12-18 18:05:40 -05:00
Quincy Morgan
858a9606d5 Added entity display name or preset name to the disconnected highway message 2018-12-18 18:05:27 -05:00
Andrew Wong
30f25c6e8d added IssueManager 
- IssueManager performs validation on the current graph and also
   stores the issues and notifies listeners when the issues changed
 2018-12-18 17:52:23 -05:00
Quincy Morgan
c1240af464 Added options UI in the Issues pane with edited vs all features selection 
Added basic issues list in the Issues pane
 2018-12-18 17:04:40 -05:00
Quincy Morgan
982f226d07 Merge branch 'master' into validation 2018-12-18 15:56:15 -05:00
Quincy Morgan
6e1dd34447 Fixed an issue where a new container would be added in the Map Data pane every time a section was re-expanded 2018-12-18 15:55:50 -05:00
Bryan Housel
5a2049b421 Drop extra whitespace, make sure service exists before using it 2018-12-18 15:38:53 -05:00
Quincy Morgan
e87a7e1125 Merge branch 'master' into validation 2018-12-18 15:35:55 -05:00
Bryan Housel
814c72fe42 Merge branch 'remote-presets' of https://github.com/radiant-maxar/iD into radiant-maxar-remote-presets 2018-12-18 15:15:11 -05:00
Max Grossman
1471b55122 lint! 
ref #5614
 2018-12-18 12:02:26 -05:00
Max Grossman
ae9d43b0ac remove double class 
ref #5614
 2018-12-18 11:16:37 -05:00
Quincy Morgan
cf0214d06a Add the Issues pane 2018-12-18 11:11:15 -05:00
Max Grossman
18c021b5d5 add css 
ref #5614
 2018-12-18 11:09:26 -05:00
Max Grossman
0328e4f9da add close button w/out css 
ref #5614
 2018-12-18 11:00:40 -05:00
Max Grossman
6ba8bacb75 use severity in test 2018-12-18 10:27:15 -05:00
Max Grossman
64f2d913e8 remove unused entities from test 2018-12-17 17:39:47 -05:00
Max Grossman
8f33a85a12 make collection.index function to handle failing tests 2018-12-17 17:16:10 -05:00
Max Grossman
d8de9e785e do not add found presets to recent 2018-12-17 14:56:33 -05:00
Max Grossman
74a19a6d7f remove a comment 2018-12-17 12:55:00 -05:00
Max Grossman
e0e6f5b918 remove non-used util class 2018-12-17 12:52:21 -05:00
RudyTheDev
743be30a76 Use water fill pattern for fountain area 2018-12-15 16:33:06 +02:00
RudyTheDev
89a128f14c Allow directly specified fill pattern for entire tag (not using for anything as of yet) 2018-12-15 15:58:39 +02:00
RudyTheDev
b92592b6b4 Add fill pattern for reservoir 2018-12-15 15:32:48 +02:00
Bryan Housel
43cea82d6f Make sure when selecting to restore the sidebar to select mode 
(closes #5603)
 2018-12-14 17:31:10 -05:00
Max Grossman
d87b1822f7 add/make visible weakly matched presets 2018-12-14 15:42:25 -05:00
Max Grossman
f627f1e659 make all presets visible on init!! 2018-12-14 13:29:17 -05:00
Max Grossman
1b51b8bc57 adding tests and updating/fixing external presets logic 2018-12-14 13:23:58 -05:00
Bryan Housel
e5aa8a7058 Simplify setPattern 2018-12-14 12:57:28 -05:00
Max Grossman
c897331cd1 presets test w/build 2018-12-13 13:30:38 -05:00
Max Grossman
96e44be69c merge 2.12.2 2018-12-13 11:22:32 -05:00
Max Grossman
f3e6459191 working on preset visibility 2018-12-13 11:16:24 -05:00
Bryan Housel
eb14a9ed53 v2.12.2 2018-12-13 10:28:31 -05:00
Bryan Housel
cd74e4e063 Fix broken member role dropdown for members that are not downloaded 
(closes #5592)
 2018-12-12 16:53:20 -05:00
Bryan Housel
f45e97d727 Variable cleanups 2018-12-12 16:13:32 -05:00
Bryan Housel
d28b269b4c Speed up the scrolling on Firefox Linux too 
(re: #5512)

This just changes
`detected.os === 'win'`  to  `detected.os !== 'mac'`
 2018-12-12 15:45:55 -05:00
Bryan Housel
17615da0ea Listen to both change and blur for role switcher, compare old v new 
(closes #5449)
 2018-12-12 15:27:14 -05:00
Bryan Housel
e08bfb2add Simplify accept/cancel event dispatchers, store datum in _choice 2018-12-12 15:26:18 -05:00
Bryan Housel
84f96574d7 Add index property to cloned object, not actual member object 
(closes #5458)

This code was adding an `index` property to each member in the relation.
Although the `index` property is ignored by the code that saves to OSM,
the extra property would make the member changed when compared by
`coreDifference`.
 2018-12-12 02:07:03 -05:00
Bryan Housel
c635389c1a Fix handling of semicolon delimited values in numeric field 
(closes #5438)
 2018-12-12 01:11:34 -05:00
Bryan Housel
fc1f7e4d46 Trigger a change event when accepting combo option with return, tab 
(closes #4900, closes #5449)

Some browsers need an explicit `change` event triggered on the input field
when a value has been changed by the combo and accepted by pressing return
or tab.  This was only an issue on combos that aren't part of uiFields,
since the uiFields are all setup to respond to `change`,`input`,`blur` etc.
 2018-12-11 23:25:47 -05:00
Bryan Housel
ec51ebb026 Fix flexbox of raw membership editor new row 
(closes #5589)
 2018-12-11 21:54:25 -05:00
Bryan Housel
3de03439e2 Use user's locale for fetching wikidata label/description 
(closes #5563)
 2018-12-11 19:02:29 -05:00
Bryan Housel
9aceb8f725 Fix lazy instantiation of the fields 
They are shown either if `_show=true` or `isPresent()`
 2018-12-11 19:01:23 -05:00
Bryan Housel
13b1a9a629 If imagery becomes invalid, remove it from imagery_used 
(closes #4827)
 2018-12-11 17:49:15 -05:00
Bryan Housel
577e0c6503 Don't add "None" to imagery_used tag when other imagery was used 
(closes #5565)
 2018-12-11 16:37:52 -05:00
Bryan Housel
0d958f04c1 Don't try to render a field that's not yet shown 2018-12-11 16:37:36 -05:00
Bryan Housel
ddf10d00aa Merge branch 'combobox-perf' 2018-12-11 16:12:00 -05:00
Bryan Housel
39b3f1df68 Avoid creating comboboxes 
(closes #5568)

Several strategies in here:
- Move uiCombobox() from inside the render function to class variable
- Don't render stuff like the raw tag editor when it's collapsed
- Don't show as many fields/combos on hover
- Don't instantiate fields (like universal/more) until they're actually shown
- Bind the combo on enter selection not on update selection
 2018-12-11 16:07:00 -05:00