Commit Graph

2881 Commits

Author SHA1 Message Date
Quincy Morgan
07bc2821cd Flag entire routing islands as single issues 2019-05-16 22:40:25 -04:00
Bryan Housel
bdb454e1b3 Remove utilCallWhenIdle, use requestIdleCallback/cancelIdleCallback
Places where a reset or connection switch would be problematic,
we can now cancel the callbacks.
2019-05-16 22:28:56 -04:00
Bryan Housel
a8c6ab4d67 Move requestIdleCallback polyfill to id.js, remove utilIdleWorker
`utilIdleWorker` was only used one place.
It just processes a list in an idle callback.

I'm working towards removing the util functions for handling idle work.
We can still do `requestIdleCallback` work throughout the code, however
each place we use it needs to have a strategy for cancellation, which
the existing util functions don't allow for.
2019-05-16 21:19:25 -04:00
Bryan Housel
ec0145de3a Prevent accidental loading of many tiles at low zoom
This could happen because `editable` was checked before the call was scheduled
not before the `loadTiles`.  The user can zoom out more while the call is deferred.
2019-05-16 16:44:19 -04:00
Bryan Housel
aa7820b699 Don't treat new raw_tag_editor rows the same as deleted rows
(closes #6369)
2019-05-16 15:36:47 -04:00
Quincy Morgan
961a79e4f2 Add photo overlays used during editing to the "source" changeset tag (close #6279) 2019-05-16 14:52:41 -04:00
Quincy Morgan
fa0c05f8f7 Don't render deprecated basin and reservoir features the same as their modern counterparts 2019-05-16 12:35:19 -04:00
Bryan Housel
7be09db9ef Don't try to change a key/value that's already about to be deleted
(closes #6366)
2019-05-15 14:02:23 -04:00
Quincy Morgan
93a475c9a2 Correct issue with almost junction layer handling 2019-05-14 16:48:24 -04:00
Quincy Morgan
99565e8457 Don't flag crossing waterways and pier highways 2019-05-14 15:39:04 -04:00
Quincy Morgan
8bc634beac Make the raw member display limit a single variable 2019-05-14 15:31:50 -04:00
Quincy Morgan
49bef3d277 Fix issue where entries in the raw member editor wouldn't update after downloading the member manually (close #6358) 2019-05-14 15:31:07 -04:00
Quincy Morgan
a9c30e840c Revalidate immediately after running most fixes (close #6354)
Allow individual fixes to control revalidation
Don't allow fixes to run within a second of running any fix for that issue
2019-05-14 14:41:07 -04:00
Quincy Morgan
409968dfc2 Add index of tags that positively identify points or vertices, derived from the presets
Delete nodes that can only be vertices when deleting parent ways (close #6230)
Allow snapping ways to nodes that cannot be positively identified as vertex-only
2019-05-14 12:09:44 -04:00
Quincy Morgan
4eedfa8b25 Don't allow autofixing unsquare buildings unless they are already very close to square
Allow autofixing buildings with tags
2019-05-13 16:28:08 -04:00
Quincy Morgan
bb4aa84a3b Don't flag almost junction issues between features on different layers or levels (close #6355) 2019-05-13 13:03:34 -04:00
Quincy Morgan
401c3a5005 Fix issue with the Label field by changing the class name of form-field-label (close #6344) 2019-05-13 10:36:21 -04:00
Quincy Morgan
b4b91dcb9e Revalidate the related entities of deleted entities when revalidating (close #6345) 2019-05-10 15:46:04 -04:00
Quincy Morgan
d1ad5a431f Don't check if data is downloaded for operations in the walkthrough 2019-05-10 12:44:02 -04:00
Quincy Morgan
ea1773f953 Fix error upon starting the walkthrough from the Help pane 2019-05-10 12:34:24 -04:00
Quincy Morgan
36a564f453 Add explicit check for very close nodes with an identical location 2019-05-10 12:14:29 -04:00
Quincy Morgan
7a6949aa2e Account for the width of open panes when centering the map on issues 2019-05-10 11:33:59 -04:00
Quincy Morgan
1bbd496dfe When selecting an issue in the Issues pane, highlight the issue after selecting the feature
Use the same behavior when selecting an issue in the commit sidebar as in the issues pane
2019-05-10 10:18:46 -04:00
Quincy Morgan
8de10def2a Use actionMergeNodes instead of operationMerge for the very close nodes issue fix (close #6343) 2019-05-10 09:12:11 -04:00
Quincy Morgan
ad744a75ef Use "nonsquare" instead of "nosquare" for marking unsquare ways as physically unsquare (re: #6332) 2019-05-09 19:11:11 -04:00
Quincy Morgan
7b441ab766 Don't flag unsquare buildings connected to building multipolygons 2019-05-09 18:06:40 -04:00
Quincy Morgan
58e6afd3ea Don't flag very close nodes in boundaries 2019-05-09 17:50:22 -04:00
Quincy Morgan
f264cc47f0 Don't flag almost junctions when endpoint is building or parking entrance
Include issues for disabled rules in entity issues
2019-05-09 14:38:19 -04:00
Quincy Morgan
0e7a63f5c5 Add quick fix to unsquare way validation to tag a way as having unsquare corners (close #6332) 2019-05-09 12:04:18 -04:00
Quincy Morgan
399b9be006 Don't flag very close nodes in ways with too few nodes, indoor ways, and very small ways 2019-05-08 17:15:18 -04:00
Quincy Morgan
dcd9876fdf Use thinner partial fills for buildings parts and indoor features (re: #6204) 2019-05-08 15:55:59 -04:00
Quincy Morgan
fd8f460739 Don't flag oneway highways that connect to highway areas or ferry routes as impossible
Don't flag oneway waterways that connect to springs, storm drains, water bodies, or coastlines as impossible
2019-05-08 15:36:37 -04:00
Quincy Morgan
1d797b8fc6 Validate connected ways when validating a way to avoid stale connectivity issues (close #6335) 2019-05-08 14:56:49 -04:00
Bryan Housel
86c6805cf7 Optionally include ids members of modified relations in extantIDs
(closes #6273)
2019-05-08 13:53:48 -04:00
Quincy Morgan
760134c2aa Add check for possible missing activeEntity in drag_node 2019-05-08 12:17:36 -04:00
Quincy Morgan
bafc0da99c Force child nodes visible when forcing a way visible (close #6328) 2019-05-08 10:50:21 -04:00
Quincy Morgan
3a78cf512c Move connect ways fix to its own function
Make the edges and connection tags part of the crossing ways issue ID
2019-05-08 10:32:25 -04:00
Bryan Housel
41f3bb9c07 Only include relation members that are visible, if extent supplied
followup to b0d5f0dd4
2019-05-08 09:23:04 -04:00
Bryan Housel
b0d5f0dd48 Include multipolygon members in complete()
(closes #3613)
2019-05-08 00:49:33 -04:00
Bryan Housel
289c75fee1 When showing tooltip, update disabled in case disabled states disagree
(closes #6296)
2019-05-07 17:53:22 -04:00
Bryan Housel
58cae43b9b Use parentNode instead of parentElement for IE 2019-05-07 17:48:56 -04:00
Quincy Morgan
3d9f7244f0 Update issue messages after merge instead of by invalidating issues 2019-05-07 16:38:08 -04:00
Quincy Morgan
73467d53b4 Don't flag highways connected to amenity=parking_entrance nodes as disconnected
Don't flag oneways with entrance endpoints as impossible
2019-05-07 14:55:57 -04:00
Quincy Morgan
97cb90b562 Make issue messages dynamic (close #6331) 2019-05-07 14:48:30 -04:00
Quincy Morgan
5160754dcc Display issues for disabled rules in the commit UI
Allow errors for disabled rules to block upload
Include warnings for disabled rules in the changeset tags (re: #6325)
2019-05-07 13:07:31 -04:00
Quincy Morgan
4a379480ad Merge branch 'master' of https://github.com/openstreetmap/iD 2019-05-07 12:29:11 -04:00
Quincy Morgan
fd35e10aa7 Make the very close nodes validation work for any way (close #6326) 2019-05-07 12:28:59 -04:00
Bryan Housel
901cab57da Remove _disabled caches for operations
(re: #6296, reverts 81127d7)
see https://github.com/openstreetmap/iD/issues/6296#issuecomment-489259027
(I'll find another way to deal with the menu not matching the tooltip)
2019-05-07 10:32:12 -04:00
Bryan Housel
d3a53309b7 Allow uppercase taginfo results for _ref tags
(closes #6324)
2019-05-07 09:32:13 -04:00
Bryan Housel
966f5c3586 Add explicit validation calls to each operation
This is cleaner than adding hooks to transitionable actions, or performing validation
on every history change.  We want validation to run after each operation, but not
while the user is drawing lines or typing in fields.
2019-05-06 14:49:46 -04:00