0b4a690a08
Move close endpoint handling into quick fix
...
Just a bit more optimised since this is only relevant to check when the
quick fix is used
2020-02-11 16:10:45 +00:00
006e692449
Convert to 2 space indentation
2020-02-11 16:10:45 +00:00
3c7b092534
Update almost junction validation with ES6 syntax
2020-02-11 16:10:45 +00:00
ec6ad0000b
Show derivation of close node thresholds in code
2020-02-11 16:10:44 +00:00
6976251ac2
Handle almost junction where end node are close
...
Based on distances at which nodes are joined by the quickfix and the
validation extends ahead of an end node, if both ways have close end
nodes and joining them would result in a small change of angle for the
edited way then they will be joined.
Closes #7201
2020-02-11 16:10:44 +00:00
3608659d21
Restore field inheritance
2020-02-10 16:22:13 -05:00
0357c2b80c
Rework presets.js file - WIP to fix resolving field inheritance
2020-02-07 14:17:19 -05:00
2149692bee
Make sure the addablePresetIDs can be reset back to null too
2020-02-07 12:55:16 -05:00
1155498766
Restore the addablePresetID feature
2020-02-07 12:06:59 -05:00
a9a1f945f8
Move the qa_data external
...
- this means that QAItem now asks the service for the icon rather than knowing it directly
2020-02-07 10:06:47 -05:00
4c5e7db2dd
Move the iD.data export from data/index.js to coreData
...
coreData now owns all the data, and data/index.js should eventually go away
(re: #4994 )
2020-02-07 09:27:23 -05:00
fe00a40e9a
Move the keepRight data extrnal
2020-02-07 09:16:34 -05:00
f8a4a0b3ad
Use d3_json Promise directly for Osmose requests
2020-02-07 11:29:48 +00:00
8bb2dc7fa6
Return Promise for Osmose string requests
2020-02-07 11:21:33 +00:00
7d76e0ac5c
Fix Osmose request resolving after UI moves on
...
- Previously caused minor unexpected renderer behaviour by forcing elements
visible when the user had moved on (potentially interfering with
whatever they're currently doing)
2020-02-07 10:43:44 +00:00
f86837d637
Fix use of double quotes
2020-02-06 23:12:18 +00:00
51efd5b714
Update and standardise QA implementations
...
- ES6ify (now using class syntax to define QAItem objects)
- Fix bug with KeepRight marker rendering not updating properly
- Use `qa-` prefix for the UI element classes to differentiate from iD
validation error related UI element classes
- Move away from "error" where possible in source
- Move away from snake_case naming where possible
Note that some function/method names have been untouched to make life
easier for v3 development. Have added note comments where appropriate.
2020-02-06 23:07:50 +00:00
9faf8c0fe5
Test that fallback presets are there before data is loaded
...
Also, we don't actually need a vertex preset anymore, it was removed a while ago
2020-02-06 17:04:11 -05:00
de0ac9d451
Upgrade to name-suggestion-index v4.0.0
...
(closes #7336 )
- json data files are distributed both regular and minified
- json data is no longer exported by index.mjs
2020-02-06 11:28:02 -05:00
13ead25654
Merge branch 'external_presets' into 2.x
...
(re: #4994 )
2020-02-05 21:32:51 -05:00
3c6ba9703a
presetIndex.build -> presetIndex.merge, and make it merge data
2020-02-05 21:13:15 -05:00
1720f7cb93
Organize some code in coreUploader (re: #7333 )
...
Fix lint error
2020-02-05 17:53:28 -05:00
237a382c51
Merge branch '2.x' into uploader
...
# Conflicts:
# modules/modes/save.js
2020-02-05 16:23:09 -05:00
3b19cc32fd
Don't grey out the map during conflict resolution ( close #6547 )
2020-02-05 16:16:50 -05:00
0e14241fcf
Move some upload code from modeSave to new coreUploader object (re: #7247 )
2020-02-05 15:28:23 -05:00
c4f0700309
Fix data urls
2020-02-05 13:27:25 -05:00
147af19626
Seed presetIndex collection with fallback presets
...
- amazingly, this passes all tests, but iD ends up pretty non-functional
2020-02-05 12:21:33 -05:00
e3e7cd3003
Memoize presetCollection.item (it's an Array.find)
...
Also add tests for `matchAllGeometry`
2020-02-05 10:32:20 -05:00
4194194e14
Prefix file variables in operations/orthogonalize.js with underscores
...
Simplify multiple disabled reasons code for circularize and orthogonalize operaitons
2020-02-05 10:10:12 -05:00
4ff634b90f
Enable the circularize operation for multiple selected features ( close #7326 )
2020-02-05 09:57:33 -05:00
0fe766d9a4
WIP on external presets
...
- preset data is no longer bundled into iD.js
- some code pathways commented out re: external presets
- many changes so that tests can run without presets at start, or async
- still need to make sure fallbacks are always there (point, line, area, etc)
2020-02-05 09:38:26 -05:00
4c843f60db
Merge pull request #7095 from openstreetmap/osmose
...
Add Osmose Q/A layer
2020-02-04 21:47:28 +00:00
03a097c847
Move Osmose translation link below details box
2020-02-04 21:44:20 +00:00
3745c06d62
Hide Osmose issue description if no string
2020-02-04 21:22:44 +00:00
087867d5c8
Use Promises for Osmose issue detail requests
...
Also ES6ify the details script
2020-02-04 21:08:02 +00:00
fe5ca6867c
Fix error in generating outdated_tags messgae
2020-02-04 13:00:14 -05:00
9d31d444d0
Show only issues shared by all features on multiselection
2020-02-04 12:09:54 -05:00
e6cf53dfe8
Fix use of test() method on color string
2020-02-04 12:05:36 +00:00
377e99240f
Add Osmose translations link to details footer
...
Improves structure of the details UI and introduces the use of flexboxes
for this. Does not break UI for other error services with shared classes.
2020-02-03 23:20:45 +00:00
1dd65cb93e
Correct Osmose UI element spacing
2020-02-03 23:20:45 +00:00
ecadafb3e4
Use Osmose supplied hex colors
2020-02-03 23:20:45 +00:00
cf878ca410
Use Object.keys() not Python {}.keys() 🤦♂️
2020-02-03 23:20:45 +00:00
2d2fa440c1
Use multiple specific Osmose string requests
...
- Only requesting the data we need (Osmose has many more issue types
than iD will ever display)
2020-02-03 23:20:45 +00:00
06ac02f89f
Use Osmose dynamic subtitile string
...
Providing a `langs` param that's currently not implemented so these will
all be English until that is done.
2020-02-03 23:20:45 +00:00
e3c6f58624
Format markdown in Osmose strings appropriately
2020-02-03 23:20:44 +00:00
010ca30999
Show more Osmose strings in the UI
...
Also only add sections where appropriate
2020-02-03 23:20:44 +00:00
7a00c0a974
Use Osmose locale filter and detail strings
2020-02-03 23:20:44 +00:00
5d93d3cace
Prepare to use Osmose issue detail strings
...
- Remove translation description strings, will be using supplied
translations once the API is updated
- Change the way elements and details are presented since they can't be
easily integrated into the 3rd party description strings
2020-02-03 23:20:44 +00:00
7d76950d55
Use Osmose translation strings for issue titles
...
This is just step one in the process while we wait for the API to supply
further strings and filtering to reduce the amount of string data
requested (since we don't need it all).
Strings are requested when the layer is first enabled and cached for the
current language (plus English as a backup).
2020-02-03 23:20:43 +00:00
6310349a5a
Use latest Osmose API tiles endpoint
2020-02-03 23:20:43 +00:00
SilentSpike