Commit Graph

9111 Commits

Author SHA1 Message Date
Max Grossman
155983197f small variable change 2018-09-23 12:26:14 -04:00
Max Grossman
8f9a281825 additional test tweaks
ref #remote-presets
2018-08-14 12:49:41 -04:00
Max Grossman
f168f85496 passing mapcss test w/out parser, use that on sever
ref #remote-presets
2018-08-10 09:16:59 -04:00
Max Grossman
3a0f8ddd09 infer geometries
ref #remote-presets
2018-08-08 13:21:35 -04:00
Max Grossman
f5c21ddaaf some geometry inferring!!!
ref #remote-presets
2018-08-08 08:50:45 -04:00
Max Grossman
b93444de75 working on isArea-ish equivalent for mapcss selector objects
ref #remote-presets
2018-08-02 18:03:13 -04:00
Max Grossman
5b1dee3779 add tests for mapcss checks
ref #remote-presets
2018-08-02 12:47:47 -04:00
Max Grossman
2bf5eaf6e7 initial plumbing for iD validation errors
ref #remote-presets
2018-07-31 14:22:34 -04:00
Max Grossman
db78df55c8 get validaiton objects on context
ref #remote-presets
2018-07-31 13:41:24 -04:00
Max Grossman
873b451bef move data presets overwritting to the build function
ref #remote-presets'
2018-07-19 15:39:20 -04:00
Max Grossman
57ea240177 make uiModes options strict to match only those within defaults
ref #remote-presets
2018-07-18 10:50:54 -04:00
Max Grossman
659a291e89 add core overwrite for external preset source
ref #remote-presets
2018-07-17 16:43:00 -04:00
Bryan Housel
4c9ef45448 Merge pull request #5149 from vershwal/mvt_test
Some mvt tests.
2018-07-17 01:15:28 -04:00
Bryan Housel
d205267f48 Adjust whitespace padding around avatar images in comments 2018-07-17 01:09:29 -04:00
Bryan Housel
fa6e195c2d Add user info, require authentication to edit a note 2018-07-17 00:55:43 -04:00
Bryan Housel
73d0f30453 Merge branch 'notes' 2018-07-16 16:59:35 -04:00
Bryan Housel
694cc60893 Add thread dots to note header icon, disable comments on closed nodes 2018-07-16 16:53:45 -04:00
Bryan Housel
47de7b304f Make sure note report link doesn't show on hover 2018-07-16 16:03:00 -04:00
Bryan Housel
70f87632c7 Cleaner note icon rendering
Before: We drew 2 fontawesome comment icons, on on top of the other
After: Moved icon into iD spritesheet and gave it an actual `stroke` property that can be styled
2018-07-16 13:18:38 -04:00
vershwal
213fa3706d Created new file for pbf test in test/data. 2018-07-16 22:10:59 +05:30
Thomas Hervey
33de399bac fixed note-report display 2018-07-16 11:28:51 -04:00
Thomas Hervey
7ad765d408 added simple tests for loading and retrieving notes 2018-07-16 10:54:40 -04:00
Bryan Housel
edc4f86826 Merge pull request #5137 from mapillary/feat-show-mjs-attribution
Show MJS photo attribution
2018-07-15 23:13:28 -04:00
vershwal
0b32f4c4ee Some mvt tests. 2018-07-15 22:20:43 +05:30
Bryan Housel
0d8792d4de npm run build 2018-07-14 00:38:48 -04:00
Bryan Housel
46ece7593a Merge pull request #5142 from AndreasHae/passenger-information-display
Add passenger information display to bus and tram presets
2018-07-14 00:35:31 -04:00
Andreas Hässler
d9f9f6e855 Add passenger information display preset 2018-07-13 23:15:43 +02:00
Thomas Hervey
7fb42ac9d6 added note reporting and margin to save buttons 2018-07-13 17:09:51 -04:00
Bryan Housel
1a106f5253 Make uiViewOnOSM work for notes too, add it to note_editor footer 2018-07-13 15:55:58 -04:00
Bryan Housel
33ef9a4357 Wrap callbacks with common checks for connection id and auth failure
This eliminates a lot of the copy-paste code in every callback.
2018-07-13 15:14:20 -04:00
Thomas Hervey
bd1586500e added tests for notes service 2018-07-13 15:01:43 -04:00
Bryan Housel
f783fbbec2 Merge pull request #5139 from mapillary/feat-viewer-default-size
Update photo viewer size for bigger screens
2018-07-13 09:53:36 -04:00
Bryan Housel
f825845b79 Can't skip seen on the userDetails call
This call really does need for a result to be passed to the callback
2018-07-13 00:31:04 -04:00
Bryan Housel
8a1079c3c6 Update notes on status change 2018-07-13 00:15:30 -04:00
Bryan Housel
775b47272d Remove from inflight cache before doing anything in done 2018-07-12 23:56:03 -04:00
Bryan Housel
57da729837 Implement note save button code 2018-07-12 23:50:29 -04:00
Bryan Housel
645cc790a3 Add docs about OSM API, finish implementing postNoteUpdate
`postNoteUpdate` can hangle status changes and comment additions
(I named it that to be like `putChangeset`)

Also renamed `user` to `loadUser` to be consistent with other calls
2018-07-12 23:46:07 -04:00
Matias Volpe
72a19e8ad7 Update photo viewer size for bigger screens 2018-07-12 18:11:00 -03:00
Matias Volpe
b617695ad1 Remove OSM iD custom photo attribution to show MJS photo attribution 2018-07-12 17:59:56 -03:00
Bryan Housel
19560ebc90 Properly save and restore caches when entering/leaving the walkthrough 2018-07-12 15:39:04 -04:00
Bryan Housel
fe7086f753 Add header close 'X' button, add grey hover styling 2018-07-12 02:51:49 -04:00
Bryan Housel
5e5601f555 Store the unsaved comment in the note itself 2018-07-12 02:09:24 -04:00
Bryan Housel
91add0c33e WIP on buttons, simplify, remove some event dispatch
- I made the buttons work like GitHub comment-on-issue buttons
before typing:  "Close Note" / "Comment" (disabled)
after typing:   "Close and Comment" / "Comment" (enabled)

- I removed a bunch of the event dispatches.  These are useful for sending
events to listeners/observers outside of the module.  In this case I think
we can handle most of the things from within the uiNoteEditor.  We can still
dispatch an 'update' event so that modeSelectNote can reselect and redraw
the note after some change happens to it.

TODO - make the buttons work / check the OSM API stuff.
2018-07-11 23:10:01 -04:00
Bryan Housel
3454753bf6 Drop more/less toggle and just use a scrollbar for long comments 2018-07-11 16:00:54 -04:00
Bryan Housel
e9e2f9ba8f Style note header 2018-07-11 15:41:43 -04:00
Bryan Housel
f52f24b517 Add noteOptions, default to 10k note limit and 7 days closed
Also bump note tile zoom to z12. There just aren't that many notes,
so this reduces API calls.
2018-07-10 23:28:37 -04:00
Bryan Housel
7423d192d4 Implement multi-fetch get for users from OSM API
Eagerly load user details after loading notes
(re: openstreetmap/openstreetmap-website#1921)
2018-07-10 23:02:37 -04:00
Bryan Housel
0d7c292c23 Refactor out uiNoteHeader and uiNoteComments into separate modules
uiNoteEditor was getting big!
2018-07-10 21:45:02 -04:00
Bryan Housel
cbd4020e33 npm run build 2018-07-10 17:45:18 -04:00
Bryan Housel
dc3e569ee4 Merge pull request #5133 from vershwal/kiosk_level
added level field to shop/kiosk
2018-07-10 16:18:30 -04:00