CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-02-13 09:12:52 +00:00
Code Issues Packages Projects Releases Wiki Activity
15,853 Commits 2 Branches 0 Tags
18de00a7bfd26155cb5fe25789c926a6aff27ec5
Commit Graph

132 Commits

Author SHA1 Message Date
arch0345
14794ee992 Remove references to ImproveOSM 2024-07-08 17:15:38 -07:00
Martin Raifer
ac77289b4d refactor localized text rendering in tooltips, flash messages 2022-06-23 18:55:57 +02:00
Martin Raifer
cc6f16d480 Merge branch 'develop' into accessible_ui 2021-12-07 16:22:01 +01:00
Milos Brzakovic (E-Search)
30ef0b80e1 headings - more appropriate h2's and disclosure h3 2021-12-01 18:17:19 +01:00
Martin Raifer
9f3f8e1366 rename method 2021-11-29 19:26:18 +01:00
Martin Raifer
d78c357588 replace raw html injection of localized texts 
by using d3 to insert the localized text spans directly into the DOM
 2021-11-26 18:51:45 +01:00
Milos Brzakovic (E-Search)
4db3e720c0 close icon button 2021-11-26 12:25:12 +01:00
Martin Raifer
8bbae82caa localizer: escape placeholder replacement values in html output mode 2021-11-18 13:09:16 +01:00
Bryan Housel
857b9c9adf Exclude 'fixme'/'help_request' warnings from changeset tags. 
They still appear in the issue list and in the entity editor.
(closes #8603)
 2021-08-02 14:34:18 -04:00
Quincy Morgan
a85ac34a35 Add tooltip to the review request checkbox (close #7227) 2020-12-03 13:50:56 -05:00
Quincy Morgan
7a3f3732dd Fix save sidebar header styling 2020-09-24 10:33:55 -04:00
Quincy Morgan
5435082d9c Revert t function to returning the plain string by default 
Add `t.html` function for getting the string with the `lang` attribute
 2020-09-22 12:03:29 -04:00
Quincy Morgan
a3549f9a76 Merge branch 'develop' into lang-attributes 
# Conflicts:
#	modules/ui/commit_warnings.js
#	modules/ui/field.js
#	modules/ui/fields/wikidata.js
#	modules/ui/fields/wikipedia.js
#	modules/ui/full_screen.js
#	modules/ui/panels/history.js
#	modules/ui/sections/entity_issues.js
#	modules/ui/sections/map_features.js
#	modules/ui/sections/raw_member_editor.js
#	modules/ui/sections/validation_rules.js
#	modules/ui/tag_reference.js
 2020-09-22 10:55:07 -04:00
Quincy Morgan
c0d420eb4b Fix keyboard navigation of the changeset upload raw tag list editor (re: #8004) 2020-09-18 11:43:24 -04:00
Quincy Morgan
32f8274929 Make t function return a span element with a lang attribute unless html: false is specified in the options (re: #7963) 
Update `text` functions to `html` to support inserting the `span` elements
Specify `html: false` for various instances where a `span` is not desired, e.g. `placeholder` and `title` attributes
 2020-09-15 21:56:22 -04:00
Quincy Morgan
3d4703b60c Fix various CSS issues 2020-07-06 15:28:25 -04:00
Quincy Morgan
874c412b74 Enforce max unicode charachter length of keys, values, and relation roles through truncation upon input rather than HTML maxlength attribute (close #6817) 
Normalize unicode when changing keys, values, and relation roles
 2020-06-10 14:11:55 -04:00
Quincy Morgan
762307bd7d Restrict key, value, and role character limits based on unicode characters, not UTF-16 code units (re: #6817) 2020-06-09 15:41:15 -04:00
Quincy Morgan
cb698fb9d3 Add endpoints for setting the default changeset parameters (close #7614) 
Make the cached changeset a property of the context
Properly clear cached changeset when resetting iD
 2020-05-20 14:48:27 -04:00
Quincy Morgan
d7e5aa6735 Keep track of the initial hash parameters through multiple loads of the UI (close #7504) 2020-04-14 14:03:18 -07:00
Quincy Morgan
417caba3be Fix issue where hashtags set in URL parameter would not be honored 2020-04-14 12:25:18 -07:00
Quincy Morgan
a58abe3c6f Move localStorage interface from a property of coreContext to a corePreferences function 2020-04-01 11:00:48 -07:00
Quincy Morgan
a1af118f0e Ensure locales and presets are loaded before the UI loads (close #7406) 
Consolidate localization behavior and init to a coreLocalizer function and singleton
Explicitly support `en-US` locale
Rename coreData to coreFileFetcher and export a singleton rather than using a property of coreContext
Add `apiConnections` property of coreContext to simplify adding a source switcher
Replace some init functions with re-callable, promise-supporting `ensureLoaded` functions
Make coreContext itself load the UI if a container has been specified at init time
Fix code tests
 2020-03-31 12:23:31 -07:00
Quincy Morgan
d62a62cba8 Make popover and tooltip part of the UI module instead of utils 2020-03-24 17:32:09 -07:00
Quincy Morgan
628b53eff6 Fix error upon changing raw changeset tags 2020-03-23 14:07:40 -07:00
Quincy Morgan
a3ae06001a Fix issue where upload would be blocked despite changeset comment 2020-03-23 14:04:08 -07:00
Quincy Morgan
68c5f87adc Clarify variable name 2020-03-22 12:57:56 -07:00
Quincy Morgan
4872b06a28 Randomize form field ids to thwart browser memory and help with embedding iD (close #6444) 2020-03-21 13:16:40 -07:00
Quincy Morgan
2e238b8218 Fix JS error on clicking review request 
Give different instances of the raw tag editor distinct classes and disclosure states
Correctly expand raw tags section by default when selecting a feature with a fallback preset
Fix raw tag editor tests
 2020-02-26 14:51:32 -08:00
Quincy Morgan
abf536aa9b Make commit changes its own collapsible section 2020-02-24 14:03:06 -08:00
Quincy Morgan
6782947f5b Make inspector sections inherit from uiSection (re: #7368) 2020-02-21 15:22:54 -08:00
SilentSpike
51efd5b714 Update and standardise QA implementations 
- ES6ify (now using class syntax to define QAItem objects)
- Fix bug with KeepRight marker rendering not updating properly
- Use `qa-` prefix for the UI element classes to differentiate from iD
validation error related UI element classes
- Move away from "error" where possible in source
- Move away from snake_case naming where possible

Note that some function/method names have been untouched to make life
easier for v3 development. Have added note comments where appropriate.
 2020-02-06 23:07:50 +00:00
Quincy Morgan
0e14241fcf Move some upload code from modeSave to new coreUploader object (re: #7247) 2020-02-05 15:28:23 -05:00
SilentSpike
d2f9278fe2 Port changeset tag improvement to ImproveOSM QA 
Also marked the `closed:` tags as readonly since these are filled in
automatically.

- Gives a count of each error type closed instead of making a list of
joined coordinates which quickly fills the maximum value length.
- This is more useful since a changeset already gives the area worked
on while these counts give insight into the type of changes made.
- Similar to iD own validation tags
 2020-02-03 23:20:43 +00:00
SilentSpike
a068cdfc59 Tag changeset with Osmose issue closed counts 
This seems more useful than tagging with a list of joined coordinates
which quickly becomes truncated due to tag value length.

Adds a tag per issue type similar to iDs own validation.
 2020-02-03 23:20:41 +00:00
SilentSpike
e11d97b38c Add Osmose QA layer and service 
Initial implementation - need to add UI for the errors and correctly set
up support for the desired error types provided by osmose.
 2020-02-03 23:01:01 +00:00
Quincy Morgan
89ce98f510 Don't require services/osm in order to get max OSM character lengths 2020-01-28 09:28:23 -05:00
Quincy Morgan
17ae12b3d7 Address most common places where tag keys or values could exceed the 255 character API limit (close #6817) 2020-01-27 15:57:55 -05:00
Quincy Morgan
7251a2ab90 Make "edited issues" mean "issues the user created" instead of "issues for features edited by the user" 
Only include issues created by the user in the "warnings" changeset tags
Include counts of issues resolved by the user in the changeset tags (close #6459)
Don't include "fixme" issue counts in "warnings" changeset tags since they're not created by the user (close #6658)
Don't cache crossing ways issues at the rule level
 2019-10-04 16:50:44 +02:00
Albin Larsson
cd5cd81ba5 make additional buttons and links keyboard accessible 2019-07-31 08:24:26 +02:00
Quincy Morgan
eb49a367b4 Don't reuse changeset comment, sources, and hashtags from prior uploads (close #6642, re: #6279) 2019-07-22 16:12:20 -04:00
Quincy Morgan
f5a8615f5c Fix bug where iD could add empty source tag to changeset (close #6405) 2019-05-22 10:47:23 -04:00
Quincy Morgan
961a79e4f2 Add photo overlays used during editing to the "source" changeset tag (close #6279) 2019-05-16 14:52:41 -04:00
Quincy Morgan
5160754dcc Display issues for disabled rules in the commit UI 
Allow errors for disabled rules to block upload
Include warnings for disabled rules in the changeset tags (re: #6325)
 2019-05-07 13:07:31 -04:00
Quincy Morgan
375779882d Add ability to ignore warnings 
Replace issue's array of entities with array of entity IDs
Improve issue ID hashing
 2019-04-29 17:52:32 -07:00
Quincy Morgan
239c622044 Don't tag redundant ignored warnings counts on changesets 2019-04-26 13:02:13 -07:00
Quincy Morgan
7d29a98a14 Add subtype to some validation issues 2019-04-25 10:35:27 -07:00
Quincy Morgan
f2ca5316b0 Add total ignored warnings count to changeset tags (re: #6123) 2019-04-25 09:34:07 -07:00
Quincy Morgan
d01bb78707 Reduce circular dependencies caused by importing from indexes, the location of the validation models, and the location of areaKeys (close #6237) 2019-04-24 13:45:59 -07:00
Bryan Housel
b5c5a00abc Get rid of the many_deletions validation 🔪 
It just doesn't fit in with all of the other validations that work on
entities, and it's not an actionable warning anyway.
https://github.com/openstreetmap/iD/pull/6140#issuecomment-483014618
 2019-04-19 13:33:29 -04:00