Xiaoming Gao
1d1b11723a
Merge pull request #5646 from gaoxm/connectWithExtend
...
add validation for almost junction situation
2019-01-09 14:34:01 -05:00
Xiaoming Gao
ecacab3ffe
add validation for almost junction
...
but avoid connect when the edge goes in parallel to the other road.
also added tests for the validation.
2019-01-08 15:44:55 -05:00
Quincy Morgan
70d5529a58
Added initial implementation of quick fix for connecting crossing features (still has some bugs)
2018-12-21 17:39:20 -05:00
Quincy Morgan
90bc7bf6a5
Changed crossing ways issue severity from error to warning
2018-12-21 17:21:29 -05:00
Andrew Wong
958d918bbe
Merge pull request #5639 from wonga00/more_tests
...
Added more validation tests
2018-12-21 16:49:11 -05:00
Quincy Morgan
67e585e4c5
Crossing ways issues now use the relevant parent relation when the offending way itself does not have relevant tags
2018-12-21 16:10:48 -05:00
Andrew Wong
437cc5a9a5
added severity checks
2018-12-21 15:42:19 -05:00
Quincy Morgan
c593bb3475
The issue id now accounts for all entities
2018-12-21 14:51:18 -05:00
Quincy Morgan
d9c6bd1f39
Added specialized issue messages for the common types of way crossing issues
...
Fixed several linting issues involving crossing way validations
2018-12-21 14:45:20 -05:00
Xiaoming Gao
5f333267f4
Merge pull request #5645 from gaoxm/improveCrossWayCheck
...
Improve cross way check
2018-12-21 14:16:47 -05:00
Quincy Morgan
dc3a42f33d
Fixed validation-related linting errors
2018-12-21 14:08:35 -05:00
Quincy Morgan
e7180b1c96
Reduced the width of the line between the entity issue label and its fixes
2018-12-21 14:05:08 -05:00
Xiaoming Gao
dee005e9aa
Improve cross way check
...
1. Add more way types and relation types to check
2. Add more legit crossing cases
3. Add tests for 1 and 2
2018-12-21 14:00:31 -05:00
Quincy Morgan
627b4ee732
Fixed an bug where the wrong feature could be deleted from the untagged feature issue fix
2018-12-21 14:00:08 -05:00
Quincy Morgan
c9350c632e
Add issue fixes UI
...
Add two issue fixes for untagged feature
2018-12-21 12:31:33 -05:00
Andrew Wong
67bab7aecf
don't import all of d3
2018-12-20 16:31:32 -05:00
Andrew Wong
5971bbebb7
Added more validation tests
2018-12-20 15:39:26 -05:00
Quincy Morgan
026597017a
Update styling in the entity issues list
2018-12-20 14:49:35 -05:00
Quincy Morgan
99e5a52bc9
Improved margins for the entity issues list
2018-12-20 14:18:15 -05:00
Quincy Morgan
d58867df7c
Add entity display label util function
...
Condense message and tooltip text for for the untagged feature issue
Use lighter border color for error issues
2018-12-20 14:04:15 -05:00
Quincy Morgan
373be68294
Merge branch 'master' into validation
2018-12-20 13:58:09 -05:00
Quincy Morgan
7c192a2e36
Fixed bug where the entity ID could not be found for the field
2018-12-20 12:25:35 -05:00
Quincy Morgan
d7ef2de073
Re-organizes issue messages and tooltips
2018-12-20 12:16:54 -05:00
Quincy Morgan
7416fc7ac3
Fixed typo in crossing ways issue label
2018-12-20 10:40:48 -05:00
Quincy Morgan
f0fa59874f
Merge branch 'master' into validation
2018-12-20 10:31:25 -05:00
Quincy Morgan
97c2361f43
Changed initial sidebar screen for highway intersection vertices from preset list to editor
2018-12-20 10:17:16 -05:00
Bryan Housel
62547e3459
Merge pull request #5638 from openstreetmap/5612
...
remove highlight from relation member after it is deleted from relation
2018-12-20 10:10:46 -05:00
Bryan Housel
e2c0f5edcd
Merge pull request #5636 from openstreetmap/5596
...
open combobox if anywhere on box clicked...
2018-12-20 10:09:24 -05:00
Max Grossman
9a5a77f96c
remove unneccessary space
...
ref #5612
2018-12-20 09:24:46 -05:00
Max Grossman
18c32511a2
remove member's highlight when removed from relation
...
ref #5612
2018-12-20 09:23:58 -05:00
Max Grossman
e3407d4168
do not use mouseover, use mousedown!
...
ref #5596
2018-12-20 09:05:23 -05:00
Max Grossman
5a1dfeec72
open combobox if anywhere on box clicked...
...
ref #5596
2018-12-20 08:47:37 -05:00
Xiaoming Gao
a4e1012c91
add crossing_way validation
...
Tests are also added and passed.
One thing to note: I had to add the tree() function to history so that I can
use the tree in the test; hope that's fine.
2018-12-19 19:23:35 -05:00
Quincy Morgan
2207a6c3a4
Added severity tooltip to issue icon
2018-12-19 18:35:17 -05:00
Quincy Morgan
ac539dddaa
Merge branch 'master' into validation
2018-12-19 18:13:44 -05:00
Quincy Morgan
90e3cd8e87
Merge pull request #5632 from quincylvania/sidebar-behavior-on-feature-selection
...
Change the initial inspector of the sidebar upon feature selection
2018-12-19 18:07:42 -05:00
Quincy Morgan
3cab39f590
Merge pull request #5631 from wonga00/continuous_validation
...
listening to user generated history changes for validation
2018-12-19 17:51:44 -05:00
Quincy Morgan
cfbb86f88c
Change the initial view of the sidebar on selection
2018-12-19 17:44:41 -05:00
Andrew Wong
6e749c70ef
listening to user generated history changes for validation
2018-12-19 17:28:34 -05:00
Quincy Morgan
490143d1a8
Added Issues section to the entity sidebar
...
Fixed bug where stale issues would stick around in the issues pane
2018-12-19 16:12:33 -05:00
Xiaoming Gao
efc64f3cf6
Merge pull request #5630 from wonga00/wonga_validation_tests
...
fixed maprules test and added missing_tag test
2018-12-19 14:03:53 -05:00
Quincy Morgan
9948a7729d
Darkened the error item hover color somewhat
2018-12-19 13:41:33 -05:00
Quincy Morgan
92cc7eae15
Added hover background colors to the issue list items
2018-12-19 13:38:36 -05:00
Andrew Wong
0e34313d1d
fixed maprules test
2018-12-19 13:38:21 -05:00
Andrew Wong
6ae25eada7
fixing tests around issues
2018-12-19 13:34:16 -05:00
Andrew Wong
c11ac6ed89
added missing_tag test
2018-12-19 13:33:02 -05:00
Quincy Morgan
14f62ec3b9
Merge branch 'master' into validation
2018-12-19 13:23:54 -05:00
Quincy Morgan
59b0252b0e
Fixed several linting errors
2018-12-19 13:22:48 -05:00
Quincy Morgan
fb182dca37
Removed unneeded code in the issues pane
2018-12-19 13:10:03 -05:00
Quincy Morgan
6a931f9be6
Added colors to issue list icons
...
Corrected icon for warnings
Made disconnected_highway issue a warning instead of an error
2018-12-19 13:07:47 -05:00
