CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-02-13 09:12:52 +00:00
Code Issues Packages Projects Releases Wiki Activity
11,056 Commits 2 Branches 0 Tags
207cbd30dc03e4a2369eb4eacdd794ad18022a46
Commit Graph

171 Commits

Author SHA1 Message Date
Bryan Housel
6508edf820 Avoid anonymous functions as validators 
Givnig them names makes it easier to understand in the profiler
 2019-04-05 09:50:22 -04:00
Bryan Housel
8b1c0551cc WIP: understand state held by the validator, avoid translations 
- Make sure all state variables prefixed with `_`
- Add explicit `init`/`reset` methods
  (graph/entity refs should never persist through a save to OSM)
- Thinking of how best cache validation results
 2019-04-05 09:28:36 -04:00
Quincy Morgan
e71b139171 Simplify almost junction validation 2019-04-03 16:41:26 -07:00
Quincy Morgan
6641f62685 Reduce duplicate code in almost junction validation 2019-04-03 15:44:45 -07:00
Quincy Morgan
cbae090f08 Fix crash in almost junction validation 2019-04-03 14:23:21 -07:00
Quincy Morgan
34792d7fbf Don't add field defaults when upgrading tags to a specific replacement 2019-04-03 10:57:42 -07:00
Quincy Morgan
d5d4323c02 Replace "Use different layers" non-actionable quick fix with actionable quick fixes for setting a higher or lower layer (close #5943) 2019-04-01 11:52:04 -04:00
Bryan Housel
3673a7c7e7 Remove lodash cloneDeep 
(re #6087)

- some were able to do a different approach
    (validations/almost_junction, and settings/*)
- some were replaced with custom speedy cloners
   (in orthogonalize clonePoints and osm.js cloneNoteCache)
- some just replaced with JSON.parse(JSON.stringify()))
 2019-03-29 17:18:40 -04:00
Bryan Housel
1ce4f0ad6a Remove lodash without 
(re: #6087)
 2019-03-25 21:56:54 -04:00
Bryan Housel
0e90167513 Remove lodash clone 
(re: #6087)
 2019-03-22 23:18:25 -04:00
Quincy Morgan
f114945628 Flag disconnected highway areas and multipolygons (close #6075) 
Don't flag highways connected only to highway multipolygons
 2019-03-21 10:13:59 -04:00
Bryan Housel
99d46e9f70 Upgrade to name-suggestion-index v2 
(closes #6073)
 2019-03-20 23:12:05 -04:00
Quincy Morgan
790d2e867e Flag private contact information on houses and other residential buildings (close #5850) 2019-03-20 17:14:44 -04:00
Quincy Morgan
fc7cc3177d Make conditions for being able to delete features via quick fixes the same as for the delete operation (close #6062) 
Simplify some validation code
 2019-03-19 12:39:41 -04:00
Quincy Morgan
374cae5a7d Add validation issue flagging ways with highway=road (close #5998) 2019-03-17 11:57:28 -04:00
Quincy Morgan
d075dac2be Add crossing=unmarked when connecting ambiguous crossings highways 2019-03-14 09:46:45 -04:00
Quincy Morgan
17087f42c8 Adding mechanism for specifying an upgrade path for deprecated presets (close #6045) 2019-03-13 17:51:12 -04:00
Quincy Morgan
fb25a44017 Generalize deprecated_tags validation to outdated_tags validation 
Add check for missing addTags go outdated_tags validation (close #6043, close #6042)
 2019-03-12 17:08:20 -04:00
Quincy Morgan
5ce788f6a3 Add bus_guideway as whitelisted value for checking crossing highways 2019-03-05 10:06:50 -05:00
Quincy Morgan
604ff29593 Use whitelist instead of blacklist for affected highways in crossing ways validation 2019-03-05 10:01:16 -05:00
Quincy Morgan
af5012107f Fix crash when drawing a favorite highway 2019-02-27 11:44:47 -05:00
Quincy Morgan
1f21b029fd Move tag upgrade fix to an action and add unit tests 2019-02-26 10:42:12 -05:00
Quincy Morgan
7d8453b1fb Remove service road exception for adding highway=crossing during crossing way fix (re: #5976) 2019-02-26 08:12:42 -05:00
Quincy Morgan
6aa1f86dfb Add warning for multipolygon members with no set role (close #5851) 2019-02-25 17:46:50 -05:00
Quincy Morgan
66301864c1 Fix false positive of tags suggesting area on features where other tags define the preset (close #5945, re: #5933) 2019-02-25 13:10:55 -05:00
Quincy Morgan
12b1af7002 Don't say tags imply area for tags that iD doesn't have a preset for (close #5933) 2019-02-25 12:42:39 -05:00
Quincy Morgan
7f58454958 Don't tag connection nodes of paths crossing service or track roads as highway=crossing in crossing ways quick fix (re: #5976) 2019-02-25 11:39:03 -05:00
Quincy Morgan
10e73fc15c Explicitly include certain railways for crossing validation instead of excluding some 
Don't flag abandoned or razed railway crossings
 2019-02-21 15:09:13 -05:00
Quincy Morgan
02d3097d8d Fix a cacheing issue 2019-02-21 13:34:51 -05:00
Quincy Morgan
51972ea78f Cache issues in crossing ways validation to avoid checking the same pairs twice 2019-02-21 11:49:31 -05:00
Quincy Morgan
2d6c49b92b Ignore proposed features for crossings ways, almost junction, and disconnected way validations (close #5922) 2019-02-21 10:14:25 -05:00
Quincy Morgan
7da37384f1 Fix an issue where stale missing tag errors could persist when canceling drawing a new way (close #5918) 
Don't show missing tags error for a feature that is still being drawn (re: #5898)
 2019-02-21 09:48:46 -05:00
Quincy Morgan
6342235a6b Use warning instead of error for missing tags issue for non-deletable relations 2019-02-20 10:27:49 -05:00
Quincy Morgan
e102c3fdc6 Don't allow actionable deletion of relations if not all members are downloaded 2019-02-20 10:20:26 -05:00
Quincy Morgan
598827db87 Add quick fix to remove deprecated tags 2019-02-20 10:06:44 -05:00
Quincy Morgan
cdc4557da5 Minor performance improvement in crossing ways by removing use of lodash and avoiding a concat within a reduce 2019-02-20 09:50:53 -05:00
Quincy Morgan
ba68d921fe Add icons for crossing ways fixes and almost junction connection fix 2019-02-20 09:02:05 -05:00
Quincy Morgan
6d397e89c6 Account for waterway bridges and implicit layers in crossing ways validation 2019-02-19 15:28:27 -05:00
Quincy Morgan
f536706763 Refactor crossing ways validation for performance 2019-02-19 14:40:54 -05:00
Quincy Morgan
b766f82cbd Improve crossing ways performance slightly by avoiding clone 2019-02-19 13:25:02 -05:00
Quincy Morgan
708c5e8155 Fix crash when undoing an added line past the first node 2019-02-19 12:10:05 -05:00
Quincy Morgan
12a44421c3 Account for indoor features in crossing ways validation 
Recommend using an appropriate structure/layer/level for crossing ways validation
Flag crossing highways on different levels but without bridges or tunnels
 2019-02-19 11:43:05 -05:00
Quincy Morgan
b43796a4c7 Don't flag almost junctions for points endpoints that also occur earlier in the way 2019-02-19 09:16:32 -05:00
Quincy Morgan
794e953d43 Don't suggest continuing a disconnected highway from endpoints that have noexit=yes 2019-02-19 08:40:49 -05:00
Quincy Morgan
7307beff21 Don't make connect endpoints fix for tag suggest area actionable if there aren't more than two nodes 2019-02-18 12:51:50 -05:00
Quincy Morgan
10d9f05739 Show the actual deprecated tag value in the issue message rather than the * placeholder 2019-02-18 12:17:52 -05:00
Quincy Morgan
66db6f3f2c Make building crossing validation only create one issue per feature pair (re: #5891) 2019-02-18 10:43:19 -05:00
Quincy Morgan
94cb9faaa2 Don't check for self-intersection in the crossing ways validation 2019-02-18 10:16:22 -05:00
Quincy Morgan
7021985aec Don't suggest connection fix for highway-building crossings (re: #5891) 2019-02-18 10:12:47 -05:00
Quincy Morgan
e48f8cfc48 Fix generic name issue message 2019-02-18 10:11:01 -05:00