be71554f61
Fix a bug where all data would disappear when switching modes while drawing a way ( close #5917 )
2019-02-21 09:22:03 -05:00
708c5e8155
Fix crash when undoing an added line past the first node
2019-02-19 12:10:05 -05:00
31eb837596
Fix issue where fixes would not expand when clicking an issue
...
Rename issue label class to messages
Remove fix list animation
2019-02-15 13:40:45 -05:00
058a8ee8ff
Merge branch 'master' into validation
2019-02-15 12:03:57 -05:00
0b86be7bcb
Fix bug where highlight would not appear on the first target node when continuing drawing a way
2019-02-15 11:56:31 -05:00
078b19c828
Better handle undo/interruption during behaviorDrawWay
2019-02-14 17:24:09 -05:00
db319e8ff5
Merge branch 'master' into validation
2019-02-11 07:59:29 -05:00
a80aaf65db
Improve performance when checking way for self-intersection when drawing
2019-02-05 11:42:45 -05:00
58e31bc45a
initial update to draw modes and hover behavior
...
ref #5811
2019-02-01 17:34:40 -05:00
1066f8f788
Fix issue where preset browser would show after continuing a line ( close #5770 )
2019-01-28 08:52:20 -05:00
bb30cbf555
Move lib/d3.keybinding.js -> util/keybinding.js
...
almost none of the original d3 "plugin" code remains
2018-11-13 13:42:09 -05:00
eba115803a
Variable cleanups in behavior and modes
2018-09-06 09:50:26 -04:00
d35494d003
Can finish drawing when cursor is in invalid position
...
- When drawing an Area, the leading edge is allowed to temporarily be in an invalid position (see #4655 )..
.. Finishing a drawing is disabled if doing so would close with the invalid leading edge
2018-03-08 02:53:03 +00:00
f0a27bc1ec
Simplify way segmentation and fix bug with adjacent segment type
...
(closes #4669 )
Now instead of creating MultiLineString targets, we just create a bunch of
LineString targets. This makes the code simpler, and anyway the entity is
still there in `properties` for drawing code to decide what to do with the target.
Incidentally, this change allows iD to support an extrusion operation.
(Because each way segment has its own unique GeoJSON target now)
2018-01-09 10:12:29 -05:00
e661281e38
Prevent self intersecting lines without a junction node
...
(closes #4646 )
2018-01-08 19:17:50 -05:00
ea9643e08b
Allow Alt/option key to disable geometry check and nope cursor
...
(re: #4646 )
2018-01-08 15:47:29 -05:00
58eaca2aa0
Ignore area closing segment during move when validating geometry
...
(closes #4655 )
2018-01-08 12:09:17 -05:00
6881205d43
All touch targets are GeoJSON now
...
This makes the code a bit more consistent and lets us avoid some
hacky and probably non-performant things:
- abusing CSS classes in the draw/drag datum functions (classed `.target`)
(is this thing target? just check d.properties)
- regexing the id for `-nope$`
(is this thing a nope target? just check d.properties)
- using context.hasEntity to get a the real entity
(is this thing a real osmEntity? just check d.properties)
- fixes code like the restriction editor which uses fake ids for split ways
2018-01-01 22:37:10 -05:00
4f02340374
Extract self-intersection code to geoHasSelfIntersections
...
Test for self-intersecting areas in both drag_node and draw_way
2017-12-28 23:10:52 -05:00
ee617779a4
Snap to nope targets too (snapping is useful feedback)
...
Also remove "acting" cursor, which was overriding the no-action
cursor in some situations.
2017-12-25 23:11:00 -05:00
64a11f4cbf
Restore ability to extend line at beginning or end
2017-12-22 15:08:05 -05:00
2be62fffe5
All the complicated code in drawWay can be removed
...
Now that we can target specific segments along a line, we don't need
temporary drawing objects or extra code to check for self intersections
2017-12-22 00:01:23 -05:00
5d9b051f84
Fix drag_node for touch targets and line snapping
2017-12-21 20:31:20 -05:00
7994baae23
WIP: trying singular activeID and smarter target drawing code
...
The goal here is that the code that draws the targets should know better
what parts of the lines/vertices are targetable, rather than just
relying on CSS to ignore the pointer events on the whole line.
e.g. when drawing a line, it's ok for it to loop back and connect
to itself, just not on a segment or vertex adjacent to the active
node.
2017-12-19 11:23:35 -05:00
563c496a65
Update selected vertices when drawing in select mode
...
This is a better solution to catching and drawing new verteices that
got added because a user double clicked on a line.
2017-12-19 09:08:59 -05:00
7a8f50c74e
More fixes for drawing/snapping, don't draw touch targets for activeIDs
2017-12-18 22:54:49 -05:00
75d2c45fd6
Convert lodah-es and d3 to named imports for behaviors
2017-09-24 21:43:54 -04:00
4ee5d7334b
Fix spacebar drawing and hover in Firefox - don't match active node
...
(closes #4016 )
2017-05-08 01:37:38 -04:00
a18d690dd5
Don't let window.location changes happen during draw modes
...
(closes #3996 )
2017-05-03 17:15:35 -04:00
651ec363f6
Undo/Redo while drawing line/area should keep the user in drawing mode
...
(closes #3530 )
2017-05-03 16:08:23 -04:00
e756520bd8
suppressMenu(true) is now the default
2017-02-21 15:47:22 -05:00
fd9b3931d8
Use temp names for temp segments
...
(closes #1369 )
2017-01-13 18:44:42 +05:30
45b7a40557
Fix area drawing for #3676
...
These changes are needed now that `addNode`
* wants to preserve circularity
* automatically remove duplicates
* range checks index argument (can't call it with -1 anymore)
2017-01-12 19:30:07 +05:30
07fa5fcc34
Refactor Entity, Node, Relation, Tags, Way from core to osm
2016-10-11 22:41:24 -04:00
3102a4ae6a
Rename all the things to include pseudonamespaces
2016-10-04 19:06:20 -04:00
947a1d9c1a
Resolve lints
2016-09-03 19:08:03 -04:00
3af54610ca
Refactor customEvent system to use d3.customEvent
2016-09-03 17:56:56 -04:00
a86f34b4ef
Pacify eslint, get build and tests running again
2016-08-26 01:15:07 -04:00
cdb533fa84
Begin d3 v4 update
2016-08-21 15:19:27 -04:00
af776501d3
Require locale, second pass ( #3259 )
...
* Require locale, second pass
* Remove t global, remove t where it isn't needed
2016-07-21 16:20:13 -04:00
604d1e2719
import lodash ( #3257 )
2016-07-19 12:04:16 -04:00
39c82af158
Sort modules [eslint rule]
2016-07-06 12:12:08 +05:30
0939983515
external modules for behavior
2016-06-22 12:34:43 +05:30
14f0d95e94
modularize iD.behavior
2016-06-17 12:53:19 +05:30
Quincy Morgan