CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-02-13 09:12:52 +00:00
Code Issues Packages Projects Releases Wiki Activity
14,740 Commits 2 Branches 0 Tags
2ca52e75ce91fc415eedcceb3edb5b4e160366da
Commit Graph

415 Commits

Author SHA1 Message Date
Martin Raifer
6a9e0997c7 Handle indoor features like buildings when checking for crossing ways 
see https://github.com/openstreetmap/iD/issues/8944#issuecomment-1029213558
 2022-02-03 19:11:27 +01:00
ᴄʜʀɪsᴛᴏᴘʜᴇʀ ᴍᴇɴɢ
eb82698fa5 Remove accidental mismatch of "PAMAP" (#8889) 2022-01-28 15:34:19 +01:00
Martin Raifer
4363bac574 document why code is commented out 2021-12-10 18:19:59 +01:00
Benjamin Clark
9bfcd56c35 Fix bug that was causing google validation warnings to appear over changesets with the approved google africa building dataset. 2021-12-09 12:33:27 -05:00
Martin Raifer
9f3f8e1366 rename method 2021-11-29 19:26:18 +01:00
Martin Raifer
d78c357588 replace raw html injection of localized texts 
by using d3 to insert the localized text spans directly into the DOM
 2021-11-26 18:51:45 +01:00
Martin Raifer
4f51ededfd fix eslint "no-implicit-coercion" warning 
See https://eslint.org/docs/rules/no-implicit-coercion for this warning. However the implicit type conversion is unnecessary here, since `Number.toFixed` already returns a string, see https://developer.mozilla.org/de/docs/Web/JavaScript/Reference/Global_Objects/Number/toFixed.
 2021-11-16 11:20:01 +01:00
Milos Brzakovic (E-Search)
599d2df19b matchTags - don't calculcate valid locations unless needed 
mismatched_geometry - small optimization
 2021-10-20 09:49:00 +02:00
Milos Brzakovic
a018d276eb Merge pull request #8701 from openstreetmap/check_china_source 
Add warning for some commercial mapservice in China
 2021-09-30 12:06:36 +02:00
Milos Brzakovic
a00a9162e7 Merge branch 'develop' into tag_as_not 2021-09-27 19:03:46 +02:00
Bryan Housel
73f8737d17 Adjust the regex for matching Chinese map providers 2021-09-17 12:54:49 -04:00
Bryan Housel
defc87e455 Add warning for some commercial mapservice in China 
(closes #8700)
 2021-09-17 11:36:48 -04:00
Bryan Housel
1f172d5623 Make the crossing_ways hash less strict 
Previously it was including a lot of data about the edge, and a very specific
crossing location.  This meant that any tiny perturbation in the crossing ways
would generate a new issue hash, effectively "fixing" the old crossing issue and
creating a new one.
 2021-08-13 16:24:29 -04:00
Bryan Housel
b5d7cdb6fa Use utilHashcode to generate reasonable ids for crossing_ways issues 
The ones before were a giant blob of json
 2021-08-13 12:56:50 -04:00
Bryan Housel
0db99fe530 When adding not:* tag, remove the old wikipedia and wikidata tags 2021-08-07 00:42:07 -04:00
Bryan Housel
97ddf125d2 Adjust wording of "Tag as not the same thing" 2021-08-06 17:14:32 -04:00
Bryan Housel
52e8555a8f Add a validator fix option to tag as not: a matched item 
(re: #6577)
 2021-08-06 12:26:19 -04:00
Milos Brzakovic
750b4e023f crossing_ways fixing - specially handle crossing nodes 2021-08-05 14:50:38 +02:00
Milos Brzakovic (E-Search)
d2036996e3 Merge conflicts resolved 2021-07-05 10:26:44 +02:00
Bryan Housel
9f30ebf551 Adjust verbose utilDisplayLabel call, use for more validation messages 
(re: https://github.com/osmlab/name-suggestion-index/issues/4543#issuecomment-794527259)
 2021-03-10 10:30:57 -05:00
Bryan Housel
c3e9e8c8ff Support a more verbose format for listing issues 
Includes the feature type in the label
(re: https://github.com/osmlab/name-suggestion-index/issues/4543#issuecomment-791919134)
 2021-03-08 12:15:17 -05:00
Bryan Housel
1f6a2121c4 Move all of NSI into a service, rewrite matcher code 2021-03-03 12:04:37 -05:00
Bryan Housel
3665f80d46 Also include operator:wikidata as a wikidata tag 
osmEntity#hasWikipedia was only used by the suspicious_name validator
 2021-01-29 11:11:59 -05:00
Bryan Housel
b032cd9f01 Adust NSI matching validation code: 
- don't try matching semicolon-separated lists to NSI
- better matching for flagpoles with a `country` tag
- better lists of namelike keys (don't match flag operator)

see: https://github.com/openstreetmap/iD/pull/8305#issuecomment-769174070
 2021-01-28 17:17:49 -05:00
Bryan Housel
4c1d51348d Don't repurpose a node with interesting tags in crossing_ways fix 
(closes #8326)
 2021-01-27 14:38:11 -05:00
Bryan Housel
3640e15fa2 Fix misspelling "coprorate" -> "corporate" 2021-01-27 11:54:39 -05:00
Bryan Housel
f87c2d9357 Allow validators to return provisional results, revalidate after delay 
Also add a ton of commments to validator.js
 2021-01-27 10:38:48 -05:00
Bryan Housel
96298f2836 Preserve name value if this preset shows brand or operator field 
This also fixes the logic for calculating whether the preset shows a
`brand` or `operator` field - it needs to use `fields()` to actually
resolve the fields, as these fields can be inherited from another preset.

This also includes a change to match "primary" names before
"alternate" names (aka the "Baby Gap" / "Gap" problem)
 2021-01-19 13:15:16 -05:00
Bryan Housel
f61a3ef5e3 Don't replace flag:name tag - it's expected to be in local language 2021-01-18 21:44:27 -05:00
Bryan Housel
a32553595c name:pronunciation is not namelike 2021-01-18 21:39:06 -05:00
Bryan Housel
74d28257c4 Fix teh misspellings 2021-01-18 19:48:35 -05:00
Bryan Housel
0b3795cde3 NSI match returns an object now 2021-01-15 17:25:24 -05:00
Bryan Housel
d3fb8c60f9 Upgrade validations outdated_tags, suspicious_names to NSI v5 2021-01-13 13:46:00 -05:00
Bryan Housel
0ad7de0f10 Move the location index and resolver into a global coreLocations 2021-01-08 11:29:51 -05:00
Quincy Morgan
da00571409 Update variable name 2021-01-05 12:43:27 -05:00
Quincy Morgan
2c2eabb145 Don't count tags under the name namespace as descriptive tags (close #8273) 
Don't count `description`, `note`, `start_date`, or tags under those namespaces as descriptive tags
 2021-01-05 09:56:19 -05:00
Quincy Morgan
0a0e2dcf75 Fix issue where extracting points could results in off placements (close #8246) 2020-12-11 12:50:32 -05:00
Quincy Morgan
32dcfcc08e Fix spelling 2020-12-07 10:55:43 -05:00
Quincy Morgan
2dd6bce851 Add quick fix to convert areas to lines for mismatched geometry validation 2020-12-07 09:47:18 -05:00
Quincy Morgan
c43fac8d64 Ignore nodes on address lines for the mismatched geometry validation 2020-12-07 09:46:37 -05:00
Quincy Morgan
a7b3985237 Flag points as areas or lines, areas or lines as points, and lines as areas (close #8231) 2020-12-04 16:22:36 -05:00
Quincy Morgan
dc8fd13586 Enable array-callback-return eslint rule 2020-10-23 13:47:09 -04:00
Quincy Morgan
380473033b Enable no-duplicate-imports eslint rule 2020-10-23 12:02:37 -04:00
Quincy Morgan
eaf6ff874e Support the Relations editor for multiple selected features (close #7753) 2020-10-15 11:31:32 -04:00
Quincy Morgan
80eb197212 Merge pull request #7752 from peternewman/patch-6 
Fix a lot of typos and initial codespell action run
 2020-10-05 14:02:19 -04:00
Quincy Morgan
c940d827e6 Enable the Split operation for multiple selected nodes (close #7990) 2020-09-24 15:13:05 -04:00
Quincy Morgan
9effdf9724 Display the expected preset name for the mismatched geometry issue messages (close #8018) 2020-09-24 08:58:45 -04:00
Quincy Morgan
7b5df1bc40 Add lang attribute to issue fix labels (re: #7963) 2020-09-22 17:48:35 -04:00
Quincy Morgan
aa9b44a0bf Add the lang attribute to issue messages (re: #7963) 2020-09-22 17:25:18 -04:00
Quincy Morgan
5435082d9c Revert t function to returning the plain string by default 
Add `t.html` function for getting the string with the `lang` attribute
 2020-09-22 12:03:29 -04:00