Quincy Morgan
af5012107f
Fix crash when drawing a favorite highway
2019-02-27 11:44:47 -05:00
Quincy Morgan
1f21b029fd
Move tag upgrade fix to an action and add unit tests
2019-02-26 10:42:12 -05:00
Quincy Morgan
7d8453b1fb
Remove service road exception for adding highway=crossing during crossing way fix (re: #5976 )
2019-02-26 08:12:42 -05:00
Quincy Morgan
6aa1f86dfb
Add warning for multipolygon members with no set role ( close #5851 )
2019-02-25 17:46:50 -05:00
Quincy Morgan
66301864c1
Fix false positive of tags suggesting area on features where other tags define the preset ( close #5945 , re: #5933 )
2019-02-25 13:10:55 -05:00
Quincy Morgan
12b1af7002
Don't say tags imply area for tags that iD doesn't have a preset for ( close #5933 )
2019-02-25 12:42:39 -05:00
Quincy Morgan
7f58454958
Don't tag connection nodes of paths crossing service or track roads as highway=crossing in crossing ways quick fix (re: #5976 )
2019-02-25 11:39:03 -05:00
Quincy Morgan
10e73fc15c
Explicitly include certain railways for crossing validation instead of excluding some
...
Don't flag abandoned or razed railway crossings
2019-02-21 15:09:13 -05:00
Quincy Morgan
02d3097d8d
Fix a cacheing issue
2019-02-21 13:34:51 -05:00
Quincy Morgan
51972ea78f
Cache issues in crossing ways validation to avoid checking the same pairs twice
2019-02-21 11:49:31 -05:00
Quincy Morgan
2d6c49b92b
Ignore proposed features for crossings ways, almost junction, and disconnected way validations ( close #5922 )
2019-02-21 10:14:25 -05:00
Quincy Morgan
7da37384f1
Fix an issue where stale missing tag errors could persist when canceling drawing a new way ( close #5918 )
...
Don't show missing tags error for a feature that is still being drawn (re: #5898 )
2019-02-21 09:48:46 -05:00
Quincy Morgan
6342235a6b
Use warning instead of error for missing tags issue for non-deletable relations
2019-02-20 10:27:49 -05:00
Quincy Morgan
e102c3fdc6
Don't allow actionable deletion of relations if not all members are downloaded
2019-02-20 10:20:26 -05:00
Quincy Morgan
598827db87
Add quick fix to remove deprecated tags
2019-02-20 10:06:44 -05:00
Quincy Morgan
cdc4557da5
Minor performance improvement in crossing ways by removing use of lodash and avoiding a concat within a reduce
2019-02-20 09:50:53 -05:00
Quincy Morgan
ba68d921fe
Add icons for crossing ways fixes and almost junction connection fix
2019-02-20 09:02:05 -05:00
Quincy Morgan
6d397e89c6
Account for waterway bridges and implicit layers in crossing ways validation
2019-02-19 15:28:27 -05:00
Quincy Morgan
f536706763
Refactor crossing ways validation for performance
2019-02-19 14:40:54 -05:00
Quincy Morgan
b766f82cbd
Improve crossing ways performance slightly by avoiding clone
2019-02-19 13:25:02 -05:00
Quincy Morgan
708c5e8155
Fix crash when undoing an added line past the first node
2019-02-19 12:10:05 -05:00
Quincy Morgan
12a44421c3
Account for indoor features in crossing ways validation
...
Recommend using an appropriate structure/layer/level for crossing ways validation
Flag crossing highways on different levels but without bridges or tunnels
2019-02-19 11:43:05 -05:00
Quincy Morgan
b43796a4c7
Don't flag almost junctions for points endpoints that also occur earlier in the way
2019-02-19 09:16:32 -05:00
Quincy Morgan
794e953d43
Don't suggest continuing a disconnected highway from endpoints that have noexit=yes
2019-02-19 08:40:49 -05:00
Quincy Morgan
7307beff21
Don't make connect endpoints fix for tag suggest area actionable if there aren't more than two nodes
2019-02-18 12:51:50 -05:00
Quincy Morgan
10d9f05739
Show the actual deprecated tag value in the issue message rather than the * placeholder
2019-02-18 12:17:52 -05:00
Quincy Morgan
66db6f3f2c
Make building crossing validation only create one issue per feature pair (re: #5891 )
2019-02-18 10:43:19 -05:00
Quincy Morgan
94cb9faaa2
Don't check for self-intersection in the crossing ways validation
2019-02-18 10:16:22 -05:00
Quincy Morgan
7021985aec
Don't suggest connection fix for highway-building crossings (re: #5891 )
2019-02-18 10:12:47 -05:00
Quincy Morgan
e48f8cfc48
Fix generic name issue message
2019-02-18 10:11:01 -05:00
Quincy Morgan
2c1955d630
Improve performance and scope of the generic name validation
2019-02-18 10:02:49 -05:00
Quincy Morgan
397097ac1f
Tweak issue and fix strings
...
Different strings for one vs. a combination of deprecated tags
2019-02-15 14:24:11 -05:00
Quincy Morgan
1821c3e955
Update fixes UI for icons, link styling, and non-actionable fixes
...
Fix several bugs
2019-02-14 15:56:04 -05:00
Bryan Housel
c86f11c359
Don't suggest extending disconnected line if it is closed
...
Extend at start/end doesn't make sense in this situation
2019-02-14 14:09:44 -05:00
Bryan Housel
c4fe42653a
s/coordinates/loc and replace legacy names in tests
...
In iD codebase `loc` is usually a single coordinate pair
and `coordinates` is usually an array of pairs
2019-02-12 21:18:25 -05:00
Bryan Housel
448fe498bd
Only recenter view if necessary, select after delay, fix maprules type
2019-02-12 17:25:54 -05:00
Bryan Housel
14896b0ce5
Documentation, and move validation type up to top of each file
2019-02-12 16:07:08 -05:00
Bryan Housel
9d58c4d0a2
Alphabetic
2019-02-11 14:11:35 -05:00
Bryan Housel
251a83ff7a
Nitpicky code formatting stuff
...
- no multiline var declaration
- squish together and alphabatize imports
- linebreaks for readability
2019-02-11 13:55:58 -05:00
Bryan Housel
a6e05b8ac5
Rename for consistency - these are called "annotations" elsewhere
2019-02-11 13:36:02 -05:00
Quincy Morgan
6a9bb2d138
Add crossing tags when connecting paths crossing roads with the quick fix
2019-02-11 12:03:56 -05:00
Quincy Morgan
47ec58e5fc
Don't zoom to the end vertex when continuing a disconnected highway if it is already visible
...
Add separate fixes for continuing a disconnected highway from the start and end vertices
Highlight the vertex that will be continued
2019-02-11 11:29:34 -05:00
Quincy Morgan
55f71f5a7d
Replace Set objects in crossing ways validation
2019-02-08 09:20:41 -05:00
Quincy Morgan
5b8fea9e87
Use existing nodes where possible in the crossing ways connection fix
...
Fix a lint warning
2019-02-06 15:03:29 -05:00
Quincy Morgan
50fcff6ec9
Only check the edge nodes for almost junction merge fix
2019-02-06 14:12:19 -05:00
Quincy Morgan
7765baf03b
Make merge threshold consistent for almost_junction and tag_suggests_area connection fixes
2019-02-06 13:12:58 -05:00
Quincy Morgan
88ecbcc069
Make the tag_suggests_area connection fix always use the location of the first node
2019-02-06 13:10:22 -05:00
Quincy Morgan
b25d75a6cc
Use existing nodes where possible in almost junction connection fix
2019-02-06 12:47:12 -05:00
Quincy Morgan
8545ebde8e
Add self-intersection check before flagging almost junction issues
2019-02-06 11:29:58 -05:00
Quincy Morgan
33d02cdba0
Add different messages for no tags vs. no descriptive tags warnings
...
Add warning for relation without a "type" tag
2019-02-06 09:38:33 -05:00
