Commit Graph

10182 Commits

Author SHA1 Message Date
SilentSpike 3174db76b7 Fix north direction in some error descriptions 2019-02-01 22:50:58 +00:00
SilentSpike 9d2792836f Add ImproveOSM error resolution 2019-02-01 22:50:58 +00:00
SilentSpike ac4cec1429 Add sidebar preview for ImproveOSM errors 2019-02-01 22:50:57 +00:00
SilentSpike 214cf41019 Use more generic classes for errors 2019-02-01 22:50:57 +00:00
SilentSpike 39880e559b Add direction of travel to turn restriction errors 2019-02-01 22:50:56 +00:00
SilentSpike 9600d67fc6 Differentiate missing geometry errors by colour 2019-02-01 22:50:56 +00:00
SilentSpike bea6f4dcfd Use point averages for locations 2019-02-01 22:50:56 +00:00
SilentSpike ca290b5101 Add details to error messages 2019-02-01 22:50:55 +00:00
SilentSpike 23a4d71410 Handle turn restriction errors 2019-02-01 22:50:55 +00:00
SilentSpike 4f2646d567 Add basic title + description UI 2019-02-01 22:50:54 +00:00
SilentSpike 4d89810721 Add ImproveOSM service
Only processing one-way errors for now
2019-02-01 22:50:54 +00:00
Bryan Housel 9d8a0b7843 Merge pull request #5836 from openstreetmap/5829
do not close image viewer if street level imagery layers are still rendered
2019-02-01 16:42:31 -05:00
Bryan Housel 491ec40435 Ditch the separate linear platform presets for public transport
(closes #5837)
2019-02-01 16:42:52 -05:00
Bryan Housel e50b82d2ad Ditch the separate linear platform presets for public transport
(closes #5837)
2019-02-01 16:38:33 -05:00
Bryan Housel f79d3d1d9f Change color of groyne, breakwater, dam, weir
(closes #5759)

Now rendered in grey instead of blue waterway color
2019-02-01 14:28:31 -05:00
Bryan Housel df093b25fe Only add the documentation bottom padding when expanded 2019-02-01 14:02:36 -05:00
Max Grossman 7f837c7e0c no need to generate service variable
ref #5929
2019-02-01 14:01:17 -05:00
Max Grossman ec1a42ad39 clean up & remove hideViewer for openstreetcam
ref #5829
2019-02-01 13:59:04 -05:00
Max Grossman d894521143 just don't close viewer...
ref #5829
2019-02-01 13:55:10 -05:00
Bryan Housel b75b7c567d Increase padding slightly between tag refrence and following element 2019-02-01 13:35:37 -05:00
Max Grossman ce8d16a220 initial commit...hide parts, not entire viewer
ref #5829
2019-02-01 11:49:30 -05:00
Bryan Housel d1fca87d79 Replace Edit Documentation link with pencil icon
(closes #5753)
2019-02-01 11:49:03 -05:00
Bryan Housel bde55bd7ee Update presets for new community index 2019-02-01 11:02:42 -05:00
Bryan Housel fc7fcd1e29 Merge pull request #5834 from SilentSpike/editorconfig
Add .editorconfig file
2019-01-30 17:25:45 -05:00
SilentSpike 9efcb60960 Add .json to .editorconfig 2019-01-30 22:22:17 +00:00
SilentSpike 1a66435b35 Add .editorconfig file 2019-01-30 21:47:17 +00:00
Bryan Housel 09f7f9189f Fix field tests to run with minimal set of presets 2019-01-30 16:29:27 -05:00
Bryan Housel 71b2d2c6b7 Upgrade legacy symbols in tests
- iD.Context -> iD.coreContext
- iD.Graph -> iD.coreGraph
- iD.Node -> iD.osmNode
- iD.Way -> iD.osmWay
- iD.Relation -> iD.osmRelation
2019-01-30 15:43:02 -05:00
Bryan Housel 7138acc652 Properly export areaKeys, fix preset and maprules tests 2019-01-30 15:29:37 -05:00
Bryan Housel 15c0b82eb2 First attempt to run tests with minimal preset config 2019-01-30 10:25:40 -05:00
Bryan Housel 17bbc3d5a2 Slightly improve suggestion placement, preset search performance
- avoid lodash _filter when native filter is ok for arrays
- for suggestions use `originalName` instead of adding/removing the en-dash
- bump up importance of leading suggestions, but do a strict leading search

more on that last point:
For normal presets, we count a string as leading if it follows a space.
e.g. "office" will match "Law Office"
We don't really want this for suggestion presets though
e.g. "bell" should not match "Taco Bell"
2019-01-29 21:56:23 -05:00
Bryan Housel a4eab24117 Merge pull request #5744 from SilentSpike/javascript-eol
Update .gitattributes to use lf eol for .js files
2019-01-29 15:14:20 -05:00
Bryan Housel 7e3f08b31a Restore missing paths_intersect string needed for #5745 2019-01-29 15:09:49 -05:00
Bryan Housel 7aea67fcfe Merge pull request #5745 from jguthrie100/stop_merge_overlapping_self
Add check to stop joining ways if resulting way intersects itself
2019-01-29 14:07:34 -05:00
Bryan Housel 0f41913b04 pacify eslint 2019-01-29 14:04:36 -05:00
Bryan Housel a2212a732b Merge pull request #5816 from SilentSpike/mapillary-icon
Fix street imagery hover and selection behaviour
2019-01-29 13:59:28 -05:00
Bryan Housel ad3f491116 Replace maki "M" museum icon
(closes #5751)
2019-01-29 13:51:34 -05:00
Bryan Housel d3c0d1a7b7 Merge pull request #5826 from SilentSpike/reverse-turns
Fix turn:lanes changing when way is reversed
2019-01-29 09:31:41 -05:00
SilentSpike 20d629ac9e Fix turn:lanes changing when way is reversed 2019-01-29 14:19:35 +00:00
Quincy Morgan b1de70c63f Add Sundial preset (close #5771) 2019-01-29 09:13:25 -05:00
Quincy Morgan b2e57c37e9 Add Minaret preset (close #5817) 2019-01-29 09:04:27 -05:00
Quincy Morgan 28f49d3015 Add Bell Tower preset (close #5772)
Update tower presets to use field inheritance
2019-01-29 08:55:11 -05:00
Quincy Morgan c9fef9e3fe Add Climbing Gym preset (close #5749) 2019-01-29 08:41:45 -05:00
Quincy Morgan a6636a2f44 Add Salt and Tidal fields to water presets (close #5822) 2019-01-29 08:29:21 -05:00
SilentSpike 129c28fb25 Fix street imagery selection highlight persistence
Root cause was the `select` mode removing the "selected" class from all
elements upon `exit()`. Easy fix is to use a different class (here
"currentView") for street imagery elements.
2019-01-29 13:26:53 +00:00
SilentSpike 99f7a90387 Fix imagery layers resetting eachother's classes
Fixes:
- Selecting a bubble then enabling a second imagery layer removes the hovered and selected highlighting
- If multiple imagery layers are enabled and you select a bubble it only temporarily becomes highlighted
- If multiple imagery layers are enabled and a bubble is highlighted, hovering over another imagery layer's bubble will remove the selected and hovered highlighting

Basically these all came down to style updates resetting all layers for
cases other than when the viewport was changed (where doing so makes
sense because the selected bubble/sequence needs to update as a result).

See #5494
2019-01-29 13:25:47 +00:00
SilentSpike da41d9d921 Fix mouseover events on imagery layer bubbles
This is just a minor thing that doesn't usually alter visible behaviour.

The mouseover and mouseout events would fire when moving between child
elements of the svg group which was unnecessary.
2019-01-29 13:24:01 +00:00
Quincy Morgan 02ccd7cfd6 v2.13.1 2019-01-28 17:38:05 -05:00
Quincy Morgan 78a7869cd9 npm run translations 2019-01-28 17:37:13 -05:00
Bryan Housel f952422695 Update Changelog with combobox bugfixes 2019-01-28 16:35:10 -05:00