CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-03-12 14:16:14 +00:00
Code Issues Packages Projects Releases Wiki Activity
10,182 Commits 2 Branches 0 Tags
3174db76b7382b063f3475a7f236d7d4dfaf1cb7
Commit Graph

313 Commits

Author SHA1 Message Date
SilentSpike
3174db76b7 Fix north direction in some error descriptions 2019-02-01 22:50:58 +00:00
SilentSpike
9d2792836f Add ImproveOSM error resolution 2019-02-01 22:50:58 +00:00
SilentSpike
214cf41019 Use more generic classes for errors 2019-02-01 22:50:57 +00:00
SilentSpike
39880e559b Add direction of travel to turn restriction errors 2019-02-01 22:50:56 +00:00
SilentSpike
9600d67fc6 Differentiate missing geometry errors by colour 2019-02-01 22:50:56 +00:00
SilentSpike
bea6f4dcfd Use point averages for locations 2019-02-01 22:50:56 +00:00
SilentSpike
ca290b5101 Add details to error messages 2019-02-01 22:50:55 +00:00
SilentSpike
23a4d71410 Handle turn restriction errors 2019-02-01 22:50:55 +00:00
SilentSpike
4f2646d567 Add basic title + description UI 2019-02-01 22:50:54 +00:00
SilentSpike
4d89810721 Add ImproveOSM service 
Only processing one-way errors for now
 2019-02-01 22:50:54 +00:00
Bryan Housel
7138acc652 Properly export areaKeys, fix preset and maprules tests 2019-01-30 15:29:37 -05:00
SilentSpike
129c28fb25 Fix street imagery selection highlight persistence 
Root cause was the `select` mode removing the "selected" class from all
elements upon `exit()`. Easy fix is to use a different class (here
"currentView") for street imagery elements.
 2019-01-29 13:26:53 +00:00
SilentSpike
99f7a90387 Fix imagery layers resetting eachother's classes 
Fixes:
- Selecting a bubble then enabling a second imagery layer removes the hovered and selected highlighting
- If multiple imagery layers are enabled and you select a bubble it only temporarily becomes highlighted
- If multiple imagery layers are enabled and a bubble is highlighted, hovering over another imagery layer's bubble will remove the selected and hovered highlighting

Basically these all came down to style updates resetting all layers for
cases other than when the viewport was changed (where doing so makes
sense because the selected bubble/sequence needs to update as a result).

See #5494
 2019-01-29 13:25:47 +00:00
Bryan Housel
b3953e4a31 Don't mix up inflight tile requests with inflight keepright updates 
(closes #5748)
 2019-01-22 23:20:17 -05:00
Bryan Housel
0c7b9a631e Improve combobox event handling and avoid overwriting typed data 
(closes #5722, re: #5637, re: #5618)

dispatched with a value() string instead of a datum, which
causes issues for code expecting a datum always.
(such as localized.js brand picker or "Add Field" combo)

Fix for this coming in next commit.
 2019-01-22 22:26:27 -05:00
Yuri Astrakhan
9ed347534b Remove unused import 2019-01-15 21:59:05 -05:00
Yuri Astrakhan
d724677c9f Support extracting wiki info from tag and key 2019-01-15 21:50:57 -05:00
Yuri Astrakhan
1127a34f94 Add wiki links from tag description 
This feature requires P31 property to be present
in the data item. For an example, see
https://wiki.openstreetmap.org/wiki/Item:Q104#P31

Once the bot populates them in the data items,
it will automatically work for all existing keys/tags.
 2019-01-15 20:07:45 -05:00
Bryan Housel
55a92ca79d Add closed:note changeset tag for closed OSM notes 2019-01-11 10:14:55 -05:00
Bryan Housel
5ebe0976fe Add closed:keepright changeset tag for closed issues 
The issues are written as `schema:error_id` and semicolon delimited
e.g.  `closed:keepright=56:102661142`
closes this issue:
https://www.keepright.at/report_map.php?schema=56&error=102661142
 2019-01-10 23:27:55 -05:00
Bryan Housel
623f96449e z-sort errors above warnings 2019-01-10 21:47:37 -05:00
Bryan Housel
ae8dffa43c Improve URL error messages 411, 412, 413 2019-01-10 21:35:13 -05:00
Bryan Housel
7f321abbaf Add links to the main error object in KeepRight error messages 
re: https://github.com/openstreetmap/iD/issues/5679#issuecomment-452281850
 2019-01-10 17:38:09 -05:00
Bryan Housel
5f2d80c7a6 pacify eslint 2019-01-08 10:58:47 -05:00
Bryan Housel
d9015baa47 Improve links in KeepRight error messages 
(re: #5679)

Also move the localizeable string dictionary to data/keepRight.json
 2019-01-07 16:10:44 -05:00
Bryan Housel
7986fcbfbf Merge branch 'keep-right_QA' 2019-01-04 21:37:19 -05:00
Bryan Housel
48cc06fdbb Adjust distance from KeepRight marker and underlying geometry 
Makes it easier to select the point/vertex that the error is about.
 2019-01-04 21:28:35 -05:00
Bryan Housel
fadd8e2e8a Switch KeepRight markers to use touch targets 
This makes it easier to select the KeepRight issue and avoid selecting
the OSM geometry underneath them
 2019-01-04 21:17:38 -05:00
Bryan Housel
d0343c9fa7 Reintroduce some error localization, fix some nagging parse issues 2019-01-03 18:16:28 -05:00
Bryan Housel
35f8078f98 Reduce number of marker colors, increase contrast, tweak language 2019-01-03 15:30:36 -05:00
Bryan Housel
46ebce2d6f Fix error reporting urls and make sure sidebar not showing stale data 2019-01-03 11:37:14 -05:00
Bryan Housel
9e6497b549 Update or remove the error after POSTing changes to server 2019-01-03 01:39:40 -05:00
Bryan Housel
69ce5ee964 Remove user details and auth and adjust button texts for commenting 
The user details and auth are not needed
because KeepRight accepts only anonymous updating
 2019-01-03 00:07:55 -05:00
Bryan Housel
4494c3ab9c Fix comment box style, remove unused vars for eslint 2019-01-02 15:46:25 -05:00
Bryan Housel
9557c0204a Relax some more regex for tag parsing, (to support 'key=*') 
Also implement parsing error 231 - layer conflict
 2019-01-02 13:39:21 -05:00
Bryan Housel
2ec02f369f Simplify regex matching - goal is to have fewer, simpler rules 2019-01-02 11:46:13 -05:00
Bryan Housel
192b4da9e6 Fix the strings I broke in 3785ffb15 2018-12-29 17:30:35 -05:00
Yuri Astrakhan
9f7f4aa3fc Fix language fallback processing, caching bug. 2018-12-23 01:57:26 -05:00
Yuri Astrakhan
aa78cd10a3 Data items - remove hardcoded locale IDs 
Locale IDs are now fetched together with the other data
when the language code is provided.
 2018-12-22 14:58:15 -05:00
Bryan Housel
3785ffb154 Simplify translation strings 2018-12-22 12:12:28 -05:00
Yuri Astrakhan
b2810105a5 Implement support for multilingual descriptions from wiki data items 
* Takes data directly from the Wikibase data items (OSM Wiki)
     https://wiki.openstreetmap.org/wiki/OpenStreetMap:Data_Items
* Understands the difference in regions - e.g. will show different
  images depending on the local settings
* Perf: Single request will get both the tag and key description
 2018-12-22 00:23:31 -05:00
Bryan Housel
22e36be4f2 WIP on replacing documentation with direct calls to OSM wikibase 2018-12-22 00:23:31 -05:00
Bryan Housel
f7150004c0 Refactor things out of util with limited use, move more to service 2018-12-21 11:56:55 -05:00
Bryan Housel
4eb0e4b3a4 Remove more duplicate strings 2018-12-20 16:09:18 -05:00
Bryan Housel
177537f0ce Move coincident markers away from related geometry and from each other 2018-12-20 15:23:53 -05:00
Bryan Housel
7f669d292f Simplify KeepRight tile fetching code 2018-12-20 14:40:14 -05:00
Thomas Hervey
cedf6955b5 added: notes and todos for keepRight 2018-12-19 13:45:34 -05:00
Thomas Hervey
ee00635cc4 updated: some error colors; fixed: error 320, 220 2018-12-19 13:45:15 -05:00
Thomas Hervey
d125c62c78 updated: variable and function names, html regex 2018-12-19 13:43:48 -05:00
Thomas Hervey
d095de08fe updated comment UI, added stub for POST; TODO: finish links & POST 2018-12-19 13:43:48 -05:00