Quincy Morgan
31eb837596
Fix issue where fixes would not expand when clicking an issue
...
Rename issue label class to messages
Remove fix list animation
2019-02-15 13:40:45 -05:00
Quincy Morgan
058a8ee8ff
Merge branch 'master' into validation
2019-02-15 12:03:57 -05:00
Quincy Morgan
0b86be7bcb
Fix bug where highlight would not appear on the first target node when continuing drawing a way
2019-02-15 11:56:31 -05:00
Quincy Morgan
96a1ec92c7
Fix prior commit
...
Apply same node snap suppression behavior to dragging vertices as to drawing ways
2019-02-15 10:28:43 -05:00
Quincy Morgan
55c10d2183
Only check to suppress vertex-snap highlighting for nodes (re: #5875 )
2019-02-15 09:09:35 -05:00
Bryan Housel
078b19c828
Better handle undo/interruption during behaviorDrawWay
2019-02-14 17:24:09 -05:00
Quincy Morgan
db319e8ff5
Merge branch 'master' into validation
2019-02-11 07:59:29 -05:00
Bryan Housel
6e45796be7
Merge pull request #5875 from openstreetmap/dont-snap-non-vertices
...
Dont snap to non-vertices
2019-02-10 22:13:09 -05:00
Quincy Morgan
a80aaf65db
Improve performance when checking way for self-intersection when drawing
2019-02-05 11:42:45 -05:00
SilentSpike
781558e56b
Remove redundant source property
2019-02-04 18:40:06 +00:00
SilentSpike
3ed13e9a4a
Convert KeepRight to use generic error type
2019-02-04 16:54:07 +00:00
SilentSpike
20ed8b50c9
Add generic QA error
...
I've converted the improveOSM errors to use this new generic QA error
structure which should allow for more general code to be used in
behaviour and UI.
Sidebar preview is currently broken, but will be fixed shortly.
2019-02-04 16:53:59 +00:00
SilentSpike
ee5f9f3bf2
Use consistent short service name
2019-02-01 22:51:02 +00:00
SilentSpike
214cf41019
Use more generic classes for errors
2019-02-01 22:50:57 +00:00
SilentSpike
4f2646d567
Add basic title + description UI
2019-02-01 22:50:54 +00:00
Max Grossman
58e31bc45a
initial update to draw modes and hover behavior
...
ref #5811
2019-02-01 17:34:40 -05:00
Quincy Morgan
1066f8f788
Fix issue where preset browser would show after continuing a line ( close #5770 )
2019-01-28 08:52:20 -05:00
Bryan Housel
fadd8e2e8a
Switch KeepRight markers to use touch targets
...
This makes it easier to select the KeepRight issue and avoid selecting
the OSM geometry underneath them
2019-01-04 21:17:38 -05:00
Bryan Housel
cd9203975d
Use touch targets for notes, fix a few bugs with note dragging
...
(closes #5213 )
2019-01-04 15:48:39 -05:00
Thomas Hervey
31f35b0389
added basics to sidebar
2018-12-19 13:35:26 -05:00
Bryan Housel
152022aec4
Use context.keybinding for keybindings that don't change
...
(closes #5487 )
2018-11-13 20:57:21 -05:00
Bryan Housel
bb30cbf555
Move lib/d3.keybinding.js -> util/keybinding.js
...
almost none of the original d3 "plugin" code remains
2018-11-13 13:42:09 -05:00
Bryan Housel
2ffcec965a
Don't snap notes to OSM elements
...
(closes #5191 )
2018-11-12 17:23:38 -05:00
Bryan Housel
eba115803a
Variable cleanups in behavior and modes
2018-09-06 09:50:26 -04:00
Bryan Housel
cc938698e8
Add ability to select custom data
2018-08-25 11:14:04 -04:00
Bryan Housel
0a82ab125e
Add uiDataEditor for inspecting custom map data
2018-08-25 10:10:04 -04:00
Bryan Housel
a9aca707b6
Support hovering on data features
2018-08-25 00:04:52 -04:00
Thomas Hervey
06a410107b
cleaned up merge relics and comments
2018-07-20 23:31:49 -04:00
Thomas Hervey
a6bdbcabb2
merged from
2018-07-20 23:21:24 -04:00
Thomas Hervey
fbedbb1608
select note before rendering sidebar
2018-07-20 23:17:41 -04:00
Thomas Hervey
bf9b19359a
WIP drag note
2018-07-20 21:41:44 -04:00
Thomas Hervey
24579b15bc
WIP testing new drag_notes mode
2018-07-20 14:26:02 -04:00
Thomas Hervey
14212b47fe
WIP: drag note
2018-07-19 15:21:46 -04:00
Thomas Hervey
73ee5c2fc9
fixed select_note mode, cleaned note_editor, TODO: enable note save
2018-07-03 22:45:51 -04:00
Bryan Housel
bf499d9438
Restore modeSelect, and make a new modeSelectNote just for the notes
2018-07-03 18:11:59 -04:00
Bryan Housel
b14d1b5061
resolve conflicts, fix a few minor bugs prob caused by merging:
...
- don't insert multiple times into the rtree in `services/osm.js`
- use `d.id` instead of `d.key` as the key in `svg/notes.js`
2018-07-03 16:40:07 -04:00
Thomas Hervey
8121f585d5
added checks for multiclick and click on notes
2018-07-03 15:39:22 -04:00
Thomas Hervey
2c22fe00a2
updated: hacky note hovering; todo: complete note click handling
2018-07-02 10:44:47 -04:00
Thomas Hervey
1b06dbd8c9
delete: demo select file (unintentional commit)
2018-06-29 23:36:11 -04:00
Thomas Hervey
737ccfcfba
updated: siebar displays note details on hover (via svg)
2018-06-29 14:43:01 -04:00
Bryan Housel
470835b38f
Extract all graphics from iD sprite, reassemble with svg-sprite
...
All iD sprite graphics are now prefixed with `iD-`
Also includes support for sending the preset logos to taginfo
2018-06-08 16:06:46 -04:00
Bryan Housel
61c7f64077
Remember changeset source, make it settable via url param
...
(closes #4899 )
2018-03-16 09:20:32 -04:00
J Guthrie
d35494d003
Can finish drawing when cursor is in invalid position
...
- When drawing an Area, the leading edge is allowed to temporarily be in an invalid position (see #4655 )..
.. Finishing a drawing is disabled if doing so would close with the invalid leading edge
2018-03-08 02:53:03 +00:00
Bryan Housel
24eba5c1b0
Preventing snapping at viewport edge also prevented finishing ways
2018-01-20 22:45:03 -05:00
Bryan Housel
f0a27bc1ec
Simplify way segmentation and fix bug with adjacent segment type
...
(closes #4669 )
Now instead of creating MultiLineString targets, we just create a bunch of
LineString targets. This makes the code simpler, and anyway the entity is
still there in `properties` for drawing code to decide what to do with the target.
Incidentally, this change allows iD to support an extrusion operation.
(Because each way segment has its own unique GeoJSON target now)
2018-01-09 10:12:29 -05:00
Bryan Housel
e661281e38
Prevent self intersecting lines without a junction node
...
(closes #4646 )
2018-01-08 19:17:50 -05:00
Bryan Housel
ea9643e08b
Allow Alt/option key to disable geometry check and nope cursor
...
(re: #4646 )
2018-01-08 15:47:29 -05:00
Bryan Housel
58eaca2aa0
Ignore area closing segment during move when validating geometry
...
(closes #4655 )
2018-01-08 12:09:17 -05:00
Bryan Housel
ddaa828ec9
Handle both target GeoJSON and osmEntity in hover
...
(fixes test and allows hover on the area fills again)
2018-01-01 22:53:40 -05:00
Bryan Housel
6881205d43
All touch targets are GeoJSON now
...
This makes the code a bit more consistent and lets us avoid some
hacky and probably non-performant things:
- abusing CSS classes in the draw/drag datum functions (classed `.target`)
(is this thing target? just check d.properties)
- regexing the id for `-nope$`
(is this thing a nope target? just check d.properties)
- using context.hasEntity to get a the real entity
(is this thing a real osmEntity? just check d.properties)
- fixes code like the restriction editor which uses fake ids for split ways
2018-01-01 22:37:10 -05:00